From 8034bc1862bbebb332e91917c6458ef8efb5b54e Mon Sep 17 00:00:00 2001 From: Eric Ruei Date: Fri, 8 Mar 2019 18:49:07 -0500 Subject: [PATCH] weston: Fix virtual keyboard display issue for QT5 application The virtual keyboard does pop up as expected, however, it will never hide even when the application is terminated. This problem is due to the order of the text APIs( text_input_activate and test_input_show_input_panel) are invoked in QT5 and a potential bug of the API implementation. The virtual keyboard works as expected if the test_input_show_input_panel() is invoked prior to the test_input_activate() as most of the weston sample applications do. However, the problem will show up if that order is reversed and the reason why is that the current_panel is not set in this case and hence this panel cannot be hidden. It is required to set the current_panel to the text_input when the input_panel becomes visible at the first time. Upstream status: Pending Signed-off-by: Eric Ruei --- compositor/text-backend.c | 1 + 1 file changed, 1 insertion(+) diff --git a/compositor/text-backend.c b/compositor/text-backend.c index 664c36f..b610dfb 100644 --- a/compositor/text-backend.c +++ b/compositor/text-backend.c @@ -349,6 +349,7 @@ text_input_show_input_panel(struct wl_client *client, text_input->surface); wl_signal_emit(&ec->update_input_panel_signal, &text_input->cursor_rectangle); + text_input->manager->current_text_input = text_input; } } -- 1.9.1