From 791a375032d5224c6ebb5937d5816cef2917874b Mon Sep 17 00:00:00 2001 From: Casey Schaufler Date: Thu, 19 Dec 2013 13:23:26 -0800 Subject: [PATCH 18/54] Smack: change rule cap check smk_write_change_rule() is calling capable rather than the more correct smack_privileged(). This allows for setting rules in violation of the onlycap facility. This is the simple repair. Targeted for git://git.gitorious.org/smack-next/kernel.git Signed-off-by: Casey Schaufler --- security/smack/smackfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c index f5a6bb8..3198cfe 100644 --- a/security/smack/smackfs.c +++ b/security/smack/smackfs.c @@ -2152,7 +2152,7 @@ static ssize_t smk_write_change_rule(struct file *file, const char __user *buf, /* * Must have privilege. */ - if (!capable(CAP_MAC_ADMIN)) + if (!smack_privileged(CAP_MAC_ADMIN)) return -EPERM; return smk_write_rules_list(file, buf, count, ppos, NULL, NULL, -- 2.1.4