diff options
| author |   Christopher Peplin <chris.peplin@rhubarbtech.com> | 2014-01-05 18:56:37 -0500 |
|---|---|---|
| committer | Christopher Peplin <chris.peplin@rhubarbtech.com> | 2014-01-05 18:56:37 -0500 |
| commit | 2ea50110062053ef12b1c66956ec25faf7f1cb3c (patch) | |
| tree | ed2232fe6058cb5bc3a83759f066a2c3d086ffad | |
| parent | 8ca422e95dce9349afbdc399215c9c4d28c89f1a (diff) | |
Add a TODO about flipping byte order.
| -rw-r--r-- | src/obd2/obd2.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/obd2/obd2.c b/src/obd2/obd2.c index f8b4a372..402cc2f9 100644 --- a/src/obd2/obd2.c +++ b/src/obd2/obd2.c @@ -37,7 +37,8 @@ DiagnosticRequestHandle diagnostic_request(DiagnosticShims* shims, uint8_t payload[MAX_DIAGNOSTIC_PAYLOAD_SIZE]; payload[MODE_BYTE_INDEX] = request->mode; if(request->pid_length > 0) { - // TODO may need to flip the byte order + // TODO need a set bit field that's more natural and checks endianness + // becauase we DO need to flip it copy_bytes_right_aligned((uint8_t*)&request->pid, sizeof(request->pid), PID_BYTE_INDEX, request->pid_length, payload, sizeof(payload)); } |