diff options
| author |   Romain Forlot <romain.forlot@iot.bzh> | 2019-06-25 16:23:02 +0200 |
|---|---|---|
| committer | Romain Forlot <romain.forlot@iot.bzh> | 2019-06-27 09:33:12 +0200 |
| commit | f9b67aecdc07d31def64175e0f58e9c0a113f94c (patch) | |
| tree | 74a0baa6ca5d12a60f2c87893ccc086fe44fa0ce /low-can-binding/diagnostic | |
| parent | b8261a3b218de8c07173e3a0eaeb09cad10445b3 (diff) | |
Minor improvements
- Remove now unused forward declaration of active_diagnostic_request_t
- Factorize calling the signals_manager at binding initialization.
- retab...
Bug-AGL: SPEC-2386
Change-Id: I418fddd80ef8b856c198dc697760a6edf0918012
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Diffstat (limited to 'low-can-binding/diagnostic')
| -rw-r--r-- | low-can-binding/diagnostic/active-diagnostic-request.cpp | 3 | ||||
| -rw-r--r-- | low-can-binding/diagnostic/diagnostic-manager.cpp | 2 | ||||
| -rw-r--r-- | low-can-binding/diagnostic/diagnostic-manager.hpp | 2 |
3 files changed, 3 insertions, 4 deletions
diff --git a/low-can-binding/diagnostic/active-diagnostic-request.cpp b/low-can-binding/diagnostic/active-diagnostic-request.cpp index c5af449b..80d2e696 100644 --- a/low-can-binding/diagnostic/active-diagnostic-request.cpp +++ b/low-can-binding/diagnostic/active-diagnostic-request.cpp @@ -15,8 +15,9 @@ * limitations under the License. */ -#include <map> + #include <fnmatch.h> +#include <map> #include "active-diagnostic-request.hpp" diff --git a/low-can-binding/diagnostic/diagnostic-manager.cpp b/low-can-binding/diagnostic/diagnostic-manager.cpp index fa1d87af..d78c7755 100644 --- a/low-can-binding/diagnostic/diagnostic-manager.cpp +++ b/low-can-binding/diagnostic/diagnostic-manager.cpp @@ -124,7 +124,7 @@ bool diagnostic_manager_t::shims_send(const uint32_t arbitration_id, const uint8 bcm_msg.frames[0] = cf; - std::shared_ptr<message_t> msg = std::make_shared<can_message_t>(); + std::shared_ptr<can_message_t> msg = std::make_shared<can_message_t>(); msg->set_bcm_msg(bcm_msg); diff --git a/low-can-binding/diagnostic/diagnostic-manager.hpp b/low-can-binding/diagnostic/diagnostic-manager.hpp index 64a19d7c..784bcd70 100644 --- a/low-can-binding/diagnostic/diagnostic-manager.hpp +++ b/low-can-binding/diagnostic/diagnostic-manager.hpp @@ -32,8 +32,6 @@ /// #define DIAGNOSTIC_RESPONSE_ARBITRATION_ID_OFFSET 0x8 -class active_diagnostic_request_t; - /// /// @brief The core structure for running the diagnostics module of the binding. /// |