From 7747851ca010a3dfe9ffee808376dd5a7af68b91 Mon Sep 17 00:00:00 2001 From: Romain Forlot Date: Tue, 23 May 2017 23:59:27 +0200 Subject: Static code review fixes. Several style errors and mistakes mostly on constructor and passing arguments as ref. Change-Id: I2ca921d6aa70b9074392bb7779ade35bebf7bd8d Signed-off-by: Romain Forlot --- CAN-binder/low-can-binding/binding/configuration.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'CAN-binder/low-can-binding/binding/configuration.hpp') diff --git a/CAN-binder/low-can-binding/binding/configuration.hpp b/CAN-binder/low-can-binding/binding/configuration.hpp index 3ab88ee5..fc53d386 100644 --- a/CAN-binder/low-can-binding/binding/configuration.hpp +++ b/CAN-binder/low-can-binding/binding/configuration.hpp @@ -81,8 +81,8 @@ class configuration_t void set_active_message_set(uint8_t id); - std::shared_ptr get_diagnostic_message(std::string message_name) const; - DiagnosticRequest* get_request_from_diagnostic_message(std::string message_name) const; + std::shared_ptr get_diagnostic_message(const std::string& message_name) const; + DiagnosticRequest* get_request_from_diagnostic_message(const std::string& message_name) const; /* /// TODO: implement this function as method into can_bus class /// @brief Pre initialize actions made before CAN bus initialization -- cgit 1.2.3-korg