From 9ecd09263535843e287048d299ca5bdfc85d18d9 Mon Sep 17 00:00:00 2001 From: Romain Forlot Date: Fri, 2 Jun 2017 19:48:24 +0200 Subject: Remove pointer generator that make memory leaks. Only have 1 place where to generate a pointer from a DiagnosticRequest is in low-can-cb.cpp when subscribing. Else now using reference instead of raw pointer. Change-Id: I7fd2f3d30afa90017b945e6b711922036123b6d3 Signed-off-by: Romain Forlot --- CAN-binder/low-can-binding/diagnostic/active-diagnostic-request.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'CAN-binder/low-can-binding/diagnostic/active-diagnostic-request.cpp') diff --git a/CAN-binder/low-can-binding/diagnostic/active-diagnostic-request.cpp b/CAN-binder/low-can-binding/diagnostic/active-diagnostic-request.cpp index 61775b8e..f503e0a5 100644 --- a/CAN-binder/low-can-binding/diagnostic/active-diagnostic-request.cpp +++ b/CAN-binder/low-can-binding/diagnostic/active-diagnostic-request.cpp @@ -65,14 +65,14 @@ active_diagnostic_request_t::active_diagnostic_request_t() socket_{} {} -active_diagnostic_request_t::active_diagnostic_request_t(const std::string& bus, DiagnosticRequest* request, +active_diagnostic_request_t::active_diagnostic_request_t(const std::string& bus, uint32_t id, const std::string& name, bool wait_for_multiple_responses, const DiagnosticResponseDecoder decoder, const DiagnosticResponseCallback callback, float frequencyHz) : bus_{bus}, - id_{request->arbitration_id}, + id_{id}, handle_{nullptr}, name_{name}, decoder_{decoder}, -- cgit 1.2.3-korg