From 7747851ca010a3dfe9ffee808376dd5a7af68b91 Mon Sep 17 00:00:00 2001 From: Romain Forlot Date: Tue, 23 May 2017 23:59:27 +0200 Subject: Static code review fixes. Several style errors and mistakes mostly on constructor and passing arguments as ref. Change-Id: I2ca921d6aa70b9074392bb7779ade35bebf7bd8d Signed-off-by: Romain Forlot --- CAN-binder/low-can-binding/diagnostic/diagnostic-message.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'CAN-binder/low-can-binding/diagnostic/diagnostic-message.hpp') diff --git a/CAN-binder/low-can-binding/diagnostic/diagnostic-message.hpp b/CAN-binder/low-can-binding/diagnostic/diagnostic-message.hpp index ac427b97..65ed9c02 100644 --- a/CAN-binder/low-can-binding/diagnostic/diagnostic-message.hpp +++ b/CAN-binder/low-can-binding/diagnostic/diagnostic-message.hpp @@ -64,7 +64,7 @@ class diagnostic_message_t public: const char* generic_name = generic_name_.c_str(); - diagnostic_message_t(uint8_t pid, const std::string generic_name, const int min, const int max, enum UNIT unit, float frequency, + diagnostic_message_t(uint8_t pid, const std::string& generic_name, const int min, const int max, enum UNIT unit, float frequency, DiagnosticResponseDecoder decoder, DiagnosticResponseCallback callback, bool supported); uint32_t get_pid(); -- cgit 1.2.3-korg