From 6cc152447e74b1ce7fab6c7aa1f9b4e5e8232444 Mon Sep 17 00:00:00 2001 From: Clément Bénier Date: Fri, 15 Nov 2019 11:20:34 +0100 Subject: sign: handle decode methods sign from can value MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - add enumeration that represents the way of encoding: enum sign_t { UNSIGNED = 0, SIGN_BIT = 1, ONES_COMPLEMENT = 2, TWOS_COMPLEMENT = 3, SIGN_BIT_EXTERN = 4 }; - the function handle_sign allows to transform value if negative and return the sign of the value in order to be multiplied at the end ot the parcing Bug-AGL: SPEC-3021 Change-Id: I5766a286488170d930422474b4c4f3a8578ca726 Signed-off-by: Clément Bénier Signed-off-by: Romain Forlot --- low-can-binding/can/can-decoder.cpp | 73 +++++++++++++++++++++++++++++++++---- 1 file changed, 66 insertions(+), 7 deletions(-) (limited to 'low-can-binding/can/can-decoder.cpp') diff --git a/low-can-binding/can/can-decoder.cpp b/low-can-binding/can/can-decoder.cpp index e901240b..19594afa 100644 --- a/low-can-binding/can/can-decoder.cpp +++ b/low-can-binding/can/can-decoder.cpp @@ -23,6 +23,66 @@ #include "../binding/low-can-hat.hpp" #include "../utils/converter.hpp" +/// @brief Handle sign of the signal according to several decoding methods +/// +/// @param[in] signal - The signal +/// @param[in] data_signal - The data of the signal +/// @param[in] new_end_bit - The last bit of in the last byte of the data (data_signal[0]) +/// @param[in] can_data - The whole can data (needed for SIGN BIT EXTERN) +/// +/// @return Returns the sign of the data +/// +int decoder_t::handle_sign(const signal_t& signal, std::vector& data_signal, uint8_t new_end_bit, const std::vector& can_data) +{ + uint8_t data_byte = 0; + uint8_t mask = 0; + int end_bit = 0; + + if(signal.get_sign() == sign_t::UNSIGNED) + return 1; + else if(signal.get_sign() == sign_t::SIGN_BIT_EXTERN) { + end_bit = signal.get_bit_sign_position()%8; + mask = static_cast((1 << (end_bit + 1)) - 1); + data_byte = can_data[signal.get_bit_sign_position()/8] & mask; + } + else { + end_bit = new_end_bit; + mask = static_cast((1 << (end_bit + 1)) - 1); + data_byte = data_signal[0] & mask; + } + + //if negative: decode with right method + if(data_byte >> end_bit) { + switch(signal.get_sign()) + { + //remove the sign bit to get the absolute value + case sign_t::SIGN_BIT: + data_signal[0] = static_cast(data_signal[0] & (mask >> 1)); + break; + //same method twos complement = ones complement + 1 + case sign_t::ONES_COMPLEMENT: + case sign_t::TWOS_COMPLEMENT: + //complement only until end_bit + data_signal[0] = ((data_signal[0] ^ mask) & mask); + if(data_signal.size() > 1) { + for(int i=1; i < data_signal.size(); i++) { + data_signal[i] = data_signal[i] ^ 0xFF; + } + } + if(signal.get_sign() == sign_t::TWOS_COMPLEMENT) + data_signal[data_signal.size() - 1] = static_cast(data_signal[data_signal.size() - 1] + 1); + break; + case sign_t::SIGN_BIT_EXTERN: + break; + default: + AFB_ERROR("Not a valid sign entry %d, considering the value as unsigned", signal.get_sign()); + break; + } + return -1; + } + return 1; +} + /// @brief Parses the signal's bitfield from the given data and returns the raw /// value. /// @@ -49,16 +109,12 @@ float decoder_t::parse_signal_bitfield(signal_t& signal, std::shared_ptr 255) -// AFB_ERROR("Error signal %s to long bit size", signal.get_name().c_str()); - -// if(new_start_bit > 255) -// AFB_ERROR("Too long signal offset %d", new_start_bit); + int sign = decoder_t::handle_sign(signal, data_signal, new_end_bit, data); if(data_signal.size() > 65535) AFB_ERROR("Too long data signal %s", signal.get_name().c_str()); - return bitfield_parse_float(data_signal.data(), (uint16_t) data_signal.size(), + return static_cast(sign) * bitfield_parse_float(data_signal.data(), (uint16_t) data_signal.size(), new_start_bit, bit_size, signal.get_factor(), signal.get_offset()); } @@ -294,7 +350,10 @@ openxc_DynamicField decoder_t::decode_state(signal_t& signal, std::shared_ptr message, bool* send) { - + if(!signal.get_message()->frame_layout_is_little()) + { + signal.set_bit_position(converter_t::bit_position_swap(signal.get_bit_position(),signal.get_bit_size())); + } // Must call the decoders every time, regardless of if we are going to // decide to send the signal or not. openxc_DynamicField decoded_value = decoder_t::decode_signal(signal, -- cgit 1.2.3-korg