From 2ea50110062053ef12b1c66956ec25faf7f1cb3c Mon Sep 17 00:00:00 2001 From: Christopher Peplin Date: Sun, 5 Jan 2014 18:56:37 -0500 Subject: Add a TODO about flipping byte order. --- src/obd2/obd2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/obd2') diff --git a/src/obd2/obd2.c b/src/obd2/obd2.c index f8b4a372..402cc2f9 100644 --- a/src/obd2/obd2.c +++ b/src/obd2/obd2.c @@ -37,7 +37,8 @@ DiagnosticRequestHandle diagnostic_request(DiagnosticShims* shims, uint8_t payload[MAX_DIAGNOSTIC_PAYLOAD_SIZE]; payload[MODE_BYTE_INDEX] = request->mode; if(request->pid_length > 0) { - // TODO may need to flip the byte order + // TODO need a set bit field that's more natural and checks endianness + // becauase we DO need to flip it copy_bytes_right_aligned((uint8_t*)&request->pid, sizeof(request->pid), PID_BYTE_INDEX, request->pid_length, payload, sizeof(payload)); } -- cgit 1.2.3-korg