From c55d6bf59167c75439c1c40e9dcd8c05081d4685 Mon Sep 17 00:00:00 2001 From: Christopher Peplin Date: Mon, 6 Jan 2014 14:54:15 -0500 Subject: Use new set_bitfield function to handle swapping endianness. --- src/obd2/obd2.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'src/obd2') diff --git a/src/obd2/obd2.c b/src/obd2/obd2.c index 402cc2f9..fa20f91a 100644 --- a/src/obd2/obd2.c +++ b/src/obd2/obd2.c @@ -37,10 +37,8 @@ DiagnosticRequestHandle diagnostic_request(DiagnosticShims* shims, uint8_t payload[MAX_DIAGNOSTIC_PAYLOAD_SIZE]; payload[MODE_BYTE_INDEX] = request->mode; if(request->pid_length > 0) { - // TODO need a set bit field that's more natural and checks endianness - // becauase we DO need to flip it - copy_bytes_right_aligned((uint8_t*)&request->pid, sizeof(request->pid), - PID_BYTE_INDEX, request->pid_length, payload, sizeof(payload)); + set_bitfield(request->pid, PID_BYTE_INDEX * CHAR_BIT, + request->pid_length * CHAR_BIT, payload, sizeof(payload)); } if(request->payload_length > 0) { memcpy(&payload[PID_BYTE_INDEX + request->pid_length], -- cgit 1.2.3-korg