From 4d7ff60ae87f00b9bd9bfa68f4f92b5af7581e3d Mon Sep 17 00:00:00 2001 From: Marius Vlad Date: Mon, 1 Feb 2021 11:44:05 +0800 Subject: Fix potential memory leak json structure allocating code should be placed in where it is used, if there is a condition check which may cause a return before the before-mentioned place in the function. Bug-AGL: SPEC-3584 (cherry-picked from f19cfe46d7172b512f06f5acf657b8d56e69a0b3) Change-Id: I5f88c7ce0b9257b2782144548f11a0e1d7ab388a Signed-off-by: Li Xiaoming Signed-off-by: Marius Vlad --- src/hs-proxy.cpp | 1 - 1 file changed, 1 deletion(-) (limited to 'src/hs-proxy.cpp') diff --git a/src/hs-proxy.cpp b/src/hs-proxy.cpp index 30c258d..cdbf249 100644 --- a/src/hs-proxy.cpp +++ b/src/hs-proxy.cpp @@ -172,7 +172,6 @@ int HS_AfmMainProxy::detail(afb_api_t api, const std::string &id, struct json_ob */ void HS_AfmMainProxy::start(struct hs_instance *instance, afb_req_t request, const std::string &id) { - struct json_object *args = json_object_new_string(id.c_str()); struct closure_data *cdata; /* tentatively store the client and client context, as the afb_req_t -- cgit 1.2.3-korg