From b88f284107f7a37813ea093e3ab545d998cf9715 Mon Sep 17 00:00:00 2001 From: Romain Forlot Date: Wed, 21 Mar 2018 16:06:50 +0100 Subject: Linting improvments. Uninitiliazed variable in submodule Better handling of iterator assigments Avoid multiple call to vector.size() function Change-Id: I9cc8431e71b7d614a1619615a4048f19f5e31540 Signed-off-by: Romain Forlot --- signal-composer-binding/signal-composer.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'signal-composer-binding/signal-composer.cpp') diff --git a/signal-composer-binding/signal-composer.cpp b/signal-composer-binding/signal-composer.cpp index 9fc7109..2114d97 100644 --- a/signal-composer-binding/signal-composer.cpp +++ b/signal-composer-binding/signal-composer.cpp @@ -148,19 +148,20 @@ json_object* Composer::buildLuaAction(std::string name, std::string function, js std::string fName, filepath; std::string uri = std::string(function).substr(6); std::vector uriV = Composer::parseURI(uri); - if(uriV.size() > 2) + uriVsize = uriV.size(); + if(uriVsize > 2) { int i = 0; - while(i < uriV.size()-1) + while(i < uriVsize-1) {filepath += uriV[i] + "/";} - fName = uriV[-1]; + fName = uriV[uriVsize-1]; } - else if(uriV.size() == 2) + else if(uriVsize == 2) { filepath = uriV[0]; fName = uriV[2]; } - else if(uriV.size() == 1) + else if(uriVsize == 1) {fName = uriV[0];} else { -- cgit 1.2.3-korg