From 0524ef772bf0a06fec736d7e1bd0753a7b65bc8c Mon Sep 17 00:00:00 2001
From: Romain Forlot <romain.forlot@iot.bzh>
Date: Mon, 11 Dec 2017 18:53:11 +0100
Subject: Use value instead of pointer for a member

no reason to keep it as pointer, and simpler to initiaze
it at construction time.

Change-Id: I0aee4483c834e66651d80998de81c99799451ff5
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
---
 signal-composer-binding/signal.cpp | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)

(limited to 'signal-composer-binding/signal.cpp')

diff --git a/signal-composer-binding/signal.cpp b/signal-composer-binding/signal.cpp
index b9663ee..dcbf814 100644
--- a/signal-composer-binding/signal.cpp
+++ b/signal-composer-binding/signal.cpp
@@ -34,7 +34,7 @@ Signal::Signal()
  unit_(""),
  onReceived_(nullptr),
  getSignalsArgs_(nullptr),
- signalCtx_(new struct signalCBT),
+ signalCtx_({nullptr, nullptr, nullptr, nullptr}),
  subscribed_(false)
 {}
 
@@ -49,7 +49,7 @@ Signal::Signal(const std::string& id, const std::string& event, std::vector<std:
  unit_(unit),
  onReceived_(onReceived),
  getSignalsArgs_(getSignalsArgs),
- signalCtx_(new struct signalCBT),
+ signalCtx_({nullptr, nullptr, nullptr, nullptr}),
  subscribed_(false)
 {}
 
@@ -69,7 +69,7 @@ Signal::Signal(const std::string& id,
  unit_(unit),
  onReceived_(onReceived),
  getSignalsArgs_(),
- signalCtx_(new struct signalCBT),
+ signalCtx_({nullptr, nullptr, nullptr, nullptr}),
  subscribed_(false)
 {}
 
@@ -77,7 +77,6 @@ Signal::~Signal()
 {
 	json_object_put(onReceived_->argsJ);
 	json_object_put(getSignalsArgs_);
-	delete(signalCtx_);
 	delete(onReceived_);
 }
 
@@ -163,21 +162,21 @@ json_object* Signal::toJSON() const
 /// @return a pointer to the signalCtx_ member initialized.
 struct signalCBT* Signal::get_context()
 {
-	if(!signalCtx_->aSignal ||
-		!signalCtx_->searchNsetSignalValue ||
-		!signalCtx_->setSignalValue)
+	if(!signalCtx_.aSignal ||
+		!signalCtx_.searchNsetSignalValue ||
+		!signalCtx_.setSignalValue)
 	{
-		signalCtx_->searchNsetSignalValue = searchNsetSignalValueHandle;
-		signalCtx_->setSignalValue = setSignalValueHandle;
+		signalCtx_.searchNsetSignalValue = searchNsetSignalValueHandle;
+		signalCtx_.setSignalValue = setSignalValueHandle;
 
-		signalCtx_->aSignal = (void*)this;
+		signalCtx_.aSignal = (void*)this;
 
-		signalCtx_->pluginCtx = onReceived_ && onReceived_->type == CTL_TYPE_CB ?
+		signalCtx_.pluginCtx = onReceived_ && onReceived_->type == CTL_TYPE_CB ?
 			onReceived_->exec.cb.plugin->context:
 			nullptr;
 	}
 
-	return signalCtx_;
+	return &signalCtx_;
 }
 
 /// @brief Set Signal timestamp and value property when an incoming
-- 
cgit 1.2.3-korg