From eba541dae4461603e16efc12019c38e87eb4fcb1 Mon Sep 17 00:00:00 2001 From: Romain Forlot Date: Mon, 4 Dec 2017 17:28:04 +0100 Subject: Avoid mem leack, overwriting, initializing variable. Fix a memory squashing bug that segfault binder when loading directory searching for binding. Change-Id: Iedc6747d8ce49e7ff5fc2013bb7d03b5b553b89c Signed-off-by: Romain Forlot --- signal-composer-binding/source.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'signal-composer-binding/source.cpp') diff --git a/signal-composer-binding/source.cpp b/signal-composer-binding/source.cpp index 9e10e65..830f799 100644 --- a/signal-composer-binding/source.cpp +++ b/signal-composer-binding/source.cpp @@ -112,12 +112,14 @@ void SourceAPI::makeSubscription() AFB_ERROR("Error building JSON query object to subscribe to for signal %s", sig.second->id().c_str()); break; } - source.uid = sig.second->id().c_str(); + source.uid = sig.first.c_str(); source.context = (void*)sig.second->get_context(); ActionExecOne(&source, getSignals_, signalJ); // Considerate signal subscribed no matter what sig.second->subscribed_ = true; + delete(source.context); } + source.uid = ""; ActionExecOne(&source, getSignals_, nullptr); } } -- cgit 1.2.3-korg