From f7036a4eb19d89827133b6ae866eb40568bdf03e Mon Sep 17 00:00:00 2001 From: Yuta Doi Date: Fri, 25 May 2018 17:01:36 +0900 Subject: The surfaces are managed by using the roles instead of the drawing names Change-Id: I7373a54f2df334ac223b51a6cb9a643a88e7c33c Signed-off-by: Yuta Doi --- layers.json | 4 ++-- src/app.cpp | 72 ++++++++++++++++++++++++++----------------------------------- src/app.hpp | 2 +- 3 files changed, 34 insertions(+), 44 deletions(-) diff --git a/layers.json b/layers.json index 0fb9983..551c86a 100644 --- a/layers.json +++ b/layers.json @@ -15,14 +15,14 @@ "comment": "Single BackGround layer map for the Navigation, Radio and MediaPlayer" }, { - "role": "^HomeScreen$", + "role": "^HomeScreen$|homescreen", "name": "FarHomeScreen", "layer_id": 1000, "area": { "type": "full" }, "comment": "FarHomeScreen is the part of HomeScreen, and lawer layer of z order for HomeScreen" }, { - "role": "Music|Video|WebBrowser|MediaPlayer|Radio|Phone|Navigation|HVAC|Settings|Dashboard|POI|Mixer|Splitable1|Splitable2|Fallback", + "role": "Music|Video|WebBrowser|MediaPlayer|Radio|Phone|Navigation|HVAC|Settings|Dashboard|POI|Mixer|Fallback|music|video|browser|radio|phone|map|hvac|settings|dashboard|poi|fallback", "name": "apps", "layer_id": 1001, "area": { "type": "rect", "rect": { "x": 0, "y": 218, "width": -1, "height": -433 } }, diff --git a/src/app.cpp b/src/app.cpp index cf10cef..007ebd2 100644 --- a/src/app.cpp +++ b/src/app.cpp @@ -544,9 +544,12 @@ void App::check_flushdraw(int surface_id) { } void App::api_enddraw(char const *drawing_name) { + // Convert drawing_name to role + const char* role = this->convertDrawingNameToRole(drawing_name); + for (unsigned i = 0, iend = this->pending_end_draw.size(); i < iend; i++) { auto n = this->lookup_name(this->pending_end_draw[i]); - if (n && *n == drawing_name) { + if (n && *n == role) { std::swap(this->pending_end_draw[i], this->pending_end_draw[iend - 1]); this->pending_end_draw.resize(iend - 1); this->activate(this->pending_end_draw[i]); @@ -632,10 +635,10 @@ void App::surface_removed(uint32_t surface_id) { if (int(surface_id) == this->layers.main_surface) { this->deactivate_main_surface(); } else { - auto drawing_name = this->lookup_name(surface_id); - if (drawing_name) { + auto role = this->lookup_name(surface_id); + if (role) { this->allocateWindowResource("deactivate", - drawing_name->c_str(), nullptr, + role->c_str(), nullptr, [](const char*){}); } } @@ -711,7 +714,9 @@ void App::emitCarRun() { } result App::api_request_surface(char const *drawing_name) { - auto lid = this->layers.get_layer_id(std::string(drawing_name)); + // Convert drawing_name to role + const char* role = this->convertDrawingNameToRole(drawing_name); + auto lid = this->layers.get_layer_id(std::string(role)); if (!lid) { /** * register drawing_name as fallback and make it displayed. @@ -723,10 +728,10 @@ result App::api_request_surface(char const *drawing_name) { } } - auto rname = this->lookup_id(drawing_name); + auto rname = this->lookup_id(role); if (!rname) { // name does not exist yet, allocate surface id... - auto id = int(this->id_alloc.generate_id(drawing_name)); + auto id = int(this->id_alloc.generate_id(role)); this->layers.add_surface(id, *lid); // set the main_surface[_name] here and now @@ -736,24 +741,11 @@ result App::api_request_surface(char const *drawing_name) { HMI_DEBUG("wm", "Set main_surface id to %u", id); } -#if 0 // @@@@@ - // TODO: - // This process will be implemented in SystemManager - { - // Generate app id - auto id = int(this->app_id_alloc_.generate_id(drawing_name)); - this->appname2appid_[drawing_name] = id; - } -#endif - // Set map of (role, surface_id) - const char* role = this->convertDrawingNameToRole(drawing_name); this->role2surfaceid_[role] = id; - // Set map of (role, app) - // If the new app which has the same role which is had by existing app is requested, - // the role is given to the new app. - this->role2app_[role] = std::string(drawing_name); + // Set map of (role, drawing_name) + this->role2drawingname_[role] = std::string(drawing_name); return Ok(id); } @@ -821,8 +813,11 @@ result App::api_get_display_info() { result App::api_get_area_info(char const *drawing_name) { HMI_DEBUG("wm", "called"); + // Convert drawing_name to role + const char* role = this->convertDrawingNameToRole(drawing_name); + // Check drawing name, surface/layer id - auto const &surface_id = this->lookup_id(drawing_name); + auto const &surface_id = this->lookup_id(role); if (!surface_id) { return Err("Surface does not exist"); } @@ -864,11 +859,9 @@ void App::activate(int id) { char const *label = this->lookup_name(id).value_or("unknown-name").c_str(); - // FOR CES DEMO >>> - if ((0 == strcmp(label, "Radio")) - || (0 == strcmp(label, "MediaPlayer")) - || (0 == strcmp(label, "Music")) - || (0 == strcmp(label, "Navigation"))) { + if ((0 == strcmp(label, "radio")) + || (0 == strcmp(label, "music")) + || (0 == strcmp(label, "map"))) { for (auto i = surface_bg.begin(); i != surface_bg.end(); ++i) { if (id == *i) { // Remove id @@ -889,7 +882,7 @@ void App::activate(int id) { } } } - // <<< FOR CES DEMO + this->layout_commit(); this->emit_visible(label); @@ -903,11 +896,9 @@ void App::deactivate(int id) { char const *label = this->lookup_name(id).value_or("unknown-name").c_str(); - // FOR CES DEMO >>> - if ((0 == strcmp(label, "Radio")) - || (0 == strcmp(label, "MediaPlayer")) - || (0 == strcmp(label, "Music")) - || (0 == strcmp(label, "Navigation"))) { + if ((0 == strcmp(label, "radio")) + || (0 == strcmp(label, "music")) + || (0 == strcmp(label, "map"))) { // Store id this->surface_bg.push_back(id); @@ -927,7 +918,6 @@ void App::deactivate(int id) { else { this->controller->surfaces[id]->set_visibility(0); } - // <<< FOR CES DEMO this->layout_commit(); @@ -937,14 +927,14 @@ void App::deactivate(int id) { } void App::deactivate(std::string role) { - std::string app = this->role2app_[role]; - auto const &id = this->lookup_id(app.c_str()); + auto const &id = this->lookup_id(role.c_str()); if (!id) { HMI_ERROR("wm", "Surface does not exist"); return; } - HMI_DEBUG("wm", "Deactivate role:%s (app:%s)", - role.c_str(), app.c_str()); + std::string drawing_name = this->role2drawingname_[role]; + HMI_DEBUG("wm", "Deactivate role:%s (drawing_name:%s)", + role.c_str(), drawing_name.c_str()); this->deactivate(*id); } @@ -1126,8 +1116,8 @@ void App::setSurfaceSize(const char* role, const char* area) { size.x, size.y, size.w, size.h); // Emit syncDraw event - const char* app = this->role2app_[role].c_str(); - this->emit_syncdraw(app, area, + const char* drawing_name = this->role2drawingname_[role].c_str(); + this->emit_syncdraw(drawing_name, area, size.x, size.y, size.w, size.h); // Enqueue flushDraw event diff --git a/src/app.hpp b/src/app.hpp index f6b809a..245e2e7 100644 --- a/src/app.hpp +++ b/src/app.hpp @@ -254,7 +254,7 @@ private: LayoutManager lm_; std::unordered_map role2surfaceid_; std::unordered_map drawingname2role_; - std::unordered_map role2app_; + std::unordered_map role2drawingname_; std::unordered_map appid2role_; CarInfo crr_car_info_; -- cgit 1.2.3-korg