From 84ae05bc27cd9f5d461e75dfdb258e1a38c434b6 Mon Sep 17 00:00:00 2001 From: Scott Murray Date: Sat, 31 Dec 2022 00:34:31 -0500 Subject: Rework Riverpod provider usage Replace the single Riverpod provider for all vehicle signals with separate ones for each required signal used directly in the widgets that require them. This is more in line with recommended Riverpod practice, and should avoids driving full widget tree rebuilds on every signal received. Bug-AGL: SPEC-4660 Signed-off-by: Scott Murray Change-Id: Ibe1ff26f8cd95cbe9cbb477feaf31c9f4919bf6a --- lib/widgets/child_lock.dart | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) (limited to 'lib/widgets/child_lock.dart') diff --git a/lib/widgets/child_lock.dart b/lib/widgets/child_lock.dart index c2efb0d..0de2350 100644 --- a/lib/widgets/child_lock.dart +++ b/lib/widgets/child_lock.dart @@ -1,21 +1,21 @@ // SPDX-License-Identifier: Apache-2.0 -import 'package:dashboard_app/size.dart'; -import 'package:flutter/src/foundation/key.dart'; -import 'package:flutter/src/widgets/framework.dart'; import 'package:flutter/material.dart'; +import 'package:flutter_riverpod/flutter_riverpod.dart'; +import 'package:dashboard_app/size.dart'; +import '../vehicle-signals/vss_providers.dart'; -class ChildLockStatus extends StatelessWidget { - bool isChildLockActiveLeft; - bool isChildLockActiveRight; - ChildLockStatus( - {Key? key, - required this.isChildLockActiveLeft, - required this.isChildLockActiveRight}) - : super(key: key); +class ChildLockStatus extends ConsumerWidget { + ChildLockStatus({Key? key}) : super(key: key); @override - Widget build(BuildContext context) { - return isChildLockActiveLeft && isChildLockActiveRight + Widget build(BuildContext context, WidgetRef ref) { + final vehicleLeftChildLockActive = + ref.watch(vehicleSignalLeftChildLockActiveProvider); + final vehicleRightChildLockActive = + ref.watch(vehicleSignalRightChildLockActiveProvider); + + return vehicleLeftChildLockActive.engaged && + vehicleRightChildLockActive.engaged ? Column( children: [ Text( -- cgit