From 71d46d03850653c0229c678de197c6f94fceb477 Mon Sep 17 00:00:00 2001
From: Scott Murray <scott.murray@konsulko.com>
Date: Fri, 8 Dec 2023 10:28:48 +0900
Subject: More signaling fixes

Changes:
- Fixed parsing of engine speed from databroker response to use
  uint32 again to match VSS type.
- Shifted engine speed definitions in Vehicle class next to
  vehicle speed since that seems a bit saner than having it down at
  the bottom with the temperature values.
- Removed duplicate temperature state from temperature control
  widget, and pushed the use of the providers from the HVAC widget.
  The existing scheme was somewhat broken with respect to having the
  values managed with RiverPod, e.g. new values from external updates
  would not show up until switching away and back to the HVAC tab.
- Moved HVAC "SYNC" button state into the Vehicle state class to
  manage it with RiverPod, and allow use from both the HVAC and
  temperature widgets so that the expected behavior can actually be
  implemented.
- Fixed brace usage in a couple of debugPrint statements.

Bug-AGL: SPEC-4999

Change-Id: I07ea49d20fedca47e6f9e54f45ad34296e0a873c
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
---
 lib/core/constants/vss_path.dart | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'lib/core/constants')

diff --git a/lib/core/constants/vss_path.dart b/lib/core/constants/vss_path.dart
index 2147b75..99f3d60 100644
--- a/lib/core/constants/vss_path.dart
+++ b/lib/core/constants/vss_path.dart
@@ -1,5 +1,7 @@
 class VSSPath {
   static const String vehicleSpeed = 'Vehicle.Speed';
+  static const String vehicleEngineSpeed =
+      'Vehicle.Powertrain.CombustionEngine.Speed';
   static const String vehicleInsideTemperature =
       'Vehicle.Cabin.HVAC.AmbientAirTemperature';
   static const String vehicleOutsideTemperature =
@@ -13,8 +15,6 @@ class VSSPath {
       'Vehicle.Cabin.Door.Row2.DriverSide.IsChildLockActive';
   static const String vehicleIsChildLockActiveRight =
       'Vehicle.Cabin.Door.Row2.PassengerSide.IsChildLockActive';
-  static const String vehicleEngineSpeed =
-      'Vehicle.Powertrain.CombustionEngine.Speed';
   static const String vehicleFrontLeftTire =
       'Vehicle.Chassis.Axle.Row1.Wheel.Left.Tire.Pressure';
   static const String vehicleFrontRightTire =
@@ -41,6 +41,7 @@ class VSSPath {
   List<String> getSignalsList() {
     return const [
       vehicleSpeed,
+      vehicleEngineSpeed,
       vehicleInsideTemperature,
       vehicleOutsideTemperature,
       vehicleRange,
@@ -48,7 +49,6 @@ class VSSPath {
       vehicleMediaVolume,
       vehicleIsChildLockActiveLeft,
       vehicleIsChildLockActiveRight,
-      vehicleEngineSpeed,
       vehicleFrontLeftTire,
       vehicleFrontRightTire,
       vehicleRearLeftTire,
-- 
cgit