From 65fc5191f046ad8c7ba1bfd9e2e75afb925b4a21 Mon Sep 17 00:00:00 2001 From: Marius Vlad Date: Fri, 20 Jan 2023 13:34:00 +0200 Subject: protocol/grpc-proxy: Add deactivate_app request This request will hide the currently active window, and activate either the background or the previously active window. This request mimics the agl-shell-desktop request, actually using the same code path. It only handles regular windows and float/pop-up. Once we add other roles like fullscreen/split we can improve on this. Bug-AGL: SPEC-4673 Signed-off-by: Marius Vlad Change-Id: I593cda5d008dfc32fe5e3b079fad9450dc1a490d --- grpc-proxy/main-grpc.cpp | 4 ++-- grpc-proxy/shell.cpp | 5 ++++- protocol/agl-shell.xml | 19 ++++++++++++++++++- src/shell.c | 14 ++++++++++++-- 4 files changed, 36 insertions(+), 6 deletions(-) diff --git a/grpc-proxy/main-grpc.cpp b/grpc-proxy/main-grpc.cpp index a59c282..d094be5 100644 --- a/grpc-proxy/main-grpc.cpp +++ b/grpc-proxy/main-grpc.cpp @@ -260,7 +260,7 @@ global_add(void *data, struct wl_registry *reg, uint32_t id, sh->shell = static_cast(wl_registry_bind(reg, id, &agl_shell_interface, - std::min(static_cast(3), version))); + std::min(static_cast(5), version))); agl_shell_add_listener(sh->shell, &shell_listener, data); sh->version = version; } else if (strcmp(interface, "wl_output") == 0) { @@ -284,7 +284,7 @@ global_add_init(void *data, struct wl_registry *reg, uint32_t id, sh->shell = static_cast(wl_registry_bind(reg, id, &agl_shell_interface, - std::min(static_cast(3), version))); + std::min(static_cast(5), version))); agl_shell_add_listener(sh->shell, &shell_listener_init, data); sh->version = version; } diff --git a/grpc-proxy/shell.cpp b/grpc-proxy/shell.cpp index cc6ead6..b96ac39 100644 --- a/grpc-proxy/shell.cpp +++ b/grpc-proxy/shell.cpp @@ -61,7 +61,10 @@ Shell::ActivateApp(const std::string &app_id, const std::string &output_name) void Shell::DeactivateApp(const std::string &app_id) { - (void) app_id; + struct agl_shell *shell = this->m_shell.get(); + + agl_shell_deactivate_app(shell, app_id.c_str()); + wl_display_flush(m_shell_data->wl_display); } void diff --git a/protocol/agl-shell.xml b/protocol/agl-shell.xml index b8f219e..d3640f6 100644 --- a/protocol/agl-shell.xml +++ b/protocol/agl-shell.xml @@ -22,7 +22,7 @@ FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. - + Starting with version 2 of the protocol, the client is required to wait for the 'bound_ok' or 'bound_fail' events in order to proceed further. @@ -200,6 +200,23 @@ + + + + Ask the compositor to hide the toplevel window for window + management purposes. Depending on the window role, this request + will either display the previously active window (or the background + in case there's no previously active surface) or temporarily (or + until a 'activate_app' is called upon) hide the surface. + + All the surfaces are identifiable by using the app_id, and no actions + are taken in case the app_id is not/was not present. + + See xdg_toplevel.set_app_id from the xdg-shell protocol for a + description of app_id. + + + diff --git a/src/shell.c b/src/shell.c index bcfb673..b1ef59b 100644 --- a/src/shell.c +++ b/src/shell.c @@ -1438,6 +1438,15 @@ shell_activate_app(struct wl_client *client, ivi_layout_activate(output, app_id); } +static void +shell_new_deactivate_app(struct wl_client *client, struct wl_resource *shell_res, + const char *app_id) +{ + struct ivi_compositor *ivi = wl_resource_get_user_data(shell_res); + + ivi_layout_deactivate(ivi, app_id); +} + static void shell_desktop_activate_app(struct wl_client *client, struct wl_resource *shell_res, @@ -1518,7 +1527,8 @@ static const struct agl_shell_interface agl_shell_implementation = { .set_panel = shell_set_panel, .activate_app = shell_activate_app, .destroy = shell_destroy, - .set_activate_region = shell_set_activate_region + .set_activate_region = shell_set_activate_region, + .deactivate_app = shell_new_deactivate_app, }; static const struct agl_shell_ext_interface agl_shell_ext_implementation = { @@ -1818,7 +1828,7 @@ int ivi_shell_create_global(struct ivi_compositor *ivi) { ivi->agl_shell = wl_global_create(ivi->compositor->wl_display, - &agl_shell_interface, 4, + &agl_shell_interface, 5, ivi, bind_agl_shell); if (!ivi->agl_shell) { weston_log("Failed to create wayland global.\n"); -- cgit 1.2.3-korg