diff options
| author |   José Bollo <jose.bollo@iot.bzh> | 2018-07-24 12:53:15 +0200 |
|---|---|---|
| committer | José Bollo <jose.bollo@iot.bzh> | 2018-07-27 17:44:07 +0200 |
| commit | 4772c5626204f6ab0e26b938f49a6719fb10f88d (patch) | |
| tree | aa14c94506e6edbdb139653157b56c9a75d2eb17 /src/afb-apiset.c | |
| parent | 4bbad5bf527c8310c1f076a5cdf512d4385f8b76 (diff) | |
coverage: Improve coverage test
The test now raise an overall coverage rate:
lines......: 75.4% (8356 of 11080 lines)
functions..: 80.4% (1094 of 1360 functions)
Also Improve the documentation and improve parts of code.
Change-Id: Ic2b8bc2f85d4181aa0b358a953f95cb105a0eed9
Signed-off-by: José Bollo <jose.bollo@iot.bzh>
Diffstat (limited to 'src/afb-apiset.c')
| -rw-r--r-- | src/afb-apiset.c | 16 |
1 files changed, 11 insertions, 5 deletions
diff --git a/src/afb-apiset.c b/src/afb-apiset.c index f837fae7..6229b371 100644 --- a/src/afb-apiset.c +++ b/src/afb-apiset.c @@ -427,17 +427,23 @@ struct afb_apiset *afb_apiset_subset_get(struct afb_apiset *set) * Set the subset of the set * @param set the api set * @param subset the subset to set + * + * @return 0 in case of success or -1 if it had created a loop */ -void afb_apiset_subset_set(struct afb_apiset *set, struct afb_apiset *subset) +int afb_apiset_subset_set(struct afb_apiset *set, struct afb_apiset *subset) { struct afb_apiset *tmp; - if (subset == set) { - /* avoid infinite loop */ - subset = NULL; - } + + /* avoid infinite loop */ + for (tmp = subset ; tmp ; tmp = tmp->subset) + if (tmp == set) + return -1; + tmp = set->subset; set->subset = afb_apiset_addref(subset); afb_apiset_unref(tmp); + + return 0; } void afb_apiset_onlack_set(struct afb_apiset *set, int (*callback)(void*, struct afb_apiset*, const char*), void *closure, void (*cleanup)(void*)) |