From 328c4b574dfb30155b8e27d96d97a1a50b51ebb8 Mon Sep 17 00:00:00 2001 From: Jose Bollo Date: Wed, 10 Jul 2019 15:18:02 +0200 Subject: afb-xreq: Forbids (un)subscribes after reply Allowing to subscribe to a request that was replied was possible and lead to problem revealed by issues SPEC-2542 and SPEC-2599 (these issues are more related to processing unordered incoming messages). The choice was - fix the bug and authorize (un)subscribe after reply - forbids to (un)subscribe after reply Second solution was chosen for its simplicity and its networking efficiency. Bug-AGL: SPEC-2542 Bug-AGL: SPEC-2599 Change-Id: I09f48b760b1fd6f70d42b80df3c8053696c45966 Signed-off-by: Jose Bollo --- include/afb/afb-req-x1.h | 2 ++ 1 file changed, 2 insertions(+) (limited to 'include/afb/afb-req-x1.h') diff --git a/include/afb/afb-req-x1.h b/include/afb/afb-req-x1.h index d9fa1bea..0cbefc67 100644 --- a/include/afb/afb-req-x1.h +++ b/include/afb/afb-req-x1.h @@ -274,6 +274,7 @@ static inline int afb_req_x1_session_set_LOA(struct afb_req_x1 req, unsigned lev * * Establishes for the client link identified by 'req' a subscription * to the 'event'. + * Establishing subscriptions MUST be called BEFORE replying to the request. * Returns 0 in case of successful subscription or -1 in case of error. */ static inline int afb_req_x1_subscribe(struct afb_req_x1 req, struct afb_event_x1 event) @@ -286,6 +287,7 @@ static inline int afb_req_x1_subscribe(struct afb_req_x1 req, struct afb_event_x * * Revokes the subscription established to the 'event' for the client * link identified by 'req'. + * Revoking subscription MUST be called BEFORE replying to the request. * Returns 0 in case of successful subscription or -1 in case of error. */ static inline int afb_req_x1_unsubscribe(struct afb_req_x1 req, struct afb_event_x1 event) -- cgit