From bc38af3e79fbd6256c209a0673601832429e7418 Mon Sep 17 00:00:00 2001 From: Jose Bollo Date: Wed, 10 Jul 2019 15:18:02 +0200 Subject: afb-xreq: Forbids (un)subscribes after reply Allowing to subscribe to a request that was replied was possible and lead to problem revealed by issues SPEC-2542 and SPEC-2599 (these issues are more related to processing unordered incoming messages). The choice was - fix the bug and authorize (un)subscribe after reply - forbids to (un)subscribe after reply Second solution was chosen for its simplicity and its networking efficiency. Bug-AGL: SPEC-2542 Bug-AGL: SPEC-2599 Change-Id: I09f48b760b1fd6f70d42b80df3c8053696c45966 Signed-off-by: Jose Bollo --- include/afb/afb-req-x2.h | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'include/afb/afb-req-x2.h') diff --git a/include/afb/afb-req-x2.h b/include/afb/afb-req-x2.h index 5111f2f0..21bbc095 100644 --- a/include/afb/afb-req-x2.h +++ b/include/afb/afb-req-x2.h @@ -458,6 +458,8 @@ int afb_req_x2_session_set_LOA( * Establishes for the client link identified by 'req' a subscription * to the 'event'. * + * Establishing subscription MUST be called BEFORE replying to the request. + * * @param req the request * @param event the event to subscribe * @@ -476,6 +478,8 @@ int afb_req_x2_subscribe( * link identified by 'req'. * Returns 0 in case of successful subscription or -1 in case of error. * + * Revoking subscription MUST be called BEFORE replying to the request. + * * @param req the request * @param event the event to revoke * -- cgit 1.2.3-korg