From 248ec5dafada74c829dbe197888166c5807e22e2 Mon Sep 17 00:00:00 2001 From: Jose Bollo Date: Thu, 11 Jul 2019 18:20:23 +0200 Subject: afb-evt: send events in separate job Sending events in the context of the calling process had the consequence that the ordering of the messages had to be removed (see SPEC-2215 & SPEC-2219). This was not good by nature and lead to issues SPEC-2542 and SPEC-2599. Sending events in the context of the calling process also implies to delay the calling process. For this reasons, sending events is now done in an other jobs. For that reason, the count of allowed pending jobs is increased to 100 (was 50). Bug-AGL: SPEC-2215 Bug-AGL: SPEC-2219 Bug-AGL: SPEC-2542 Bug-AGL: SPEC-2599 Change-Id: I5b56d952cc187b65ad6eb9344ad74e5e8d3b7540 Signed-off-by: Jose Bollo --- include/afb/afb-daemon-v1.h | 2 +- include/afb/afb-daemon-v2.h | 2 +- include/afb/afb-event-x2.h | 7 +++++-- 3 files changed, 7 insertions(+), 4 deletions(-) (limited to 'include') diff --git a/include/afb/afb-daemon-v1.h b/include/afb/afb-daemon-v1.h index 0b8e085b..f69a9cc7 100644 --- a/include/afb/afb-daemon-v1.h +++ b/include/afb/afb-daemon-v1.h @@ -68,7 +68,7 @@ static inline struct sd_bus *afb_daemon_get_system_bus_v1(struct afb_daemon_x1 d * * Calling this function is only forbidden during preinit. * - * Returns the count of clients that received the event. + * Returns 0 in case of success or -1 in case of error */ static inline int afb_daemon_broadcast_event_v1(struct afb_daemon_x1 daemon, const char *name, struct json_object *object) { diff --git a/include/afb/afb-daemon-v2.h b/include/afb/afb-daemon-v2.h index b342b209..08160205 100644 --- a/include/afb/afb-daemon-v2.h +++ b/include/afb/afb-daemon-v2.h @@ -64,7 +64,7 @@ static inline struct sd_bus *afb_daemon_get_system_bus_v2() * * Calling this function is only forbidden during preinit. * - * Returns the count of clients that received the event. + * Returns 0 in case of success or -1 in case of error */ static inline int afb_daemon_broadcast_event_v2(const char *name, struct json_object *object) { diff --git a/include/afb/afb-event-x2.h b/include/afb/afb-event-x2.h index 097234f1..daf88d6b 100644 --- a/include/afb/afb-event-x2.h +++ b/include/afb/afb-event-x2.h @@ -45,7 +45,7 @@ static inline int afb_event_x2_is_valid(struct afb_event_x2 *event) * @param event the event to broadcast * @param object the companion object to associate to the broadcasted event (can be NULL) * - * @return the count of clients that received the event. + * @return 0 in case of success or -1 in case of error */ static inline int afb_event_x2_broadcast( struct afb_event_x2 *event, @@ -65,7 +65,10 @@ static inline int afb_event_x2_broadcast( * @param event the event to push * @param object the companion object to associate to the pushed event (can be NULL) * - * @return the count of clients that received the event. + * @Return + * * 1 if at least one client listen for the event + * * 0 if no more client listen for the event + * * -1 in case of error (the event can't be delivered) */ static inline int afb_event_x2_push( struct afb_event_x2 *event, -- cgit 1.2.3-korg