From 051bf8e79c99699704032b7b943459a30aae22c8 Mon Sep 17 00:00:00 2001 From: Matt Ranostay Date: Wed, 12 Sep 2018 10:56:00 -0700 Subject: libqtappfw: remove deleteLater instances that aren't used Remove several deleteLater calls that should have been delete's. This should solve race conditions that an object calls deleteLater(), and leaves scope before the QT main loop is called. Outcome of the race condition is that sometimes the memory allocator reallocates it to another message and causes a crash. Bug-AGL: SPEC-1680 Change-Id: Ic83d8c6c204c6e3248bbe9a9def1842e1e384b2b Signed-off-by: Matt Ranostay --- pbap/pbap.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'pbap') diff --git a/pbap/pbap.cpp b/pbap/pbap.cpp index 98c05b5..71dc7cb 100644 --- a/pbap/pbap.cpp +++ b/pbap/pbap.cpp @@ -108,7 +108,7 @@ void Pbap::refreshContacts(int max_entries) tmsg->createRequest("contacts", parameter); m_mloop->sendMessage(tmsg); - tmsg->deleteLater(); + delete tmsg; } void Pbap::refreshCalls(int max_entries) @@ -122,7 +122,7 @@ void Pbap::refreshCalls(int max_entries) tmsg->createRequest("history", parameter); m_mloop->sendMessage(tmsg); - tmsg->deleteLater(); + delete tmsg; } void Pbap::search(QString number) @@ -136,7 +136,7 @@ void Pbap::search(QString number) tmsg->createRequest("search", parameter); m_mloop->sendMessage(tmsg); - tmsg->deleteLater(); + delete tmsg; } bool compareContactPtr(QObject *a, QObject *b) @@ -269,7 +269,7 @@ void Pbap::onConnected() parameter.insert("value", eventIterator.next()); tmsg->createRequest("subscribe", parameter); m_mloop->sendMessage(tmsg); - tmsg->deleteLater(); + delete tmsg; } } @@ -284,7 +284,7 @@ void Pbap::onDisconnected() parameter.insert("value", eventIterator.next()); tmsg->createRequest("unsubscribe", parameter); m_mloop->sendMessage(tmsg); - tmsg->deleteLater(); + delete tmsg; } } -- cgit 1.2.3-korg