From 5c750385d02116a92fa4c120ccc26abb8267bc97 Mon Sep 17 00:00:00 2001
From: Raquel Medina <raquel.medina@konsulko.com>
Date: Wed, 4 Mar 2020 19:32:03 +0100
Subject: eliminate unneeded dependencies on public headers

- Remove unneeded dependencies from libqtappfw public
headers, specifically MessageEngine and Message
hierarchy header files, in preparation for refactoring
work on these areas.
This change helps shield client apps from the
upcoming changes in the library, and highlight the
separation between the library's core and the various
modules providing public interfaces to those apps.

- Make MessageType an scoped enum to fwd declare it.

- Update Copyright statement on files updated by
this patch.

Bug-AGL: SPEC-3112
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: I12fd9cdc034aa1166f6448c07befadd9d2042b05
---
 telephony/telephony.cpp | 9 ++++++---
 telephony/telephony.h   | 8 +++++---
 2 files changed, 11 insertions(+), 6 deletions(-)

(limited to 'telephony')

diff --git a/telephony/telephony.cpp b/telephony/telephony.cpp
index 716ded7..e0fe2bd 100644
--- a/telephony/telephony.cpp
+++ b/telephony/telephony.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2017 Konsulko Group
+ * Copyright (C) 2017-2020 Konsulko Group
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -14,10 +14,13 @@
  * limitations under the License.
  */
 
+#include <QDebug>
+
 #include "message.h"
+#include "telephonymessage.h"
 #include "messageengine.h"
 #include "telephony.h"
-#include "telephonymessage.h"
+
 
 Telephony::Telephony (QUrl &url, QObject * parent) :
 	QObject(parent),
@@ -88,7 +91,7 @@ void Telephony::onDisconnected()
 
 void Telephony::onMessageReceived(MessageType type, Message *message)
 {
-	if (type == TelephonyEventMessage) {
+    if (type == MessageType::TelephonyEventMessage) {
 		TelephonyMessage *tmsg = qobject_cast<TelephonyMessage*>(message);
 
 		if (tmsg->isEvent()) {
diff --git a/telephony/telephony.h b/telephony/telephony.h
index 04f55a7..097310f 100644
--- a/telephony/telephony.h
+++ b/telephony/telephony.h
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2017 Konsulko Group
+ * Copyright (C) 2017-2020 Konsulko Group
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -17,10 +17,12 @@
 #ifndef TELEPHONY_H
 #define TELEPHONY_H
 
-#include <QDebug>
 #include <QObject>
 
-#include "messageengine.h"
+class MessageEngine;
+class Message;
+
+enum class MessageType;
 
 class Telephony : public QObject
 {
-- 
cgit 1.2.3-korg