From 0ed292d3ccf93c889734960676a321d1166d3f66 Mon Sep 17 00:00:00 2001
From: Raquel Medina <raquel.medina@konsulko.com>
Date: Wed, 18 Mar 2020 23:56:31 +0100
Subject: rework message hierarchy

Rework message hierarchy with the final objective
of splitting libqtappfw into several libraries.
This commit carries the following changes:
- Simplify message hierarchy, keeping abstract
Message class, adding specialization for call and
event messages, keeping ResponseMessage, and
removing all module specific specializations.
- Add MessageFactory class to create message
objects.
- Change messages life cycle: using smart pointers
and removing QObject from message hierarchy (a
Message is not a QObject anymore and thus
'deleteLater()' is not available).
- Adapt all modules to use new message hierarchy.
- Keep ResponseMessage original constructor to
avoid breaking TaskManager.
- Message constructors have been kept public, but
will go private on a follow-up patch (once
TaskManager class has been modified to use new
MessageFactory).

Bug-AGL: SPEC-3112
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: I3a7a6325209ddeca2293f1ac745371861a947bfb
---
 voice-capabilities/CMakeLists.txt  |  4 ++--
 voice-capabilities/guimetadata.cpp | 43 +++++++++++++++++++++-----------------
 voice-capabilities/guimetadata.h   |  4 ++--
 3 files changed, 28 insertions(+), 23 deletions(-)

(limited to 'voice-capabilities')

diff --git a/voice-capabilities/CMakeLists.txt b/voice-capabilities/CMakeLists.txt
index e1a6089..e3c0de7 100644
--- a/voice-capabilities/CMakeLists.txt
+++ b/voice-capabilities/CMakeLists.txt
@@ -1,2 +1,2 @@
-add_headers(guimetadata.h guimetadatamessage.h)
-add_sources(guimetadata.cpp guimetadatamessage.cpp)
+add_headers(guimetadata.h)
+add_sources(guimetadata.cpp)
diff --git a/voice-capabilities/guimetadata.cpp b/voice-capabilities/guimetadata.cpp
index 949cb58..4c597c1 100644
--- a/voice-capabilities/guimetadata.cpp
+++ b/voice-capabilities/guimetadata.cpp
@@ -17,8 +17,9 @@
 #include <QDebug>
 #include <QJsonArray>
 
-#include "message.h"
-#include "guimetadatamessage.h"
+#include "callmessage.h"
+#include "eventmessage.h"
+#include "messagefactory.h"
 #include "messageengine.h"
 #include "guimetadata.h"
 
@@ -308,19 +309,20 @@ bool GuiMetadata::updateWeatherMetadata(QJsonObject &data)
 
 void GuiMetadata::onConnected()
 {
-	QStringListIterator eventIterator(events);
-	GuiMetadataCapabilityMessage *tmsg;
+	std::unique_ptr<Message> msg = MessageFactory::getInstance().createOutboundMessage(MessageId::Call);
+	if (!msg)
+		return;
 
-	tmsg = new GuiMetadataCapabilityMessage();
+	CallMessage *tmsg = static_cast<CallMessage*>(msg.get());
+	QStringListIterator eventIterator(events);
 	QJsonObject parameter;
 	QJsonArray actions;
 	while (eventIterator.hasNext()) {
 		actions.append(QJsonValue(eventIterator.next()));
 	}
 	parameter.insert("actions", actions);
-	tmsg->createRequest("guimetadata/subscribe", parameter);
-	m_mloop->sendMessage(tmsg);
-	delete tmsg;
+	tmsg->createRequest("vshl-capabilities", "guimetadata/subscribe", parameter);
+	m_mloop->sendMessage(std::move(msg));
 }
 
 void GuiMetadata::onDisconnected()
@@ -328,18 +330,21 @@ void GuiMetadata::onDisconnected()
 	// vshl-capabilities currently has no unsubscribe verb...
 }
 
-void GuiMetadata::onMessageReceived(MessageType type, Message *message)
+void GuiMetadata::onMessageReceived(std::shared_ptr<Message> msg)
 {
-	if (type == MessageType::GuiMetadataCapabilityEventMessage) {
-		GuiMetadataCapabilityMessage *tmsg = qobject_cast<GuiMetadataCapabilityMessage*>(message);
-		if (tmsg->isEvent()) {
-			if (tmsg->isGuiMetadataRenderTemplateEvent()) {
-				if(updateMetadata(tmsg->eventData()))
-					emit renderTemplate();
-			} else if (tmsg->isGuiMetadataClearTemplateEvent()) {
-				emit clearTemplate();
-			}
+	if (!msg)
+		return;
+
+	if (msg->isEvent()) {
+		std::shared_ptr<EventMessage> emsg = std::static_pointer_cast<EventMessage>(msg);
+		if (emsg->eventApi() != "vshl-capabilities");
+			return;
+		QString ename = emsg->eventName();
+		QJsonObject data = emsg->eventData();
+		if ((ename == "render-template") && updateMetadata(data)) {
+			emit renderTemplate();
+		} else if (ename == "clear_template") {
+			emit clearTemplate();
 		}
 	}
-	message->deleteLater();
 }
diff --git a/voice-capabilities/guimetadata.h b/voice-capabilities/guimetadata.h
index ae90cba..f082d52 100644
--- a/voice-capabilities/guimetadata.h
+++ b/voice-capabilities/guimetadata.h
@@ -17,13 +17,13 @@
 #ifndef GUIMETADATA_H
 #define GUIMETADATA_H
 
+#include <memory>
 #include <QObject>
 #include <QtQml/QQmlContext>
 
 class MessageEngine;
 class Message;
 
-enum class MessageType;
 
 class GuiMetadata : public QObject
 {
@@ -128,7 +128,7 @@ private:
 
 	void onConnected();
 	void onDisconnected();
-	void onMessageReceived(MessageType, Message*);
+	void onMessageReceived(std::shared_ptr<Message>);
 
 	const QStringList events {
 		"render_template",
-- 
cgit 1.2.3-korg