From 003cdfb640b595345b0d4d09471872c9295d0bc7 Mon Sep 17 00:00:00 2001 From: Jacobo Aragunde Pérez Date: Wed, 8 May 2019 16:56:47 +0200 Subject: Remove redundant unref MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The on_reply callback unrefs the msg pointer, but that's already unref by the application framework after the callback returns. Bug-AGL : SPEC-2310 Change-Id: Ifda4f42889d3ea61f317e7919d7a506d3b4402b8 Signed-off-by: Jacobo Aragunde Pérez (cherry picked from commit 647f9e05561ea472e2bac4d582f0b47ba087e974) --- src/libwindowmanager.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libwindowmanager.cpp b/src/libwindowmanager.cpp index 8e523b2..65684f1 100644 --- a/src/libwindowmanager.cpp +++ b/src/libwindowmanager.cpp @@ -709,7 +709,6 @@ private: callsync *call = reinterpret_cast(closure); call->onReply_(call->ok_ = afb_wsj1_msg_is_reply_ok(msg), afb_wsj1_msg_object_j(msg)); call->cond_.notify_one(); - afb_wsj1_msg_unref(msg); } public: callsync( -- cgit 1.2.3-korg