aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTasuku Suzuki <tasuku.suzuki@qt.io>2016-12-15 20:13:54 +0900
committerJan-Simon Moeller <jsmoeller@linuxfoundation.org>2016-12-16 05:48:29 +0000
commitbd3ecfb968fa756604f444692d4d7d9bdd62acdf (patch)
treef77bf94708f4eacc046723b78602493c08494cbd
parent2f3805df6fcec2b2dbf92121780175fc6f4f909b (diff)
Adding backport of another patch from Qt5 to show cover art
To show cover art in qtmultimedia, the backport patch (listed below) is needed https://codereview.qt-project.org/179866 Change-Id: Ied5b8442f6a6a495832b4ade00020e05610e2846 Signed-off-by: Tasuku Suzuki <tasuku.suzuki@qt.io>
-rw-r--r--recipes-qt/qt5/qtmultimedia/0001-GStreamer-support-cover-art-image.patch25
-rw-r--r--recipes-qt/qt5/qtmultimedia_%.bbappend1
2 files changed, 26 insertions, 0 deletions
diff --git a/recipes-qt/qt5/qtmultimedia/0001-GStreamer-support-cover-art-image.patch b/recipes-qt/qt5/qtmultimedia/0001-GStreamer-support-cover-art-image.patch
new file mode 100644
index 000000000..255220aaf
--- /dev/null
+++ b/recipes-qt/qt5/qtmultimedia/0001-GStreamer-support-cover-art-image.patch
@@ -0,0 +1,25 @@
+commit 83026d306daecdeb8743f5a7d3bfcc752555c86e
+Author: Tasuku Suzuki <tasuku.suzuki@qt.io>
+Date: Wed Dec 14 23:00:37 2016 +0900
+
+ return better images in metadata in gstreamer
+
+ cover art image uses "preview image". But "image" is better for
+ that. "preview image" will be used for thumbnail image.
+
+ Change-Id: Ic01f878f146b0369eb84e6b153fa68fbc6c54e57
+
+diff --git a/src/plugins/gstreamer/mediaplayer/qgstreamermetadataprovider.cpp b/src/plugins/gstreamer/mediaplayer/qgstreamermetadataprovider.cpp
+index 01103d65..b9e29245 100644
+--- a/src/plugins/gstreamer/mediaplayer/qgstreamermetadataprovider.cpp
++++ b/src/plugins/gstreamer/mediaplayer/qgstreamermetadataprovider.cpp
+@@ -93,7 +93,8 @@ static const QGstreamerMetaDataKeyLookup *qt_gstreamerMetaDataKeys()
+
+ //metadataKeys->insert(0, QMediaMetaData::CoverArtUrlSmall);
+ //metadataKeys->insert(0, QMediaMetaData::CoverArtUrlLarge);
+- metadataKeys->insert(GST_TAG_PREVIEW_IMAGE, QMediaMetaData::CoverArtImage);
++ metadataKeys->insert(GST_TAG_PREVIEW_IMAGE, QMediaMetaData::ThumbnailImage);
++ metadataKeys->insert(GST_TAG_IMAGE, QMediaMetaData::CoverArtImage);
+
+ // Image/Video
+ metadataKeys->insert("resolution", QMediaMetaData::Resolution);
diff --git a/recipes-qt/qt5/qtmultimedia_%.bbappend b/recipes-qt/qt5/qtmultimedia_%.bbappend
index bc4b002fd..76e3db559 100644
--- a/recipes-qt/qt5/qtmultimedia_%.bbappend
+++ b/recipes-qt/qt5/qtmultimedia_%.bbappend
@@ -6,4 +6,5 @@ SRC_URI_append = " \
file://0001-metadata-image-support-with-the-data-URL-scheme-for-.patch \
file://0001-GStreamer-support-date-time-type-in-metadata.patch \
file://0001-GStreamer-support-cover-art.patch \
+ file://0001-GStreamer-support-cover-art-image.patch \
"