summaryrefslogtreecommitdiffstats
path: root/recipes-connectivity
diff options
context:
space:
mode:
authorScott Murray <scott.murray@konsulko.com>2024-08-13 10:38:17 -0400
committerScott Murray <scott.murray@konsulko.com>2024-08-20 14:21:42 +0000
commitd3856bff8cfc0552eb51d4bf0d4ce72a4d13d4c9 (patch)
tree07ee72264ea6dc2351513e30f4a9d7b6269d1195 /recipes-connectivity
parent18c1e801bb63db3219d4cd811db0e193f70d1444 (diff)
vss-agl: Fix engine speed datatype in overlays
The Vehicle.Powertrain.CombustionEngine.Speed signal datatype was accidentally being overwritten as a float in our VSS overlays for configuring the CAN provider. I believe this was an artifact of some cutting in pasting when the signal was added and upstream recommended switching away from using OBD signals as the plan is to deprecate those. There are some downstream changes required in the homescreen and dashboard applications to handle this being fixed. Bug-AGL: SPEC-5204 Change-Id: I3582dbbef6cf915f30a50804174753da12b905ae Signed-off-by: Scott Murray <scott.murray@konsulko.com> Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl-demo/+/30173 Tested-by: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Naoto YAMAGUCHI <naoto.yamaguchi@aisin.co.jp> ci-image-build: Jenkins Job builder account (cherry picked from commit b656c0db27053e3f2e23dc37c053cd17536b0129) Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl-demo/+/30199
Diffstat (limited to 'recipes-connectivity')
-rw-r--r--recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec4
-rw-r--r--recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec.control-panel2
-rw-r--r--recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec.gw-control-panel4
3 files changed, 3 insertions, 7 deletions
diff --git a/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec b/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec
index b8a01e362..a08d94a49 100644
--- a/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec
+++ b/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec
@@ -10,13 +10,11 @@ Vehicle.Speed:
signal: PT_VehicleAvgSpeed
Vehicle.Powertrain.CombustionEngine.Speed:
- datatype: float
+ datatype: uint16
type: sensor
dbc2vss:
signal: PT_EngineSpeed
interval_ms: 100
- transform:
- math: "floor(x+0.5)"
vss2dbc:
signal: PT_EngineSpeed
diff --git a/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec.control-panel b/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec.control-panel
index b5e2b8a3d..fb85dda7e 100644
--- a/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec.control-panel
+++ b/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec.control-panel
@@ -7,7 +7,7 @@ Vehicle.Speed:
signal: PT_VehicleAvgSpeed
Vehicle.Powertrain.CombustionEngine.Speed:
- datatype: float
+ datatype: uint16
type: sensor
vss2dbc:
signal: PT_EngineSpeed
diff --git a/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec.gw-control-panel b/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec.gw-control-panel
index 6b0a9a38a..060eb5064 100644
--- a/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec.gw-control-panel
+++ b/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec.gw-control-panel
@@ -8,13 +8,11 @@ Vehicle.Speed:
interval_ms: 100
Vehicle.Powertrain.CombustionEngine.Speed:
- datatype: float
+ datatype: uint16
type: sensor
dbc2vss:
signal: PT_EngineSpeed
interval_ms: 100
- transform:
- math: "floor(x+0.5)"
# DBC mappings for other signals for V2C demo