summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2024-09-30Update virtio-loopback moduleTimos Ampelikiotis1-2/+2
Add multi-device feature Bug-AGL: SPEC-4966 Change-Id: I448c539e78fb28de4dc64deb59471d8f5a329fe2 Signed-off-by: Timos Ampelikiotis <t.ampelikiotis@virtualopensystems.com>
2024-09-20Add Rockchip board support to IC container integrationNaoto Yamaguchi11-0/+790
AGL got new board support that based on Rockchip SoC. Initial patch support AGL demo IVI only. This patch add Rockchip board support to IC container integration. Bug-AGL: SPEC-5246 Change-Id: I6203bb9e2b7cd3cad7604da45c744e88a21d1454 Signed-off-by: Naoto Yamaguchi <naoto.yamaguchi@aisin.co.jp>
2024-09-20Update drm-lease-manager to support NanoPC T6 boardNaoto Yamaguchi1-2/+2
The drm-lease-manager was already improved to support Rockchip RK3588 drm driver by 901f400634395f3a73648b1515de7f4f4c5a831f at https://git.automotivelinux.org/src/drm-lease-manager This patch enables this change. Bug-AGL: SPEC-5246 Change-Id: Ib9158841139e849bc254893cd33f11b7db265fb2 Signed-off-by: Naoto Yamaguchi <naoto.yamaguchi@aisin.co.jp>
2024-09-06meta-agl-ic-container: wireplumber: refresh patch to apply on 0.5.6George Kiagiadakis1-6/+6
Bug-AGL: SPEC-4934 Change-Id: I4832fd69b145a7c630735fee2e87a4750cedccde Signed-off-by: George Kiagiadakis <george.kiagiadakis@collabora.com>
2024-09-06meta-agl-ic-container: rename wireplumber recipes to use template versionGeorge Kiagiadakis2-0/+0
so that we don't need to rename the recipes when the version changes Bug-AGL: SPEC-4934 Change-Id: I0d588f4f68a7dd7c34367e343837e242e311fbed Signed-off-by: George Kiagiadakis <george.kiagiadakis@collabora.com>
2024-09-01Raspberrypi 5 support for IC containerNaoto Yamaguchi10-4/+5
This patch add board support for raspberrypi5. Bug-AGL: SPEC-5242 Change-Id: I9e9c244da74fd2c5d83f71b43eb40ae491276096 Signed-off-by: Naoto Yamaguchi <naoto.yamaguchi@aisin.co.jp>
2024-08-30Integrate Whisper AI into AGL Voice Agent and Update DependenciesAnuj Solanki71-1167/+5004
V1: - Removed the following recipes from meta-offline-voiceagent: - python3-scipy - python3-scikit-learn - python3-openblas - python3-lapack - python3-numpy - Updated to use meta-python-ai layer for: - python3-scipy - python3-scikit-learn - python3-openblas - python3-lapack - python3-numpy - python3-pytorch - Added all the required recipes for Whisper AI: - Included recipes for Whisper AI base and tiny model - Updated recipes for: - python3-uvloop - python3-python-crfsuite V2: - Remove vulkan from DISTRO_FEATURES as it has become coditional at upstream - Fix flutter_voiceassistant service - Update recipe of llvmlite to include the wheel for aarch64 also. V3: - Fix llvmlite recipe and some patches - Removes rasa and its dependencies - Fix agl-service-voiceagent.service Bug-AGL: SPEC-5200 Change-Id: I429e7d4b98fbbe1a4f8c1341ac8918d7d177b382 Signed-off-by: Anuj Solanki <anuj603362@gmail.com>
2024-08-26Fix rpi4 IC container build errorNaoto Yamaguchi1-1/+1
IC container build for rpi4 has build issue. This line is missed. part --source rawcopy --sourceparams="file=cm-config-agl-flutter-ivi-demo.ext4" This patch change to part --source rawcopy --sourceparams="file=agl-ivi-demo-flutter.ext4" Bug-AGL: SPEC-5237 Change-Id: I745bde7232b4711d766128d00e2ad5e4499e86f0 Signed-off-by: Naoto Yamaguchi <naoto.yamaguchi@aisin.co.jp>
2024-08-26Enable sound feature in AGL demo IVI guestNaoto Yamaguchi4-3/+27
Existing container integration can't play music by guest side music player. We have a sound management solution between guets. But it is not transparent. ICEG has plan of transparent sound management to use virtual device. This change is a 1st step of this plan. Bug-AGL: SPEC-5232 Change-Id: I5f163df3bb828b9e7adfd773efccd29414020987 Signed-off-by: Naoto Yamaguchi <naoto.yamaguchi@aisin.co.jp>
2024-08-17Fix drm lease name optionNaoto Yamaguchi1-1/+1
In quillback and previous releases, the agl-compositor drm lease name option is "--drm-lease". In change 9aa2c662, the drm lease option was changed to "--drm-lease-name", breaking compatibility. This patch changes the option from "--drm-lease-name" back to "--drm-lease". Bug-AGL: SPEC-5158 Change-Id: I7dfdc4cc5d85a1bf24270e3b8a5e93bc3d7719d5 Signed-off-by: Naoto Yamaguchi <naoto.yamaguchi@aisin.co.jp>
2024-06-27agl-compositor_git: Add minor fix for DRM leasesalmon_18.90.0salmon/18.90.018.90.0Marius Vlad2-1/+36
Missing drm_lease_name would case device fd to return always a negative integer. Bug-AG: SPEC-5160 Change-Id: If8cf51c8dab4862f9d00e5265cc4b2b20d3229c3 Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
2024-06-25Remove meta-agl-flutterScott Murray28-1745/+0
Remove the meta-agl-flutter layer and its configuration template, as it is being moved to meta-agl. Bug-AGL: SPEC-5184 Change-Id: I59e9f8616a21d2e3b97da47baef1892c904d0002 Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2024-06-24meta-agl-flutter: rework agl-image-flutterricefish_17.92.0ricefish/17.92.017.92.0Scott Murray3-12/+31
Rework agl-image-flutter to serve more as an example of including a Flutter application into a production image, while also keeping it being somewhat of a bit of a build smoketest for meta-flutter integration. Changes: - Switch agl-image-flutter over to using the release version of the Flutter engine, and dropping the SDK, dev, and test packages. - Re-enable having the gallery application get auto-started. - Add a "-debug" version of the image that keeps most of the dev bits from the previous agl-image-flutter, and bakes in stuff like package management and debug tools. This keeps an example of how such an image can be built, and will still work in the standalone case when agl-devel is not used. Bug-AGL: SPEC-5182 Change-Id: I8e59fe71f8739ae67dd9f8c743a7024fd4f52b84 Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2024-06-20meta-agl-flutter: fix up agl-image-flutterScott Murray2-6/+5
Changes: - Update flutter-gallery systemd unit with new bundle path. - Update texture test application name to fix image build. Bug-AGL: SPEC-5182 Change-Id: I7c216a82c2e53968b7cbeef2b10670a72a9b4479 Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2024-06-14Add generic graphic output over rdpJan-Simon Moeller9-0/+66
This option enables an rdp server for one primary display. It is intended to be used e.g. with the aws-ec2-x86-64 or aws-ec2-arm64 machines in the first place but can be useful for debugging purposes for local setup as well. Bug-AGL: SPEC-5093 Change-Id: I2659628d389080ba382da3c7e5ec1286c2ed1286 Signed-off-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2024-06-02Remove package for built in pluginricefish_17.91.0ricefish/17.91.017.91.0Naoto Yamaguchi1-2/+0
The lighttpd-module-alias and the lighttpd-module-access plugin changed to builtin plugin from dynamic loading plugin. This patch remove package dependency for the lighttpd-module-alias and the lighttpd-module-access from the momiweb. Bug-AGL: SPEC-5158 Change-Id: I718a480f697d3cc7ff790ba371174a57131746a1 Signed-off-by: Naoto Yamaguchi <naoto.yamaguchi@aisin.co.jp>
2024-06-02Adjust image based on RR release policyNaoto Yamaguchi10-397/+7
Change image name to new naming. Remove dropped image from multi container integration. Bug-AGL: SPEC-5158 Change-Id: I5fad2dbac1f0302f170f08d4a6d538db43fd1e4c Signed-off-by: Naoto Yamaguchi <naoto.yamaguchi@aisin.co.jp>
2024-06-02Update mominavi to fix style errorNaoto Yamaguchi1-1/+7
The mominavi out style error after Jan. 2024. Previous mominavi doesn't have capability for style setting change. This patch fix this error using configurations by recipe. Bug-AGL: SPEC-5158 Change-Id: I6571bf9e39cf8b0563d7842e3f29962987d8e37e Signed-off-by: Naoto Yamaguchi <naoto.yamaguchi@aisin.co.jp>
2024-06-02Avoid seatd error in guest containerNaoto Yamaguchi1-0/+2
After the scarthgap update, the weson couldn't handle input device in guest container. It causes by libseat error that use by weston 13. This patch add environment variable to avoid seatd error. Bug-AGL: SPEC-5158 Change-Id: Ie12a65ae4f2737565bbc7cc1f6e44728a7ccdec0 Signed-off-by: Naoto Yamaguchi <naoto.yamaguchi@aisin.co.jp>
2024-06-02Add additional network configuration for end0Naoto Yamaguchi2-0/+8
After the scarthgap update, a eth0 device force rename to end0 in boot time. This patch fix loss capability for network IP configuration by systemd-networkd. Bug-AGL: SPEC-5158 Change-Id: I483845f475472c0a12c17f81ccc5bc22a9f9e65e Signed-off-by: Naoto Yamaguchi <naoto.yamaguchi@aisin.co.jp>
2024-06-02Change rootfs file name to adopt to scarthgap ruleNaoto Yamaguchi1-1/+1
After the scarthgap update, the '.rootfs' add to deploy rootfs file name. This patch fix rootfs file name for guest container that is used in wic integration. Bug-AGL: SPEC-5158 Change-Id: I431e713d3d8f6e5704743bf1cd8d43b4d5af3313 Signed-off-by: Naoto Yamaguchi <naoto.yamaguchi@aisin.co.jp>
2024-05-27meta-agl-devel: remove meta-oem-production-readinessJan-Simon Moeller72-1676/+0
Fails to build: /master/meta-agl-devel/meta-oem-production-readiness/meta-agl-basesystem/recipes-kernel/kernel-module-evklib/kernel-module-evklib_1.0.0.bb:do_compile /master/meta-agl-devel/meta-oem-production-readiness/meta-agl-basesystem/recipes-apis/agl-service-ns-notificationpersistent/agl-service-ns-notificationpersistent_1.0.0.bb:do_compile /master/meta-agl-devel/meta-oem-production-readiness/meta-agl-basesystem/recipes-apis/agl-service-ss-systemmanager/agl-service-ss-systemmanager_1.0.0.bb:do_compile /master/meta-agl-devel/meta-oem-production-readiness/meta-agl-basesystem/recipes-support/ss-interfaceunified/ss-interfaceunified_1.0.0.bb:do_package_write_rpm Restore if you intent to maintain it. Bug-AGL: SPEC-5151 Change-Id: I9a4a3fd69e19a04f0202a8d86f3d6d84b7e2c329 Signed-off-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2024-05-27meta-agl-devel: remove meta-agl-wireless-monitorJan-Simon Moeller17-374/+0
Unused and unmaintained. Restore if you intent to maintain it. Bug-AGL: SPEC-5151 Change-Id: I871192973167cc674e47867961a3525459aeeca8 Signed-off-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2024-05-27meta-agl-devel: remove meta-agl-jailhouseJan-Simon Moeller29-7498/+0
Unused and unmaintained. Restore if you intent to maintain it. Bug-AGL: SPEC-5151 Change-Id: I9c57689b06474b74051db8d6a436309cab65c1f8 Signed-off-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2024-05-13vhost-device-sound recipeMichele Paolino3-0/+286
This recipe compiles and installs the rust vhost-device-sound device to AGL. It works with scarthgap (for now tested with qemux86) Bug-AGL: SPEC-4966 Change-Id: I6acdbeabfb4e0b2d236d37ea62af973645f87b99 Signed-off-by: Michele Paolino <m.paolino@virtualopensystems.com>
2024-05-08meta-agl-ic-container: fix packagegroup-agl-core-selinux-guestScott Murray1-1/+3
packagegroup-agl-core-selinux-guest now triggers a packaging QA check due to it being marked as allarch and pulling in libraries that get renamed by the Debian library renaming logic used by upstream. To fix, follow what is done by the similar packagegroups in meta-selinux and not use packagegroup.bbclass. Bug-AGL: SPEC-5123 Change-Id: I1391977d5db3aad3d4e87ff8d043a3bb26b7074a Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2024-05-08meta-agl-ic-container: handle scarthgap IMAGE_NAME_SUFFIX changeScott Murray1-1/+1
Use the IMAGE_NAME_SUFFIX variable in the container image copying logic to handle its addition into the image filenames by upstream. Bug-AGL: SPEC-5123 Change-Id: I65fb062dc02ea44847787e5a7e6deaf524d9ff42 Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2024-05-08meta-agl-ic-container: update wayland-ivi-extension for Weston 13Scott Murray8-230/+67
Update the wayland-ivi-extension recipe to use latest upstream master branch commit to get Weston 12 support, and apply the pending Weston 13 support PR as a patch. All previous local patches have been dropped. Bug-AGL: SPEC-5123 Change-Id: I88a5ba0500cecc241c1abc6b6babb805ec20631d Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2024-05-05agl-compositor: Update/port patches for AGL compositorMarius Vlad1-41/+52
Bug-AGL: SPEC-5123 Change-Id: If1c541a1bad718ee7bc7634c0ccc83892fdf4a0e Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
2024-05-05weston: Update/port patches for Weston 13Marius Vlad3-126/+120
Bug-AGL: SPEC-5123 Change-Id: I1c1c59878c1975d8de278cee9a28ec9161c337bf Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
2024-05-02meta-agl-drm-lease: forward port patch to mesaJan-Simon Moeller2-8/+9
This updates the patch in the dynamic layer. Bug-AGL: SPEC-5123 Change-Id: I4c3b10b1f1ef8db7b8f45aa9fb56e7de7aa9746b Signed-off-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2024-05-01meta-agl-ic-container: updates for scarthgap upgradeScott Murray8-22/+28
Initial set of fixes to handle upgrade to YP 5.0 / scarthgap. The images are still not buildable after these changes due to the DRM lease changes to Weston needing further work. Changes: - Rename gstreamer1.0-plugins-bad bbappend for version bump. - Update rcar-gen3 kernel module bbappends to be compatible with upstream recipe changes. - Update lxc bbappend to handle addition of lxc-monitord in new version. - Refreshed wireplumber patch to fix QA errors. - Dropped dlt-daemon logging patch for now, IC EG will need to investigate whether it is still required. Bug-AGL: SPEC-5123 Change-Id: I3c49bee8c53ef5127950643d3f455167e4da30d9 Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2024-05-01meta-agl-drm-lease: update weston bbappendScott Murray1-0/+0
Update weston bbappend version to handle upgrade to YP scarthgap. Further work is required to rebasing the DRM lease patches against Weston 13.0. Bug-AGL: SPEC-5123 Change-Id: Iea4753741c3cdda6145afbec2352c91b73295621 Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2024-04-24Add Yocto Project scarthgap release compatibilityScott Murray10-10/+10
Switch to scarthgap in LAYERSERIES_COMPAT in layer.conf files. Bug-AGL: SPEC-4578 Change-Id: I50e341efd6a317a830352d44db1cd756d3589861 Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
2024-03-27meta-agl-test: updateYan1-1/+9
update for 2024/3, monthly Bug-AGL: SPEC-4753 Change-Id: I2e9d3767914991f1e4a72a257632c33bb205a531 Signed-off-by: Yan <yanxk.fnst@fujitsu.com>
2024-03-21Update meta-flutterJoel Winarske11-147/+15
-renames meta-flutter to flutter-layer -adds meta-flutter-apps named flutter-apps-layer -moves flutter-gallery to dynamic layer Signed-off-by: Joel Winarske <joel.winarske@gmail.com> Change-Id: I273ca820b86273e7e7de11cc25c57fca295643fc
2024-03-19meta-agl-flutter: mask out libstd-rs bbappendScott Murray1-0/+4
The libstd-rs bbappend in meta-flutter breaks building with newer versions of Rust, so BBMASK it out for now. Since the change it makes is to enable debugging Dart/Rust FFI wrappers, and AGL does not currently use such functionality, this should not change any behavior. Bug-AGL: SPEC-5070 Change-Id: I6984303bfc478a7574992f3d927bdaaeb41afa7c Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2024-02-27agl-test-framework: Fix typoHuangjinhui1-1/+1
fast mode was spelled incorrectly Bug-AGL: SPEC-4733 Change-Id: I8de89fb018014b5f18d50ef56b2b951789ef85c8 Signed-off-by: Huangjinhui <huangjh.jy@fujitsu.com>
2024-02-16meta-offline-voice-agent: remove 'virtual/' RPROVIDESScott Murray13-16/+16
Replace 'virtual/vosk-model' RPROVIDES use with just 'vosk-model' to future-proof for Yocto Project 5.0 / Scarthgap, where it triggers a warning. Also update checksums in a couple of the model recipes to fix errors seen during test builds. Bug-AGL: SPEC-5067 Change-Id: I6d39342059c93d7bef77e9b65ff11a9b2aee51aa Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2024-02-13Add gitlab issue/merge request templatesricefish_17.90.0ricefish/17.90.017.90.0Jan-Simon Moeller2-0/+6
Add template files for gitlab Bug-AGL: SPEC-4474 Signed-off-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org> Change-Id: I3a9eec6305cb434abad98e9d77a73f8693cbe2d0
2024-02-09virtio: fix bblayer dependencies and include fileJan-Simon Moeller3-3/+13
To make the feature build, we need to adapt the dependencies. There are also 2 packages that do not build - mask them till they are fixed. Bug-AGL: SPEC-4834 Change-Id: Id35be44e14d2c0c429e403126953c3d5c78241a6 Signed-off-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2024-01-29New virtio-loopback-adapter repository addedquillback_16.93.0quillback/16.93.016.93.0Michele Paolino2-2/+3
This patch forces the use of the right virtio-loopback repository. We can now close SPEC-4966 Bug-AGL: SPEC-4966 Change-Id: I85c4e290d396e7189d297c101416662940db1f35 Signed-off-by: Michele Paolino <m.paolino@virtualopensystems.com>
2024-01-29Sync rebooting cluster-service and cluster-refguiNaoto Yamaguchi3-1/+7
The cluster-refgui shall re-connect in case of cluster-service rebooting. This method should support to realize robustness system. This patch add support sync rebootig feature. Bug-AGL: SPEC-5040 Change-Id: Iadd1c254d4b8e32be15419b3526dc581333a5456 Signed-off-by: Naoto Yamaguchi <naoto.yamaguchi@aisin.co.jp>
2024-01-29Remove auditd and policy tool in guestNaoto Yamaguchi2-0/+32
The SELinux policy set at host in boot time, the guest container shall not overwrite SELinux policy. On the other hand, existing guest integration install SELinux policy tool in guest. The auditd has same issue. That shall work in host, shall not work in guest. This patch fix these issue. Bug-AGL: SPEC-5039 Change-Id: I3887d4f64d31a833f5e47fd9fb41e8fbbf6efe1e Signed-off-by: Naoto Yamaguchi <naoto.yamaguchi@aisin.co.jp>
2024-01-03flutter-auto: Add support for width/height activation areaMarius Vlad4-1/+256
Bug-AGL: SPEC-5038 Change-Id: I9d775fee5f806069982718c2b3247ce1fac3241d Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
2023-12-29Vhost-user-console device and can license fixesMichele Paolino16-2/+1755
This patch presents a new console device and fixes vhost-user-can license. vhost-device can and conosle devices will be proposed to rust-vmm/vhost-device community, and in case of acceptace this patch will be updated. Bug-AGL: SPEC-4834 Change-Id: I4dcded8733195158f848bd0e4fd4f4618a378c3a Signed-off-by: Michele Paolino <m.paolino@virtualopensystems.com>
2023-12-26Move cluster core package to cluster demo imageNaoto Yamaguchi2-1/+1
This patch is a workaround. Current guest-image-minimal is used by guest-image-cluster-demo and guest-image-ivi-demo. The cluster core package is include at guest-image-minimal. In this case, cluster core package is install to cluster and ivi image. That cause twin cluster service run on one system. This patch fix this issue, but it's only a workaronud. Will be re-structure for image-recipes. Bug-AGL: SPEC-4990 Change-Id: I5b9a23042e0796b49ed7703b5860c8a600007251 Signed-off-by: Naoto Yamaguchi <naoto.yamaguchi@aisin.co.jp>
2023-12-26Up revision to cluster-service oriented versionNaoto Yamaguchi1-1/+1
The latest cluster service is supporting demo signal passing by cluster API. This patch change cluster-refgui to cluster-service oriented version that behavior is controlled by cluster-service. Bug-AGL: SPEC-4991 Change-Id: Ibe687482bbf2b21b21668596cc035e0c4fe1ec33 Signed-off-by: Naoto Yamaguchi <naoto.yamaguchi@aisin.co.jp>
2023-12-13CAN, GPIO, RNG vhost-devices for virtio-loopback [v6]quillback_16.92.0quillback/16.92.016.92.0Michele Paolino37-5695/+1941
This patch adds key components of the viritio-loopback architecture: - kernel-module-virtio-loopback: the virtio loopback kernel driver - CAN, GPIO and RNG vhost-user devices from meta-virtualization (commit a215d8320edee0a317a6511e7e2efa5bba867486) Notes: - libgpiod, comes from meta-openembedded commit 3029554ceb0b0bb52a8d8ec3f0a75c5113662fe6 - cleaned eg-virt from unused drivers (kernel-module-virtio-video) Bug-AGL: SPEC-4834 V2 changes: - related meta-virtualization commit message added in the cover letter - updated libgpio recipe to v2.1 - SPEC reference added in cover letter v3 - add vhost-device-can preliminary version. This is placed here with the objective to share the link when proposing the new device to the rust-vmm/vhost-device community - remove cargo-update-recipe-crates includes in bb file because it is not supported by the rust mixin layer - vhost-device folder README changes v4 - fixed libgpiod required version - tested ref hw and qemu x86/64 builds - vsock, scsi and i2c rust devices removed from the build as they are not yet integrated in virtiod-loopback - cleaned-up kernel modules kernel-module-virtio-video and gstreamer1.0-plugins-bad - virtio-loopback-driver set to 2-or-later v5 - Merge with Jan-Simon version v4: - remove broken kernel-module-virtio-video - use FEATURE_PACKAGES instead of IMAGE_INSTALL:append - rename virtio-loopback-driver.bb to kernel-module-virtio-loopback_git.bb for consistency v6 - adding version in the title - removing MODULE_GIT_REPOSITORY in kernel-modules Change-Id: Id6cc58e777b9edad03b6c50d0dddaac8601edeaf Signed-off-by: Michele Paolino <m.paolino@virtualopensystems.com> Signed-off-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2023-12-12agl-test-framework: bump SRCREVYan1-1/+3
add tar ptest into suites. Change-Id: I668e0d92847f04c463a152010ce01b7ae51bc259 Signed-off-by: Yan <yanxk.fnst@fujitsu.com>