summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-12-204a-alsa-core: bump to last revisionStephane Desneux1-1/+1
This includes the following changes: * 985df9f alsaSetGetCtls: fixed a memory leak * 25e4773 Move autobuild to top tree * 838192f Add test for 4a-alsa-core * 2a9a1b6 Change .gitmodules following submodule migration * 6a6963c Migrate app-templates to CMake module Change-Id: Id5344ff70e2c5d30c55be3f40ffaf6ad2b5ef880 Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2018-12-204a-softmixer: bump to last revisionStephane Desneux1-1/+1
The following changes are now in: * e0f57e5 Add support for bluetooth telephony * 7df040a Move autobuild to top tree * bab2030 Add tests for 4a-softmixer * 44e34ee Update version of app-controller-submodule * 8135317 Change .gitmodules following submodule migration * 6f89839 Add gitreview file to 4a-softmixer repo Change-Id: I0674f2852f4d27c27ecd6e7086a9fc45ca9a11b0 Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2018-12-204a-mixer: bump to laster versionStephane Desneux1-1/+1
This introduces the changes: * d32d36b Reworked the way qml create sliders * f8da591 Fix indent using tab instead of spaces * 1b8ad36 Handle the volume_changed event * 09f1cb7 Fix json format changed since v3 * 1406acd Modify graphic role * dc32441 Merge "delete application_name check in tap_shortcut event" |\ | * f2d1e14 delete application_name check in tap_shortcut event * 23736fb Migrate app-templates to CMake module Change-Id: I4238178d06cf7657d8bdfabd5cad56e4fd8082ce Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2018-12-20bluez-alsa: removed the PCM hack, and build a shared libThierry Bultel6-1063/+924
This removes the deprecated PCM proxy hack, and brings mandatory features for the softmixer. This change applies on top of the latest bluez-alsa master of 2018-12-04 and brings 3 patches: 1) builds a shared library and links bluez-alsa and ioplug controls & pcm to it. 2) func log by default 3) increase the number of max connections from clients (pcm & ctrls) ----- Upstream status for the patches: 1) pending. Based on a submitted PR that is not clean enough and that the maintainer does not want to take before at least 6 months https://github.com/Arkq/bluez-alsa/pull/95 2) pending. Was submitted as part of the Ofono support in bluez-alsa, but was not retained. See the original PR for Ofono for that. 3) pending. The maintainer is OK with this but wants to refactor the client-server protocol in the coming months. In a private mail of 12/06/2018: "Yes, you can increase this hardcoded limit as a temporary workaround. I've put in there (and made it rather low) as a reminder, that clients are stored in the list, which might not be optimal for larger number of connected clients. In the future bluealsa will support audio mixing, so connecting many clients to a single transport will be a common case. So, I've thought about incorporating more efficient structure for storing (in particular searching) connected client - something with log(n) search complexity. Then, it might be worth to implement this container to be dynamic with an upper capacity limit (which might be high, like 200-300 clients)." Change-Id: Ia771613a7a83cc9ed6108399cdaacdeda603d39b Signed-off-by: Thierry Bultel <thierry.bultel@iot.bzh>
2018-12-20docs: add yaml bookFrederic Marec1-0/+13
Bug-AGL: SPEC-1988 Change-Id: Ic596e9903dea74334acdb90a1cdb9a9863a742c2 Signed-off-by: Frederic Marec <frederic.marec@iot.bzh>
2018-12-20weston: Add patch to improve gst-record robustnessScott Murray2-0/+52
Add a patch to do some retries with a delay when the gst-record feature is initializing and attempts to query the omx encoder plugin for its buffer pools. It is not clear why exactly the encoder is not consistently ready at this point, but in my testing this change greatly improved the robustness of weston startup with gst-record enabled. Change-Id: Ibd26ad64be035e1f9d40cc3cd9337e9efeabfad4 Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2018-12-20Update agl-gstrecorder featureScott Murray2-2/+1
The agl-gstrecorder feature was not setting a DISTRO_FEATURE, add an include file that does so and a reference to it in the feature's local.conf.inc file. The "gst-record" DISTRO_FEATURE is already referred to meta-agl/meta-agl-bsp, so this fixes that usage. Change-Id: I2140d75a44f128226ea901ed9edfd1bce5526c53 Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2018-12-19move 4a-hal-unicens (plugin) to gerritTobias Jahnke1-4/+4
Bug-AGL: SPEC-1505 Change-Id: Ia9e2098ecaede966a49e9926a915c31dc7470813 Signed-off-by: Tobias Jahnke <tobias.jahnke@microchip.com>
2018-12-14Bump snd-avirt revisionMark Farrugia1-1/+1
Crucial fixes, including cure for potential kernel panic crash Change-Id: I3d163e1a5a1c387d09481d162f748e3b63c288d2 Signed-off-by: Mark Farrugia <mark.farrugia@fiberdyne.com.au>
2018-12-14Bump qlibwindowmanager revisionKazumasa Mitsunari1-1/+1
This patch includes the followings 3ff0715 Inherit LibWindowmanager d186c2c Use simple API of libwindowmanager 93b1927 Fix memory leak when application dead Change-Id: I75b29152c7ea6cb75ccdff06baa7049603ed5191 Signed-off-by: Kazumasa Mitsunari <knimitz@witz-inc.co.jp>
2018-12-07Move hal configuration files into own repositoryJan-Simon Möller10-33/+182
... and own recipe This allows to manage the various types of configuration files independently of the source code as these might not always fit into the git repo context-wise. Initial recipe is 4a-hal-device-config.bb . This is re-using the same mechanism as previously used. Samples for alternative implementations and vendor hals are included as well to explore improved ways of handling the multipe configuration files possible. Bug-AGL: SPEC-2011 Change-Id: Ib04b5c4e7b764bed85dbceb50a62a8c6fd031c5a Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-11-30Change 4a-softmixer SRC_URI to gerritguppy_6.99.2guppy/6.99.26.99.2Jan-Simon Möller1-1/+1
Change the softmixer SRC_URI to gerrit. Change-Id: I54e78d80a83e9ff7e8726ecd803ec10eb8dbdc70 Bug-AGL: SPEC-1731 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-11-30speech-framework: Add initial speech-framework featureShotaro Uchida4-0/+33
Change-Id: I458161fea56928e338c1fe208e643e9a33141f6e Signed-off-by: Shotaro Uchida <shotaru@amazon.com>
2018-11-294a: adjust 4a_wait_bt.sh due to changes in bluetooth-manager APIStéphane Desneux1-2/+2
The verb 'power' is now replaced by 'adapter_state'. The response object is also different (no compatibility with older API). Bug-AGL: SPEC-1630 Change-Id: I2e08c33e2936d93cfdec0c498570c77177a4b81e Signed-off-by: Stéphane Desneux <stephane.desneux@iot.bzh>
2018-11-28hal-unicens: bump unicens hal to newest versionTobias Jahnke1-1/+1
Bug-AGL: SPEC-1505 - enables audio to unicens sound card - cleanup of plugin implementation - removed legacy stream, pcm playback volume - ensure init success to allow loading the plugin Change-Id: I0d7afd1c76d2b913e3684bbbcbc599f315061d85 Signed-off-by: Tobias Jahnke <tobias.jahnke@microchip.com>
2018-11-234a-hal-unicens: add HAL for unicensguppy_6.99.1guppy/6.99.16.99.1Tobias Jahnke2-6/+18
Bug-AGL: SPEC-1505 - enabled 4a-hal-unicens recipe again - updated srcrev of github repo - modified project name to match install folder Change-Id: I9afa86afa602845bf783a41b09f590344f26c095 Signed-off-by: Tobias Jahnke <tobias.jahnke@microchip.com>
2018-11-22bump softmixer to latest version (bug fixes)Thierry Bultel1-1/+1
This bring these commits: b678f3 config.cmake: bump the needed version of alsalib to 1.1.6 a84a93 Remove an unfilled response json object a07c4c removed the dependency to alsalib-1.1.6 for host 70fb34 Lower the verbosity when not in debug level b34cd9 Migrate app-templates to CMake module 58d666 Merge pull request #2 from iotbzh/app-templates-migration 03aa71 config.cmake: fixed a typo ca6383 alsa-core-pcm: fixed the mute logic 0e37ab Tweaking debug prints 92e038 Handle too small card PCM buffer when writing a17d52 Fix the error string of attach actions 118377 remove dead code and renamed unobvious variables Change-Id: Ie3e922f423ec9d6ba38c35263183d0e9143e5958 Signed-off-by: Thierry Bultel <thierry.bultel@iot.bzh>
2018-11-20Add initial recipes for snd-avirt driverMark Farrugia5-0/+132
The snd-avirt driver will provide an enhanced, dynamic ALSA loopback interface for 4a-softmixer, and provides the audio framework for low-latency audio hardmixers such as the Fiberdyne DSP onboard the Xtensa HiFi2, and the UNICENs Fiberdyne smart amplifier. Included are backport patches for kernels 4.12 and 4.9. Change-Id: I8b23507d7179d10dfa70b7f2f899db4534690392 Signed-off-by: Mark Farrugia <mark.farrugia@fiberdyne.com.au>
2018-11-15Add cmake-apps-module dependencyRomain Forlot1-1/+1
This fix bindings installation when they don't use the aglwgt main class Change-Id: I0868e0c6df757c5025fc4f9d21e46f8441646506 Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
2018-11-09meta-audio-4a: remove UNICENS legacy halTobias Jahnke2-2/+1
Bug-AGL: SPEC-1505 - Remove UNICENS legacy hal from build until the new hal plugin is available - Remove ldpath which was required to load the legacy hal (avoids binder startup error since the path is no longer available) Change-Id: If25094d4f944e887fed0ed10c5cae8049ce6db82 Signed-off-by: Tobias Jahnke <tobias.jahnke@microchip.com>
2018-10-30agl-service-windowmanager_git.bb: Remove LICENSE.MITLeon Anavi1-2/+1
Following the refactor from SPEC-1817, file LICENSE.MIT was removed from the source code therefore the recipe also has to be adjusted accordingly. Bug-AGL: SPEC-1868, SPEC-1817 Change-Id: Ib671c37f53ed0f50e9e9232e15871eeee054c37d Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
2018-10-26Bump agl-service-windowmanager revisionKazumasa Mitsunari1-1/+1
This commit includes the followings 8342c42 Fix the conversion table 5414b71 Delete verbs no longer used b1f7a75 Merge "Refactor : Hide wayland operations from Window Manager" 5a2494b Merge "Improve ApplicationGuide" 6819f40 Refactor : Hide wayland operations from Window Manager 3338ef2 Improve ApplicationGuide Change-Id: I10a9078d498389a40bd9f20037f77a5434cd9285 Signed-off-by: Kazumasa Mitsunari <knimitz@witz-inc.co.jp>
2018-10-24Merge "Bump agl-service-windowmanager revision"José Bollo1-1/+1
2018-10-20Merge "Add necessary DISTRO_FEATURES to gstrecorder template"Jan-Simon Moeller3-1/+18
2018-10-19Add necessary DISTRO_FEATURES to gstrecorder templateJan-Simon Möller3-1/+18
These are missing to enable the whole machinery on the sender side. CAVEAT: The network between sender and receiver needs to be up (192.168.20.x/24) or weston will not start! Change-Id: Ib478f0840dd3e6d28f9ca14540302c872c5bcd7b Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-10-18Bump agl-service-windowmanager revisionKazumasa Mitsunari1-1/+1
This commit includes 9fabd65 Fix memory leak 7526846 Include WMClient into WMRequest 3621896 Omit std:: b87827d Fix verbs 2fd5d33 Rename file names 5b1cf56 Migrate hmi-debug into util 152d6e0 Merge "Drop 2017 suffix" e7ba7ca Drop 2017 suffix 2dfacac Use feature 'required-binding' f0d9414 Clean: Remove split_layout structure f98c0d9 Add .gitignore 88d27f7 Modify .gitreview Change-Id: Ic2c741b020c0609983edc6a8c11ae1289b8913b9 Signed-off-by: Kazumasa Mitsunari <knimitz@witz-inc.co.jp>
2018-10-13Bump 4a-hal-unicens to latest revisionJan-Simon Möller1-1/+1
Include the update from Tobias Change-Id: Id60efedc0b65dba8d5caf8c1a2455378e6c4435b Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-10-11Merge "4a: Use '4a-hal-generic' gerrit repository"Jan-Simon Moeller1-3/+3
2018-10-094a: Use '4a-hal-generic' gerrit repositoryJonathan Aillet1-3/+3
Use '4a-hal-generic' gerrit repository instead of github one. Bug-AGL: SPEC-1405 Change-Id: I08f6db8b3e339520dfc21410db0627dc6f7c3a86 Signed-off-by: Jonathan Aillet <jonathan.aillet@iot.bzh>
2018-10-08agl-service-windowmanager : Drop -2017Kazumasa Mitsunari3-4/+4
Move repository from agl-service-windowmanager-2017 to agl-service-windowmanager Change-Id: I5905509a12f2db407766219ed1a1d536d83bb1fe Signed-off-by: Kazumasa Mitsunari <knimitz@witz-inc.co.jp>
2018-10-024a: Update 4a-hal-generic for UpSquared boardJonathan Aillet1-2/+2
This commit bump '4a-hal-generic' to have Intel UpSquared hal available in ./4a-hal-generic/etc.available/. An update of the recipe is also made to automatically deploy Intel UpSquared hal in ./4a-hal-generic/etc/. when compiling AGL for 'intel-corei7-64' platform. * a94119d Correct typo in Intel UpSquared hal * 2b64aed Update clone commands in README.md * 4a2672a Update 'halmap' section of Intel UpSquare hal * 424263f Merge pull request #2 from dominig/master |\ | * a35e146 4a hal for Intel UpSquare via HDMI socket |/ * 226f16b bluetooth: set audio rate to 44100 Bug-AGL: SPEC-1751 Change-Id: I31d8e9845b50bf59f514eb10f54ee950a0d42e9a Signed-off-by: Jonathan Aillet <jonathan.aillet@iot.bzh>
2018-09-284A: delay service startup as a workaround to SPEC-1762/SPEC-1763 (temp ↵Stephane Desneux2-0/+97
workaround) This patch introduces a wait loop before starting the 4A binder: * wait for bluetooth module to be loaded * wait for bluetooth controller to be up & running * wait for bluetooth manager to be initialized Then 4A can start with BT-audio support. If no BT controller is detected in 5secondes, the loop exits and 4A doesn't initialize BT-Audio Bug-AGL: SPEC-1762, SPEC-1763 Change-Id: Ibe851dee871d183511c7bca03411b35ed023f422 Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2018-09-264a: Update 4a-hal-generic for bluetoothJonathan Aillet1-1/+1
This commit bump '4a-hal-generic' to have bluetooth enable by default. * 49a750a hl-bt: Check that hal is available in init * 7e5def8 hal-bt: Use plugin name definition in prints * 94b3f13 Move hal sections callbacks after plugin callback * b3bcfa3 Update version of app-controller submodule. * bd3eacc hal-bt: Enrich 'halmixer' section in plugin init * afbfe30 Remove unnecessary sections in hal json * 805d820 Update version of app-controller submodule. * be77f4a hal-bt: Use plugin name in onload/init prints * 69dcbdc hal-bt: Check presence of a bluetooth receiver * 5286e67 hal-bt: Move bluetooth api require into init * 0b3aa49 Move mixer attach into its controller section * 1e97df9 Remove unnecessary 'function' string in prints * 69b46ba Update version of app-controller submodule. * 09886e3 Added radio stream to all the HALs * 2bb89c9 kingfisher: merged the radio HAL into the main HAL * 22836af Add ctl actions needed by Hal-Bt in plugin init * 2a74ac8 Update version of app-controller submodule. Bug-AGL: SPEC-1679 Change-Id: I50ad36b3a04014b415d18828267b98ee8b9be246 Signed-off-by: Jonathan Aillet <jonathan.aillet@iot.bzh>
2018-09-134a: Add Bluetooth in 4aguppy_6.90.0guppy/6.90.06.90.0Jonathan Aillet2-2/+2
This commit bump '4a-hal-generic' and '4a-softmixer' to support bluetooth in 4a. 4a-hal-generic: * 9663aa7 Add hal json with bluetooth for reference boards * 4d00451 Handle error send by Bluetooth-Manager * 78a4665 Get bluetooth device interface from path in HalBt * 65cd769 Correct a typo in debug print of Hal-Bt plugin * 63e018e Prevent segfault when receiving request in Hal-Bt * 75bf441 hal-bt-data: ignore devices with no UUIDs * a20f6e4 Free afb call sync json returned object in Hal-Bt * b112013 Improve Hal-Bt print messages * c2c29ef Improve Hal-Bt plugin A2DP bt devices detection * 50ae4e9 HalBt plugin keeps list of connected A2DP devices * 57f4078 Use correct file to include controller * e6472ad Improve Hal-Bt plugin event catcher behaviour * 4ce9b2a Prevent Hal-Bt plugin from crashing 4A * 342913c Correct an error in Hal-Bt when calling 'mixer' * 509f6b1 hal-4a-rcar-m3-bt.json: removed the plugin search path * 43820da hal-bt! display error messages of sync calls * 43577d8 Update version of conf.d/app-templates submodule. * 05238f6 Update version of afb-helpers submodule. * 916b0f5 Implement link with softmixer in hal-bt plugin * fae4cf3 Get hal data in hal-bt plugin * 6ea2ba2 Test afb require result at hal-bt plugin load * 8f3ead9 Add handling of hci and profile in hal-bt plugin * 5fceccb Fix little mistakes/typo in hal bluetooth plugin * 3524254 Force hals init before ending hal-manager init * 5446354 Decrease level of a msg printed in event catcher 4a-softmixer: * b678f39 config.cmake: bump the needed version of alsalib to 1.1.6 Bug-AGL: SPEC-1679 Change-Id: I8eb5efb404c531339ba5668a1bf131368a233b8f Signed-off-by: Jonathan Aillet <jonathan.aillet@iot.bzh>
2018-09-11bump 4a-softmixer to the latest versionThierry Bultel1-1/+1
This brings this commit: 13fd8b9 bluez-alsa: fixed the null device logic Change-Id: I921b7e14611c5d81f6caede36b00aed0633aa5ce Signed-off-by: Thierry Bultel <thierry.bultel@iot.bzh>
2018-09-11bluez-alsa: added patch for null deviceThierry Bultel2-0/+47
This closes the transport connection when a null device is specified. Change-Id: I6d69c68a2ca91bd9fb3d7fdf51f470f243e76d5f Signed-off-by: Thierry Bultel <thierry.bultel@iot.bzh>
2018-09-09Merge "Change libhomescreen-2017 to libhomescreen"flounder_5.99.6flounder/5.99.65.99.6Jan-Simon Moeller5-6/+5
2018-09-07[4A] Bump 4a-hal-generic and 4a-softmixer (inc. MinnowMax fix)Stephane Desneux2-2/+2
Alsa devices mapping on Minnowboard Max has changed since the initial HAL definition and multiple subdevices are now seen on HDMI card. These changes must be reflected in 4a-softmixer and HAL definition. Other fixes for upcoming BT support are also included. New revision for 4a-softmixer includes: * 9c0aa9f fixed crash upon misconfiguration of capture/playback devices * 168e928 dmix: used device when in name of slave * 80deafb Added bluez sound playback support New revision for 4a-hal-generic includes: * 9276521 minnow board: fixed the pcm device in json config * be379b3 Use latest version of app-controller submodule. * f5113a0 Add bluetooth hal plugin * 33bc780 Remove unnecessary 'struct' before json_object * 9ab8302 Correct an error when unpacking alsacore response * 1ef27b6 Correct errors in hal-utilities-data prototypes Bug-AGL: SPEC-1692, SPEC-1679 Change-Id: Ie99d6cd7dd13fd27b095e2de7c7160dc92890c98 Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2018-09-07Change libhomescreen-2017 to libhomescreenzheng_wenlong5-6/+5
Change libhomescreen-2017 to libhomescreen. Change-Id: Ia436650481637fc4b64329b2bc8ec296ac37c9d0 Signed-off-by: zheng_wenlong <wenlong_zheng@nexty-ele.com>
2018-09-04Use libqthomescreen repository instead of qlibhomescreenzheng_wenlong1-2/+2
Use libqthomescreen repository instead of qlibhomescreen. Change-Id: I855bac43806b0a1277532c6b94e3cfd419b366fd Signed-off-by: zheng_wenlong <wenlong_zheng@nexty-ele.com>
2018-09-04Use agl-service-homescreen without -2017zheng_wenlong3-43/+1
Change hmi-framwork packagegroup using agl-service-homescreen without -2017. [Patch Set 2] Delete agl-service-homescreen-2017 recipe. [Patch Set 3] Delete homescreen-2017 recipe. Change-Id: I67306083af86c471db45d406824478cdc61f1b10 BUG-AGL: SPEC-1550 Signed-off-by: zheng_wenlong <wenlong_zheng@nexty-ele.com>
2018-08-31Merge "Update agl-service-windowmanager-2017"flounder_5.99.5flounder/5.99.55.99.5Jan-Simon Moeller1-1/+1
2018-08-31Merge "set LIBASOUND_THREAD_SAFE=0 for 4a"Jan-Simon Moeller1-0/+1
2018-08-31[4A/bluez-alsa]: use temporary solution pcm alsa-proxyStephane Desneux2-0/+1021
This plugin always keeps the opened PCM in a consistent state for the sound application, despite of bluez-alsa server or device disconnection. Bug: SPEC-1679 Change-Id: I0caaa6abe6fb9133b4d43479d452e542a04620c3 Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh> Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2018-08-31set LIBASOUND_THREAD_SAFE=0 for 4aThierry Bultel1-0/+1
Since the integration of bluez-alsa support in softmixer, and as warned by the readme of bluez-alsa, there are potential (and effective !) deadlocks in libasound. These deadlocks come especially when uing ioplug PCMs. This hack disables the calls to snd_pcm_lock/unlock in libasound. Notice that the design that consists in using such PCM plugs for communicating with the bluealsa daemon is just a short term solution. When the direct support of bluezalsa communication is integrated in the softmixer, that hack should be removed. Change-Id: Ib6376fd2e145b3240ab1a68b9c760ff9e4c063c4 Signed-off-by: Thierry Bultel <thierry.bultel@iot.bzh>
2018-08-31Update libwindowmanagerKazumasa Mitsunari1-1/+1
This commit includes f427515 Introduce simple API Change-Id: I5c1159748f1568a9113f3b6c61f5c58759c9752d Signed-off-by: Kazumasa Mitsunari <knimitz@witz-inc.co.jp>
2018-08-31Update agl-service-windowmanager-2017Kazumasa Mitsunari1-1/+1
This commit includes e65b048 Fix Window Manager crush when application terminated Bug-AGL: SPEC-1696 Change-Id: I76eeadcb3eb5fde2dc6beb54155f87b1637be36a Signed-off-by: Kazumasa Mitsunari <knimitz@witz-inc.co.jp>
2018-08-29Merge changes Ie6c96000,I2b966142Jan-Simon Moeller1-4/+4
* changes: pulseaudio-module-4a: fix install files path to use the libdir variable pulseaudio-module-4a: Update repository URL and revision
2018-08-284a-mixer: Fix tap_shortcut case issue.José Bollo1-1/+1
Bug-AGL: SPEC-1653 Change-Id: I56de64336f30fa70a3c20650e61b16f31135bfe6 Signed-off-by: José Bollo <jose.bollo@iot.bzh>
2018-08-28pulseaudio-module-4a: fix install files path to use the libdir variableGeorge Kiagiadakis1-1/+1
Change-Id: Ie6c96000db81c0d439b326d55dc6eb250f91f679 Signed-off-by: George Kiagiadakis <george.kiagiadakis@collabora.com>