summaryrefslogtreecommitdiffstats
path: root/meta-audio-4a-framework/recipes-multimedia
AgeCommit message (Collapse)AuthorFilesLines
2018-12-25move 4a-hal-unicens (plugin) to gerritTobias Jahnke1-4/+4
Bug-AGL: SPEC-1505 - update repo and srcrev for flounder Change-Id: I437694d7b38dd44c2a58a9bdb095dce7cb094d2e Signed-off-by: Tobias Jahnke <tobias.jahnke@microchip.com>
2018-12-184a-softmixer: updateScott Murray1-1/+1
Update SRCREV to pick up: 02d919e Reduce output buffering to 500 milliseconds Change-Id: I9750bbbe12f9fb5d3a61c8527c2c2f220a2b7c33 Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2018-12-11Move 4a-hal-generic to gerritflounder_6.0.3flounder/6.0.36.0.3Jan-Simon Möller1-2/+2
The repo is moved already but the recipe was lacking the updated SRC_URI. Corrected. Change-Id: I3d030c84a082d5654a619474e0f2ed88b63bef28 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-12-10Move hal configuration files into own repositoryJan-Simon Möller10-33/+182
... and own recipe This allows to manage the various types of configuration files independently of the source code as these might not always fit into the git repo context-wise. Initial recipe is 4a-hal-device-config.bb . This is re-using the same mechanism as previously used. Samples for alternative implementations and vendor hals are included as well to explore improved ways of handling the multipe configuration files possible. Bug-AGL: SPEC-2011 Change-Id: Ib04b5c4e7b764bed85dbceb50a62a8c6fd031c5a Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org> (cherry picked from commit fd78578b11990bc885651c52690dbcf9169bd7ac)
2018-11-30Change 4a-softmixer SRC_URI to gerritJan-Simon Möller1-1/+1
Change the softmixer SRC_URI to gerrit. Change-Id: I2d7fcd409a47733ecf9554642b0b4cb5c7c934db Bug-AGL: SPEC-1731 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-11-294a: adjust 4a_wait_bt.sh due to changes in bluetooth-manager APIStéphane Desneux1-2/+2
The verb 'power' is now replaced by 'adapter_state'. The response object is also different (no compatibility with older API). Bug-AGL: SPEC-1630 Change-Id: I2e08c33e2936d93cfdec0c498570c77177a4b81e Signed-off-by: Stéphane Desneux <stephane.desneux@iot.bzh>
2018-11-284a-hal-unicens: add HAL for unicensTobias Jahnke1-6/+17
Bug-AGL: SPEC-1505 - enabled 4a-hal-unicens recipe again - updated srcrev of github repo - modified project name to match install folder Change-Id: If7c9021b85e8ea0ef08773be66ea0f031e355ff3 Signed-off-by: Tobias Jahnke <tobias.jahnke@microchip.com>
2018-11-13Bump 4a-softmixer to latest version (bug fixes)Thierry Bultel1-1/+1
This brings these commits: 6504df Lower the verbosity when not in debug level 5e48bc Tweaking debug prints 6ee71f Handle too small card PCM buffer when writing 109036 Fix the error string of attach actions 7ba2e9 remove dead code and renamed unobvious variables Change-Id: I01c6f8a37d9070ced5bb983b8107bcf12efa3466 Signed-off-by: Thierry Bultel <thierry.bultel@iot.bzh>
2018-11-13meta-audio-4a: remove UNICENS legacy halTobias Jahnke1-1/+1
Bug-AGL: SPEC-1505 - Remove UNICENS legacy hal from build until the new hal plugin is available - Remove ldpath which was required to load the legacy hal (avoids binder startup error since the path is no longer available) Change-Id: If25094d4f944e887fed0ed10c5cae8049ce6db82 Signed-off-by: Tobias Jahnke <tobias.jahnke@microchip.com> (cherry picked from commit d531eb3872684bb873d157a09f0048d4fbc70e0d)
2018-11-06bumps 4a-softmixer to the latest versionflounder_6.0.2flounder/6.0.26.0.2Thierry Bultel1-1/+1
This brings these commits: 6bf855 alsa-core-pcm: fixed the mute logic a07c4c removed the dependency to alsalib-1.1.6 for host a84a93 Remove an unfilled response json object b678f3 config.cmake: bump the needed version of alsalib to 1.1.6 Change-Id: Ib2bad263a2c3d827b652cd6819f0986a2742fc63 Signed-off-by: Thierry Bultel <thierry.bultel@iot.bzh>
2018-10-13Bump 4a-hal-unicens to latest revisionJan-Simon Möller1-1/+1
Include the update from Tobias Change-Id: I9b5832cf9af29fef85623599eb6d300cafe74897 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-10-024a: Update 4a-hal-generic for UpSquared boardflounder_6.0.1flounder/6.0.16.0.1Jonathan Aillet1-2/+2
This commit bump '4a-hal-generic' to have Intel UpSquared hal available in ./4a-hal-generic/etc.available/. An update of the recipe is also made to automatically deploy Intel UpSquared hal in ./4a-hal-generic/etc/. when compiling AGL for 'intel-corei7-64' platform. * a94119d Correct typo in Intel UpSquared hal * 2b64aed Update clone commands in README.md * 4a2672a Update 'halmap' section of Intel UpSquare hal * 424263f Merge pull request #2 from dominig/master |\ | * a35e146 4a hal for Intel UpSquare via HDMI socket |/ * 226f16b bluetooth: set audio rate to 44100 Bug-AGL: SPEC-1751 Change-Id: I31d8e9845b50bf59f514eb10f54ee950a0d42e9a Signed-off-by: Jonathan Aillet <jonathan.aillet@iot.bzh>
2018-09-284A: delay service startup as a workaround to SPEC-1762/SPEC-1763 (temp ↵flounder_6.0.0flounder/6.0.06.0.0Stephane Desneux2-0/+97
workaround) This patch introduces a wait loop before starting the 4A binder: * wait for bluetooth module to be loaded * wait for bluetooth controller to be up & running * wait for bluetooth manager to be initialized Then 4A can start with BT-audio support. If no BT controller is detected in 5secondes, the loop exits and 4A doesn't initialize BT-Audio Bug-AGL: SPEC-1762, SPEC-1763 Change-Id: Ibe851dee871d183511c7bca03411b35ed023f422 Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2018-09-264a: Update 4a-hal-generic for bluetoothJonathan Aillet1-1/+1
This commit bump '4a-hal-generic' to have bluetooth enable by default. * 49a750a hl-bt: Check that hal is available in init * 7e5def8 hal-bt: Use plugin name definition in prints * 94b3f13 Move hal sections callbacks after plugin callback * b3bcfa3 Update version of app-controller submodule. * bd3eacc hal-bt: Enrich 'halmixer' section in plugin init * afbfe30 Remove unnecessary sections in hal json * 805d820 Update version of app-controller submodule. * be77f4a hal-bt: Use plugin name in onload/init prints * 69dcbdc hal-bt: Check presence of a bluetooth receiver * 5286e67 hal-bt: Move bluetooth api require into init * 0b3aa49 Move mixer attach into its controller section * 1e97df9 Remove unnecessary 'function' string in prints * 69b46ba Update version of app-controller submodule. * 09886e3 Added radio stream to all the HALs * 2bb89c9 kingfisher: merged the radio HAL into the main HAL * 22836af Add ctl actions needed by Hal-Bt in plugin init * 2a74ac8 Update version of app-controller submodule. Bug-AGL: SPEC-1679 Change-Id: I50ad36b3a04014b415d18828267b98ee8b9be246 Signed-off-by: Jonathan Aillet <jonathan.aillet@iot.bzh>
2018-09-134a: Add Bluetooth in 4aflounder_5.99.7flounder/5.99.75.99.7Stephane Desneux2-2/+2
This commit bump '4a-hal-generic' and '4a-softmixer' to support bluetooth in 4a. 4a-hal-generic: * 9663aa7 Add hal json with bluetooth for reference boards * 4d00451 Handle error send by Bluetooth-Manager * 78a4665 Get bluetooth device interface from path in HalBt * 65cd769 Correct a typo in debug print of Hal-Bt plugin * 63e018e Prevent segfault when receiving request in Hal-Bt * 75bf441 hal-bt-data: ignore devices with no UUIDs * a20f6e4 Free afb call sync json returned object in Hal-Bt * b112013 Improve Hal-Bt print messages * c2c29ef Improve Hal-Bt plugin A2DP bt devices detection * 50ae4e9 HalBt plugin keeps list of connected A2DP devices * 57f4078 Use correct file to include controller * e6472ad Improve Hal-Bt plugin event catcher behaviour * 4ce9b2a Prevent Hal-Bt plugin from crashing 4A * 342913c Correct an error in Hal-Bt when calling 'mixer' * 509f6b1 hal-4a-rcar-m3-bt.json: removed the plugin search path * 43820da hal-bt! display error messages of sync calls * 43577d8 Update version of conf.d/app-templates submodule. * 05238f6 Update version of afb-helpers submodule. * 916b0f5 Implement link with softmixer in hal-bt plugin * fae4cf3 Get hal data in hal-bt plugin * 6ea2ba2 Test afb require result at hal-bt plugin load * 8f3ead9 Add handling of hci and profile in hal-bt plugin * 5fceccb Fix little mistakes/typo in hal bluetooth plugin * 3524254 Force hals init before ending hal-manager init * 5446354 Decrease level of a msg printed in event catcher 4a-softmixer: * b678f39 config.cmake: bump the needed version of alsalib to 1.1.6 Bug-AGL: SPEC-1679 Signed-off-by: Jonathan Aillet <jonathan.aillet@iot.bzh> Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh> Change-Id: I1ceceb3b01a59156d2d015b15aa49bfe1f077ad0 (cherry picked from commit I8eb5efb404c531339ba5668a1bf131368a233b8f)
2018-09-13bump 4a-softmixer to the latest versionThierry Bultel1-1/+1
This brings this commit: 13fd8b9 bluez-alsa: fixed the null device logic Change-Id: I921b7e14611c5d81f6caede36b00aed0633aa5ce Signed-off-by: Thierry Bultel <thierry.bultel@iot.bzh> (cherry picked from commit 1f00e569d39a62c99ba7f12b438e0e0162549865)
2018-09-07[4A] Bump 4a-hal-generic and 4a-softmixer (inc. MinnowMax fix)Stephane Desneux2-2/+2
Alsa devices mapping on Minnowboard Max has changed since the initial HAL definition and multiple subdevices are now seen on HDMI card. These changes must be reflected in 4a-softmixer and HAL definition. Other fixes for upcoming BT support are also included. New revision for 4a-softmixer includes: * 9c0aa9f fixed crash upon misconfiguration of capture/playback devices * 168e928 dmix: used device when in name of slave * 80deafb Added bluez sound playback support New revision for 4a-hal-generic includes: * 9276521 minnow board: fixed the pcm device in json config * be379b3 Use latest version of app-controller submodule. * f5113a0 Add bluetooth hal plugin * 33bc780 Remove unnecessary 'struct' before json_object * 9ab8302 Correct an error when unpacking alsacore response * 1ef27b6 Correct errors in hal-utilities-data prototypes Bug-AGL: SPEC-1692, SPEC-1679 Change-Id: Ie99d6cd7dd13fd27b095e2de7c7160dc92890c98 Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2018-08-31set LIBASOUND_THREAD_SAFE=0 for 4aThierry Bultel1-0/+1
Since the integration of bluez-alsa support in softmixer, and as warned by the readme of bluez-alsa, there are potential (and effective !) deadlocks in libasound. These deadlocks come especially when uing ioplug PCMs. This hack disables the calls to snd_pcm_lock/unlock in libasound. Notice that the design that consists in using such PCM plugs for communicating with the bluealsa daemon is just a short term solution. When the direct support of bluezalsa communication is integrated in the softmixer, that hack should be removed. Change-Id: Ib6376fd2e145b3240ab1a68b9c760ff9e4c063c4 Signed-off-by: Thierry Bultel <thierry.bultel@iot.bzh>
2018-08-28pulseaudio-module-4a: fix install files path to use the libdir variableGeorge Kiagiadakis1-1/+1
Change-Id: Ie6c96000db81c0d439b326d55dc6eb250f91f679 Signed-off-by: George Kiagiadakis <george.kiagiadakis@collabora.com>
2018-08-28pulseaudio-module-4a: Update repository URL and revisionGeorge Kiagiadakis1-3/+3
Change-Id: I2b9661423bcce6da82566e8e44dfd06208f5d381 Signed-off-by: George Kiagiadakis <george.kiagiadakis@collabora.com>
2018-08-03Merge "4a-softmixer: bump revision (submodules update, less verbosity)"Jan-Simon Moeller1-1/+1
2018-08-014a-softmixer: bump revision (submodules update, less verbosity)Stephane Desneux1-1/+1
This includes: * ded8e37 Bump revisions for all submodules * a226d89 Reduce verbosity of message "readThreadEntry..." The latest commit ded8e37 on 4a-softmixer might help to solve SPEC-1639. Bug-AGL: SPEC-1639 Change-Id: I07d5e227a108565d7a8732289bef64cb611d3f1f Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2018-08-01meta-audio-4a-framework: pulseaudio: fix the default.pa fileGeorge Kiagiadakis1-22/+66
* load module-4a-client if available * load some other necessary functionality * keep bluetooth support out for the moment (will not work with 4a) * keep the original copyright and comments as it is a modified version of the file shipped by upstream Change-Id: I2915c161aadc3b1a1e82f81d3bd8a29a6ccc2cfb Signed-off-by: George Kiagiadakis <george.kiagiadakis@collabora.com>
2018-08-01meta-audio-4a-framework: add recipe for pulseaudio-module-4a-clientGeorge Kiagiadakis1-0/+20
Change-Id: I40be2fb1f572c5275057e970782437bdf47e1887 Signed-off-by: George Kiagiadakis <george.kiagiadakis@collabora.com>
2018-07-24Merge "4a-hal-generic: bump revision (inc. first rev for RPI3 HAL)"Jan-Simon Moeller1-1/+5
2018-07-24Merge "Add python3-websockets for devel feature"Jan-Simon Moeller1-1/+1
2018-07-24Merge "4A: disable pulseaudio alsa plugin"Jan-Simon Moeller1-2/+2
2018-07-24Merge "4a-softmixer: bump to latest version"Jan-Simon Moeller1-2/+2
2018-07-24Merge "Cleanup deprecated 4A configuration files"Jan-Simon Moeller3-657/+1
2018-07-24Merge "meta-audio-4a-framework: add recipe for 4a-tools"Jan-Simon Moeller1-0/+22
2018-07-244a-softmixer: bump to latest versionStephane Desneux1-2/+2
This takes these latest commits: * 320d8f9 Updated the readme.md * 1db3552 rework the sound capture & playback model * 712b3a2 added ringbuffer and time utils Change-Id: Ia2aaecd4761a37e1600394ff72dba5b81ffe37a4 Signed-off-by: Thierry Bultel <thierry.bultel@iot.bzh> Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2018-07-24Cleanup deprecated 4A configuration filesRonan Le Martret3-657/+1
* This was the alsa configuration files for 4A. Now the pcm are dynamic. 4A-FF.RC2 Change-Id: Ia72752d9721daa917d46e5a9cfe802c93c15c52f Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
2018-07-244a-hal-generic: bump revision (inc. first rev for RPI3 HAL)Stephane Desneux1-1/+5
This patch introduces the following changes on 4a-hal-generic: * e949092 hal-4a-raspberry-pi-3: add a WARNING related to RPI3 sound driver bug * 01d3370 Correct 'volume' control in Minnowboard hal * 7fea639 Add Raspberry Pi 3 HAL * 2ce8a00 Correct error print when attaching to mixer * c05faaf Update version of conf.d/app-templates submodule. * 744af17 Update version of app-controller submodule. * 39fda4b Update version of afb-helpers submodule. * 492caab Remove trailing white spaces in radio config file * 2ef5026 Added a radio to 2 channels playback .json example Note that due to a bug in RPI3 sound card driver, no sound is produced on RPI3 with internal card. 4A works on other devices (USB for example). Bug-AGL: SPEC-1610 Change-Id: I14c581269945306e205808b53f9d5c7f60f8af88 Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2018-07-24Add python3-websockets for devel featureRonan Le Martret1-1/+1
* Backport python3-websockets from meta-openembedded Change-Id: Ifa9d081df5adbbf4021f3da49b48f5b7c97b9fc5 Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
2018-07-24meta-audio-4a-framework: add recipe for 4a-toolsStephane Desneux1-0/+22
4a-tools contains tools, scripts and data to test the 4A stack Change-Id: Ie445cd00fcb11ad079f325995f9f46c2d19e7700 Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh> Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
2018-07-244a: pin all revisions for repos in src/Stephane Desneux4-4/+2
The rule is to have apps/* repositories to use AGL_APP_REVISION (tested in CI as apps builds in SDK) and to have src/* use pinned revisions (tested in CI as image builds). This commit fixes the recipes in 4a layer that were not following the rule. Bug-AGL: SPEC-1600 Change-Id: I81dd77a653a23adf45bdb0c6d969a3ad9ab849a9 Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2018-07-234A: disable pulseaudio alsa pluginRonan Le Martret1-2/+2
This fix should be revert, if pulseaudio is remove from DISTRO_FEATURES (as a option) Bug-AGL: SPEC-1234 Change-Id: I68ce35a620a107d09a0fbe85cf05fe2abfb7902e Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
2018-07-17bump 4a-softmixer to the latest versionThierry Bultel1-1/+1
Here are the changes: afc7d62 alsa-core-pcm: sets sw start & stop thresholds 283bf0a stops the read/write loop when the stream is muted Change-Id: I50cd5d8d798fec9ef303861df5eccb49094544f6 Signed-off-by: Thierry Bultel <thierry.bultel@iot.bzh>
2018-07-13Fix 4a-mixer parsing error on nogfx build variantJan-Simon Möller1-25/+0
The nogfx build variant fails with 4a enabled ( https://gerrit.automotivelinux.org/gerrit/#/c/15051/ ) This is documented in SPEC-1588. To fix this we apply a conditional inclusion in meta-audio-4a-framework to only pull-in the mixer if we are including meta-agl-demo. Can be more fine-grained (profile-graphical-qt5 maybe) later. Bug-AGL: SPEC-1588 Fast inclusion requested as it is a blocker for RC2 due to enabling 4a in CI. Change-Id: I59b82748ba8e1736358318373d29f8f9fed2a5c5 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-07-11Fix bash on install script typoRonan Le Martret1-12/+12
Change-Id: I12e5367a62d2acba3596ea066cd67363c6fc8626 Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
2018-07-11Merge "4a-softmixer: bump to latest revision (APIv3)"Stéphane Desneux1-1/+1
2018-07-104a-hal-generic: bump to latest master versionJonathan Aillet1-1/+1
(08b6e71 - Jonathan Aillet) Update binding entry for app-fw v3. (a7eeeb6 - Jonathan Aillet) Set binding api version directly in top cmake (18f6ad3 - Jonathan Aillet) Update version of app-controller submodule. (d4aa279 - Jonathan Aillet) Add hal for intel qemu audio configuration (28b6e03 - Jonathan Aillet) Simplify ping verb call print output (47fb191 - Jonathan Aillet) adjust CONTROL_CONFIG_PATH to point to .../etc (143ed9c - Jonathan Aillet) Update version of conf.d/app-templates submodule. (3a48206 - Jonathan Aillet) Don't handle hal enabling (c1d823e - Jonathan Aillet) Update version of conf.d/app-templates submodule. (940a67c - Jonathan Aillet) Update version of app-controller submodule. (f2a6c47 - Jonathan Aillet) Update version of afb-helpers submodule. Bug-AGL: SPEC-1405 Change-Id: Ic8e00eeca3028f1b2b623499a66f39deedfcc684 Signed-off-by: Jonathan Aillet <jonathan.aillet@iot.bzh>
2018-07-104a-hal-generic: MACHINE-specific HAL config filesJonathan Aillet1-0/+28
This patch adds a postinstall step to 4a-hal-generic recipe to define HALs to be enabled/disabled depending on $MACHINE As a consequence, 4a-hal-generic package is now machine specific. Bug-AGL: SPEC-1405 Change-Id: Ibf418d71e898c3f9a2640b2ad4c8f4907bc5cb90 Signed-off-by: Jonathan Aillet <jonathan.aillet@iot.bzh>
2018-07-104a-softmixer: bump to latest revision (APIv3)Stephane Desneux1-1/+1
This includes changes that allow the build of softmixer using APIv3 and latest submodules. Bug-AGL: SPEC-1405 Change-Id: I627958ee5dfc8f2254d0df833418e64e4a14ab96 Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2018-06-29Merge "alsa: add http mirror in the backported alsa recipes"Jan-Simon Moeller4-0/+16
2018-06-29alsa: add http mirror in the backported alsa recipesGeorge Kiagiadakis4-0/+16
Unfortunately ftp doesn't work for me (looks like a firewall issue) and the default poky mirror at http://downloads.yoctoproject.org/mirror/sources/ doesn't contain alsa 1.1.6, so the build fails. I think this will be useful to other people with firewall issues. Change-Id: Ic6744f38ac8c007ed99b69fb410526b6c4ca8733 Signed-off-by: George Kiagiadakis <george.kiagiadakis@collabora.com>
2018-06-29meta-audio-4a-framework: bump 4a-softmixer and 4a-hal-generic to latest revsStephane Desneux2-2/+2
This fixes the build issues with latest version of appfw binder: * 4a-hal-generic: (90cae7b) Update version of app-controller submodule. * 4a-softmixer: (1065a98) Update version of app-controller-submodule submodule. Bug-AGL: SPEC-1405 Change-Id: I476ad4aaed1f0670a558a26eb6a4b589d7840e9d Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2018-06-29meta-audio-4a-framework: backport alsa 1.1.6 from poky/masterStephane Desneux7-0/+445
Backport alsa 1.1.6 from poky/master (commit c7c64baa411fd96886918c235b851ae3e5a6a61f) because softmixer requires latest alsa-lib version. Bug-AGL: SPEC-1545 Change-Id: I210daad821a136d2fe05636f6387f2d4c68c76e1 Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2018-06-28meta-audio-4a-framework: align on eel with latest components revisionsStephane Desneux7-68/+39
This bump is based on recipes coming for eel branch (revision e029270): In 4A layer, we now have: * 4a-softmixer: SRCREV = "731c21e80ba45339b7dd9b8eae63accd3597d281" * 4a-hal-unicens: SRCREV = "${AGL_APP_REVISION}" * agl-service-audio-4a: SRCREV = "${AGL_APP_REVISION}" * 4a-hal-generic: SRCREV = "8142c7ed42167dff7e526952f91909d679453251" * 4a-mixer: SRCREV = "${AGL_APP_REVISION}" * 4a-alsa-core: SRCREV = "${AGL_APP_REVISION}" Change-Id: Ib5708e9551f0646e0206deac8795f3b09f5a0569 Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2018-06-06First recipes for 4a-hal-generic and 4a-softmixerJan-Simon Möller2-0/+48
During the F2F we're working on the integration of these two as a preview and getting it into ppl's hands. Change-Id: I5392664e1736b4505bf72cf3424e8372aa4a10b7 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>