diff options
author | Scott Murray <scott.murray@konsulko.com> | 2023-12-17 15:35:19 -0500 |
---|---|---|
committer | Scott Murray <scott.murray@konsulko.com> | 2023-12-17 15:46:14 -0500 |
commit | 0ff3ef1b254364639fc42495bbcfb4760250990a (patch) | |
tree | 7a54eb69afa4bf11c54f3491ee1f69e2e1650873 /.gitreview | |
parent | 5567e12699dcc6584a620d2682430e3882dc0907 (diff) |
Add balance/fade/treble/bass supportricefish_18.0.0ricefish/18.0.0quillback_17.1.2quillback_17.1.1quillback_17.1.0quillback_17.0.2quillback_17.0.1quillback_17.0.0quillback/17.1.2quillback/17.1.1quillback/17.1.0quillback/17.0.2quillback/17.0.1quillback/17.0.0devtool-patcheddevtool-base18.0.017.1.217.1.117.1.017.0.217.0.117.0.0
Changes:
- Add support for new VSS signals for balance/fade/treble/bass.
Treble and bass drive the recently added equalizer controls,
while balance and fade currently do simple linear scaling down
of the non-emphasized direction.
- Add support for VSS 4.0 separate navigation volume and mute
signals.
- Significant refactoring of the audiomixer API calling code in
the AudioMixerService class to avoid code duplication.
- All pushes of the updated VSS values for volume and mute
signals now are driven from the mixer API callback so that
internal and external mixer changes are handled with less
code duplication. For now, gain changes have been kept as
explicit VSS updates on set, this may change if handling
external changes seems more worthwhile. As well, initial
master volume setting is a bit of a special case, see below.
- Setting the initial volume has been tweaked a bit to ensure
that the value gets pushed out via VSS. There currently seems
to be an issue with the master playback sink mixer not taking
changes until playback starts, so while the current code
ensures that VSS subscribers see the value the daemon has set,
it is likely that does not correspond to what's in WirePlumber
until playback of some form happens and another volume change
is made. This will be addressed with upstream.
- Change flags in the mixer API have been updated to indicate
overall and per-channel volume changes as separate flags.
Bug-AGL: SPEC-5001
Change-Id: I66585f573978989a0c281f060a667b4495e4bc0f
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Diffstat (limited to '.gitreview')
0 files changed, 0 insertions, 0 deletions