aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2023-07-31Add gitreview file for Prickly Pike branchpikeJan-Simon Moeller1-1/+1
Update the .gitreview file. Bug-AGL: SPEC-4867 Signed-off-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org> Change-Id: Id966256043448a4a3812b61b23e0df33e8f945b9
2021-02-24Fix potential memory leakneedlefish_13.93.0needlefish/13.93.0marlin_12.93.0marlin_12.92.0marlin_12.91.0marlin_12.90.1marlin_12.90.0marlin/12.93.0marlin/12.92.0marlin/12.91.0marlin/12.90.1marlin/12.90.0lamprey_11.92.0lamprey_11.91.0lamprey/11.92.0lamprey/11.91.013.93.012.93.012.92.012.91.012.90.112.90.011.92.011.91.0Li Xiaoming2-2/+4
json structure allocating code should be placed in where it is used, if there is a condition check which may cause a return before the before-mentioned place in the function. Bug-AGL: SPEC-3584 Change-Id: I9b5228c62a7e3bef055d7bdb0950d2bd4e058265 Signed-off-by: Li Xiaoming <lixm.fnst@cn.fujitsu.com>
2020-07-21fix(bluetooth-map.lua): add message and list_messages testkoi_10.93.0koi_10.92.0koi_10.91.0koi/10.93.0koi/10.92.0koi/10.91.0jellyfish_9.99.4jellyfish_9.99.3jellyfish_9.99.2jellyfish/9.99.4jellyfish/9.99.3jellyfish/9.99.29.99.49.99.39.99.210.93.010.92.010.91.0Li, Xiaoming1-0/+6
Complete the misssing verb test. About the msg string in message verb: In order to get a real msg, we need to add extra lua code to read the response of list_messages verb first. In this phase, I will use a random string for it, and later add condition code to optimise them. Bug-AGL: SPEC-3458 Change-Id: Ieb0e8622ecf1e5d8d0c0daa5d6ba522b7e1016ef Signed-off-by: Li, Xiaoming <lixm.fnst@cn.fujitsu.com>
2020-06-09Update autobuild scriptsjellyfish_9.99.1jellyfish/9.99.19.99.1Scott Murray2-204/+154
Update autobuild scripts with reworked version that fixes building outside of the source tree. Bug-AGL: SPEC-2049, SPEC-3300 Signed-off-by: Scott Murray <scott.murray@konsulko.com> Change-Id: Ia1904804a1369992b2d31e2f66a652f1767a9ac4
2020-03-19bluetooth-map: prevent double message eventsMatt Ranostay2-0/+14
Some messaging applications create notifications when opened even if already been sent out. So we keep a hash map of already sent notifications. This likely needs a better solution in the future. Bug-AGL: SPEC-3267 Change-Id: I1daba04f99819bd7f83bff428131cced0d6d97e6 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2020-02-18Update autobuild script to create new targetsFrederic Marec2-26/+174
Update autobuild script to create multiple widget target debug, coverage and all Bug-AGL: SPEC-2049 Signed-off-by: Frederic Marec <frederic.marec@iot.bzh> Change-Id: If969d33da1feb2390138767369309e25949d5585
2020-02-11Update .gitreview fileJan-Simon Möller1-0/+5
This updates the gitreview file in the project . Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org> Change-Id: I29f4f34fc5ca5b49a387e896f012146b5e14b8f9
2019-10-06docs: update README.md for iOS changesicefish_8.99.5icefish_8.99.4icefish_8.99.3icefish_8.99.2icefish_8.99.1icefish/8.99.5icefish/8.99.4icefish/8.99.3icefish/8.99.2icefish/8.99.18.99.58.99.48.99.38.99.28.99.1Matt Ranostay1-5/+0
Confirmed sending a SMS on a iOS device works as one would expect. Removing application note that seems to be outdated. Bug-AGL: SPEC-2566 Change-Id: Iaad2a8061c2d9c2899d857f8d04d1a1f9cf51baa Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-09-12fix(test/CMakeLists.txt): make test wgt workLi Xiaoming1-1/+1
Bug-AGL: SPEC-2795 Change-Id: Ia5c27c20c049115c950710a802892477dfcca690 Signed-off-by: Li Xiaoming <lixm.fnst@cn.fujitsu.com>
2019-09-10refactor(config.xml.in):Replace required api with required bindingLi Xiaoming1-1/+4
Appfw docs: "required-api local": OBSOLETE SINCE FF (AGL6), PROVIDED FOR COMPATIBILITY.Use the feature urn:AGL:widget:required-binding instead. Bug-AGL: SPEC-2781 Change-Id: I71f4afe7b02446f957aff8847879b1605c491f4f Signed-off-by: Li Xiaoming <lixm.fnst@cn.fujitsu.com>
2019-09-09parsing: change AFB_INFO to AFB_DEBUG to reduce logsMatt Ranostay1-1/+1
Messaging length parsing reporting is only really useful in debugging, and shouldn't be logged AFB_INFO. Bug-AGL: SPEC-2422 Change-Id: Ifbfd55aee33de2d1e6a5834af570890c0fa9ed76 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-09-06fix: Remove -Wformat= & -Woverflow warningLi Xiaoming2-4/+4
/work/agl-service-bluetooth-map/binding/bluetooth-map-bmessage.c:206:11: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 7 has type ‘size_t’ {aka ‘unsigned int’} [-Wformat=] AFB_INFO("Parsing incoming bMessage of length %lu", strlen(bmessage)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~ /work/agl-service-bluetooth-map/binding/bluetooth-map-bmessage.c: In function ‘bmessage_encoder’: /work/agl-service-bluetooth-map/binding/bluetooth-map-bmessage.c:293:34: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘size_t’ {aka ‘unsigned int’} [-Wformat=] tmp = g_strdup_printf("LENGTH:%lu", ~~^ %u strlen(BEGINMSG) + msg->len + strlen(ENDMSG)); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [ 33%] Building C object binding/CMakeFiles/bluetooth-map-binding.dir/ bluetooth-map-util.c.o /work/agl-service-bluetooth-map/binding/bluetooth-map-util.c: In function ‘simple_gvariant_to_json’: /work/agl-service-bluetooth-map/binding/bluetooth-map-util.c:170:14: warning: integer overflow in expression ‘-2147483648’ of type ‘long int’ results in ‘-2147483648’ [-Woverflow] if (i64 >= -(1L << 31) && i64 < (1L << 31)) ^ In file included from /xdt/sdk/sysroots/armv7vet2hf-neon-vfpv4-agl-linux -gnueabi/usr/include/afb/afb-binding.h:116, from /work/agl-service-bluetooth-map/binding/bluetooth -map-util.c:36: /work/agl-service-bluetooth-map/binding/bluetooth-map-util.c:291:16: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 7 has type ‘gsize’ {aka ‘unsigned int’} [-Wformat=] AFB_WARNING("Can't handle variants with more than one children (%lu)" ,nitems); Bug-AGL: SPEC-2422 Change-Id: Icebf98f1857ee02abe80f3d2b42099dcd7c702cc Signed-off-by: Li Xiaoming <lixm.fnst@cn.fujitsu.com>
2019-07-30binding: bluetooth-map: unlink files after data transfersMatt Ranostay1-0/+5
Bug-AGL: SPEC-2695 Change-Id: Iba2f3e4ecc033fb7d662b9998366350a880d9825 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-07-30binding: bluetooth-map: move data transfer results to shared directoryMatt Ranostay2-5/+23
Data transfers needs to be stored in /run/user/UID/usrshr to get the User::App-Shared Smack label on creation from obexd Bug-AGL: SPEC-2695 Change-Id: Ia482234fe7356cb0965c1ed7e4065e72543514bd Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-07-29Revert "binding: bluetooth-map: add scope-platform permission to config.xml.in"Matt Ranostay1-1/+0
This reverts commit 954d0719e5238fe59a2e10223ce2e63907f66be7. Bug-AGL: SPEC-2575 SPEC-2695 Change-Id: Id14d7d55e4600e28eb23542b261c5637456bdcab Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-07-09binding: bluetooth-map: add 'downloaded' field to list_messages resultshalibut_7.99.3halibut/7.99.37.99.3Matt Ranostay2-2/+11
Signal that all the message is downloaded which is usually if the subject/message is under 256 characters with a 'downloaded' boolean parameter. This avoids libqtappfw from doing a OBEX transfer per message that under this threshold. Bug-AGL: SPEC-2512 Change-Id: I9f59337b2b4995a0359587c22e2efeee19bdae8e Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-06-27binding: bluetooth-map: notify if map_init() failshalibut_7.99.2halibut/7.99.27.99.2Matt Ranostay1-0/+1
When map_init() fails it should abort the binding from starting. Currently this has only happened when attempting to connect to the D-Bus session. Bug-AGL: SPEC-2512 Change-Id: I4bc3ec37c486c85d3714125bc44462a8acdbc26b Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-06-27binding: bluetooth-map: add scope-platform permission to config.xml.inMatt Ranostay1-0/+1
Add urn:AGL:permission::partner:scope-platform to run on the platform scope. Bug-AGL: SPEC-2575 Change-Id: I7e1bc6549474d04890e02307ec3d063862c4e9f8 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-06-24binding: bluetooth-map: make list_messages response more consistentMatt Ranostay2-19/+24
To be more consistent with other verb responses from other bindings put all the messages in a similiar named parameter. This allows parsing to be easier from consumers, and allows future field additions. Bug-AGL: SPEC-2512 Change-Id: I76131747f950e052de9ba206c0b2bf1274509e33 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-06-24binding: bluetooth-map: strlen check for folder nameMatt Ranostay1-1/+1
Don't populate message listing for list_messsages verb with no folder name. Bug-AGL: SPEC-2512 Change-Id: I881e6f4a59bef9e7f60f2b06cf280e96077ad718 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-06-19binding: bluetooth-map: add message access supportMatt Ranostay7-11/+1312
Add support for retrieving messages, and listing handles of messages located in folders. SPEC-2512 Change-Id: Ia345488b51f5cac1e1c2fd508305d7ffda794251 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-06-19binding: bluetooth-map: add notification check on org.bluez.obex.Message1 ↵Matt Ranostay1-0/+22
interfaces Preventing of broadcasting of sent, and previously received messages over the notification event. This happens because a ListMessage call to the org.bluez.obex.MessageAccess1 interface will cause message interfaces to be created. Bug-AGL: SPEC-2512 Change-Id: I291b36be732c394c116db0d2e82cb8d4c0ce759a Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-06-18Adding agl-service-bluetooth-map testsEdi Feschiyan8-0/+184
Bug-AGL: SPEC-2530 Signed-off-by: Edi Feschiyan <edi.feschiyan@konsulko.com> Change-Id: Ia42ff3922d5d006d88f766fb9e75f1c57dc05d08
2019-06-11binding: bluetooth-map: add parsing functionality to sent messagesMatt Ranostay1-15/+38
Sent messages have a slightly different ordering of tags, and the parser needs to take that into account. Bug-AGL: SPEC-2512 Change-Id: I21e120ab7674831fbaca93bb6fe060ef6661fd26 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-05-13binding: bluetooth-map: change recipient entry to senderhalibut_7.99.1halibut/7.99.17.99.1Matt Ranostay2-4/+4
In notification event it is the sender's vCard that is displayed change the naming to reflect that. Bug-AGL: SPEC-2351 SPEC-2392 Change-Id: Id7c7addee7c72a0b6dcfe1a0f50a6b9843d5797a Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-05-13binding: bluetooth-map: add encoder for bMessage composingMatt Ranostay4-25/+96
Bug-AGL: SPEC-2351 SPEC-2392 Change-Id: I40425ed3dff4aabacfc520e5e3887e93f82a7b5e Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-05-12binding: bluetooth-map: remove training newline from message parsingMatt Ranostay1-0/+3
Bug-AGL: SPEC-2351 SPEC-2392 Change-Id: I17713334bfcf941a9d766acb34cdde7c26fcf701 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-05-12binding: bluetooth-map: add parser for bMessage outputMatt Ranostay5-30/+212
Parser to output more user-readable JSON of incoming messages Bug-AGL: SPEC-2351 SPEC-2392 Change-Id: Ib758f8901ff01579899112c75119596c4a0726be Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-05-08binding: bluetooth-map: fix issue with other service OBEX transfersMatt Ranostay1-0/+7
Don't pick up other services OBEX transfers by checking path of MAP session. This was an issue that a notification event was being sent with the PBAP contact vCards. Bug-AGL: SPEC-2351 Change-Id: I88e34056430760deeeb3815feff5cdca33b20435 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-05-06binding: bluetooth-map: add message composition supportMatt Ranostay5-18/+362
Add message composition suppport for sending SMS/MMS messages in bMessage format. Bug-AGL: SPEC-2351 Change-Id: I5709c6619f44863e949ae61363f7d5fe54adcbfc Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-05-05binding: bluetooth-map: add run-by-default attribute to config.xmlMatt Ranostay1-2/+3
Add urn:AGL:permission::system:run-by-default attribute for running on startup. Bug-AGL: SPEC-2351 Change-Id: Ibe61ed42a483a9c91325d16469bd93e8887e8d2b Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-05-05binding: bluetooth-map: remove disconnect messageMatt Ranostay1-9/+1
Disconnect message currently would be triggered with every bluetooth device disconnection. So remove until it checks the UUID of the respective device. Bug-AGL: SPEC-2351 Change-Id: If2a814c56fe7b98b2fde2664add32d66bb7034db Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-05-05binding: bluetooth-map: change uuid from MNS to MAS_UUIDMatt Ranostay2-2/+2
Not all devices will have Message Notification Service initially when paired, and so check for Message Access Service instead. Bug-AGL: SPEC-2351 Change-Id: Ia5172c53631c6137626135795b97549f467bafe6 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-05-05binding: bluetooth-map: add missing g_variant_unref() in map_request_message()Matt Ranostay1-2/+4
To avoid memory leaks g_variant_unref() needs to be called on bluez_call() replies. Bug-AGL: SPEC-2351 Change-Id: Ia595093ac479b884ca4793a96c97d58e4eca2959 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-05-05binding: bluetooth-map: add initial MAP bindingMatt Ranostay12-0/+1986
This patchset brings initial Bluetooth MAP (Message Access Profile) support. Bug-AGL: SPEC-2351 Change-Id: I76b974978f72869f593526c4f6926bb5c27c48a9 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-04-18Initial empty repositoryJan-Simon Moeller0-0/+0