aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRomain Forlot <romain.forlot@iot.bzh>2017-05-16 12:38:54 +0200
committerRomain Forlot <romain.forlot@iot.bzh>2017-05-19 11:36:43 +0200
commit219b9713c39d36895408e9fb13383d767921e756 (patch)
treebb6380cb4849f1b0650b5ef49a5b6646c5d284cf
parent4f1b1d088afe8eb9a5b75287429104e4175e97e7 (diff)
Implement canceling with BCM socket leads to close it.
Change-Id: Ibcc1419caba7e1b04dbe652a6c60c393f14a8145 Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
-rw-r--r--CAN-binder/low-can-binding/diagnostic/diagnostic-manager.cpp18
1 files changed, 1 insertions, 17 deletions
diff --git a/CAN-binder/low-can-binding/diagnostic/diagnostic-manager.cpp b/CAN-binder/low-can-binding/diagnostic/diagnostic-manager.cpp
index 935767a8..fb62dfb0 100644
--- a/CAN-binder/low-can-binding/diagnostic/diagnostic-manager.cpp
+++ b/CAN-binder/low-can-binding/diagnostic/diagnostic-manager.cpp
@@ -233,23 +233,7 @@ void diagnostic_manager_t::find_and_erase(active_diagnostic_request_t* entry, st
// @brief TODO: implement cancel_request if needed... Don't know.
void diagnostic_manager_t::cancel_request(active_diagnostic_request_t* entry)
{
-
- /* TODO: implement acceptance filters.
- if(entry.arbitration_id_ == OBD2_FUNCTIONAL_BROADCAST_ID) {
- for(uint32_t filter = OBD2_FUNCTIONAL_RESPONSE_START;
- filter < OBD2_FUNCTIONAL_RESPONSE_START +
- OBD2_FUNCTIONAL_RESPONSE_COUNT;
- filter++) {
- removeAcceptanceFilter(entry.bus_, filter,
- CanMessageFormat::STANDARD, getCanBuses(),
- getCanBusCount());
- }
- } else {
- removeAcceptanceFilter(entry.bus_,
- entry.arbitration_id_ +
- DIAGNOSTIC_RESPONSE_ARBITRATION_ID_OFFSET,
- CanMessageFormat::STANDARD, getCanBuses(), getCanBusCount());
- }*/
+ entry->get_socket().close();
}
/// @brief Cleanup a specific request if it isn't running and get complete. As it is almost