diff options
| author |   Romain Forlot <romain.forlot@iot.bzh> | 2017-06-02 19:48:24 +0200 |
|---|---|---|
| committer | Romain Forlot <romain.forlot@iot.bzh> | 2017-06-02 19:48:24 +0200 |
| commit | 9ecd09263535843e287048d299ca5bdfc85d18d9 (patch) | |
| tree | f6c424072a154775ff890cbbf90f8b48d9319d42 /CAN-binder/low-can-binding/binding | |
| parent | 4ab2164774bdb9a29b2f180a9013c26c0155628d (diff) | |
Remove pointer generator that make memory leaks.
Only have 1 place where to generate a pointer from a DiagnosticRequest
is in low-can-cb.cpp when subscribing. Else now using reference instead
of raw pointer.
Change-Id: I7fd2f3d30afa90017b945e6b711922036123b6d3
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Diffstat (limited to 'CAN-binder/low-can-binding/binding')
| -rw-r--r-- | CAN-binder/low-can-binding/binding/application.cpp | 18 | ||||
| -rw-r--r-- | CAN-binder/low-can-binding/binding/application.hpp | 2 |
2 files changed, 0 insertions, 20 deletions
diff --git a/CAN-binder/low-can-binding/binding/application.cpp b/CAN-binder/low-can-binding/binding/application.cpp index b916523e..6e6353b8 100644 --- a/CAN-binder/low-can-binding/binding/application.cpp +++ b/CAN-binder/low-can-binding/binding/application.cpp @@ -76,21 +76,3 @@ void application_t::set_active_message_set(uint8_t id) { active_message_set_ = id; } - - -std::shared_ptr<diagnostic_message_t> application_t::get_diagnostic_message(const std::string& message_name) const -{ - struct utils::signals_found found; - found = utils::signals_manager_t::instance().find_signals(build_DynamicField(message_name)); - if(! found.diagnostic_messages.empty()) - return found.diagnostic_messages.front(); - return nullptr; -} - -DiagnosticRequest* application_t::get_request_from_diagnostic_message(const std::string& message_name) const -{ - std::shared_ptr<diagnostic_message_t> diag_msg = get_diagnostic_message(message_name); - if( diag_msg != nullptr && diag_msg->get_supported()) - return new DiagnosticRequest(diag_msg->build_diagnostic_request()); - return nullptr; -} diff --git a/CAN-binder/low-can-binding/binding/application.hpp b/CAN-binder/low-can-binding/binding/application.hpp index 50b2375d..5fa64782 100644 --- a/CAN-binder/low-can-binding/binding/application.hpp +++ b/CAN-binder/low-can-binding/binding/application.hpp @@ -78,8 +78,6 @@ class application_t void set_active_message_set(uint8_t id); - std::shared_ptr<diagnostic_message_t> get_diagnostic_message(const std::string& message_name) const; - DiagnosticRequest* get_request_from_diagnostic_message(const std::string& message_name) const; /* /// TODO: implement this function as method into can_bus class /// @brief Pre initialize actions made before CAN bus initialization |