diff options
| author |   Romain Forlot <romain.forlot@iot.bzh> | 2017-05-19 16:17:36 +0200 |
|---|---|---|
| committer | Romain Forlot <romain.forlot@iot.bzh> | 2017-05-19 16:17:36 +0200 |
| commit | fa6d02155e06bee279e017c1c844c2b546bf0d1c (patch) | |
| tree | b3a2f70bc3c6e13b3667db8556460d734df9e382 /CAN-binder/low-can-binding/can/can-message-set.cpp | |
| parent | 53e09a3a8e9ff405ee5936f4765659d3817991e6 (diff) | |
Adjust method signature to be more efficient.
Return vector reference and doesn't return const ref.
Change-Id: Ibcbc1d72e4baf1a7b8bf017d36d6d37d25312d6d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
# Conflicts:
# CAN-binder/low-can-binding/can/can-signals.hpp
Diffstat (limited to 'CAN-binder/low-can-binding/can/can-message-set.cpp')
| -rw-r--r-- | CAN-binder/low-can-binding/can/can-message-set.cpp | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/CAN-binder/low-can-binding/can/can-message-set.cpp b/CAN-binder/low-can-binding/can/can-message-set.cpp index 0bce918e..1e352d9a 100644 --- a/CAN-binder/low-can-binding/can/can-message-set.cpp +++ b/CAN-binder/low-can-binding/can/can-message-set.cpp @@ -22,9 +22,9 @@ can_message_set_t::can_message_set_t( uint8_t index, - const std::string& name, - std::vector<std::shared_ptr<can_message_definition_t> > can_messages_definition, - std::vector<std::shared_ptr<diagnostic_message_t> > diagnostic_messages) + const std::string name, + const std::vector<std::shared_ptr<can_message_definition_t> >& can_messages_definition, + const std::vector<std::shared_ptr<diagnostic_message_t> >& diagnostic_messages) : index_{index} , name_{name} , can_messages_definition_{std::move(can_messages_definition)} @@ -42,17 +42,17 @@ can_message_set_t::can_message_set_t( } /// @brief Return vector holding all message definition handled by this message set. -std::vector<std::shared_ptr<can_message_definition_t> > can_message_set_t::get_can_message_definition() +std::vector<std::shared_ptr<can_message_definition_t> >& can_message_set_t::get_can_message_definition() { return can_messages_definition_; } -std::vector<std::shared_ptr<can_signal_t> > can_message_set_t::get_can_signals() const +std::vector<std::shared_ptr<can_signal_t> > can_message_set_t::get_all_can_signals() const { std::vector<std::shared_ptr<can_signal_t> > can_signals; for(const auto& cmd: can_messages_definition_) { - std::vector<std::shared_ptr<can_signal_t> > cmd_signals = cmd->get_can_signals(); + std::vector<std::shared_ptr<can_signal_t> >& cmd_signals = cmd->get_can_signals(); can_signals.insert( can_signals.end(), cmd_signals.begin(), cmd_signals.end() @@ -62,7 +62,7 @@ std::vector<std::shared_ptr<can_signal_t> > can_message_set_t::get_can_signals() return can_signals; } -std::vector<std::shared_ptr<diagnostic_message_t> > can_message_set_t::get_diagnostic_messages() +std::vector<std::shared_ptr<diagnostic_message_t> >& can_message_set_t::get_diagnostic_messages() { return diagnostic_messages_; }
\ No newline at end of file |