diff options
| author |   Romain Forlot <romain.forlot@iot.bzh> | 2019-06-25 16:23:02 +0200 |
|---|---|---|
| committer | Romain Forlot <romain.forlot@iot.bzh> | 2019-06-27 09:33:12 +0200 |
| commit | f9b67aecdc07d31def64175e0f58e9c0a113f94c (patch) | |
| tree | 74a0baa6ca5d12a60f2c87893ccc086fe44fa0ce /low-can-binding/binding/low-can-subscription.cpp | |
| parent | b8261a3b218de8c07173e3a0eaeb09cad10445b3 (diff) | |
Minor improvements
- Remove now unused forward declaration of active_diagnostic_request_t
- Factorize calling the signals_manager at binding initialization.
- retab...
Bug-AGL: SPEC-2386
Change-Id: I418fddd80ef8b856c198dc697760a6edf0918012
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Diffstat (limited to 'low-can-binding/binding/low-can-subscription.cpp')
| -rw-r--r-- | low-can-binding/binding/low-can-subscription.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/low-can-binding/binding/low-can-subscription.cpp b/low-can-binding/binding/low-can-subscription.cpp index 54cd314c..c2f31a03 100644 --- a/low-can-binding/binding/low-can-subscription.cpp +++ b/low-can-binding/binding/low-can-subscription.cpp @@ -248,14 +248,14 @@ int low_can_subscription_t::open_socket(low_can_subscription_t &subscription, co std::shared_ptr<utils::socketcan_j1939_t> socket = std::make_shared<utils::socketcan_j1939_t>(); ret = socket->open(subscription.signal_->get_message()->get_bus_device_name(), name, pgn, addr); subscription.socket_ = socket; - } - else if ( !bus_name.empty()) - { + } + else if ( !bus_name.empty()) + { std::shared_ptr<utils::socketcan_j1939_t> socket = std::make_shared<utils::socketcan_j1939_t>(); ret = socket->open(bus_name, name, pgn, addr); subscription.socket_ = socket; - } - subscription.index_ = (int)subscription.socket_->socket(); + } + subscription.index_ = (int)subscription.socket_->socket(); } else { |