diff options
| author |   Corentin Le Gall <corentin.legall@iot.bzh> | 2019-11-18 16:48:20 +0100 |
|---|---|---|
| committer |   Romain Forlot <romain.forlot@iot.bzh> | 2020-01-09 14:40:41 +0100 |
| commit | 77a19477d3cb63b5af519853489cc90ead0a111b (patch) | |
| tree | 9c1b34399e45a8870e3b2d01058e9a6c3481c7e8 /low-can-binding/can/can-decoder.cpp | |
| parent | 6cc152447e74b1ce7fab6c7aa1f9b4e5e8232444 (diff) | |
decoder: Fix bit_position swapping
-Added an attribute to signals that tells if the bit_position
has been swapped.
-Test if bit_size and bit_position gives an "out of range" data
Bug-AGL: SPEC-3022
Change-Id: I589565ca923ec807da2d4f0db7c4c92fb737b579
Signed-off-by: Corentin Le Gall <corentin.legall@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Diffstat (limited to 'low-can-binding/can/can-decoder.cpp')
| -rw-r--r-- | low-can-binding/can/can-decoder.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/low-can-binding/can/can-decoder.cpp b/low-can-binding/can/can-decoder.cpp index 19594afa..76ea79e6 100644 --- a/low-can-binding/can/can-decoder.cpp +++ b/low-can-binding/can/can-decoder.cpp @@ -350,9 +350,10 @@ openxc_DynamicField decoder_t::decode_state(signal_t& signal, std::shared_ptr<me /// openxc_DynamicField decoder_t::translate_signal(signal_t& signal, std::shared_ptr<message_t> message, bool* send) { - if(!signal.get_message()->frame_layout_is_little()) + if(!signal.get_message()->frame_layout_is_little() && !signal.bit_position_is_swapped()) { signal.set_bit_position(converter_t::bit_position_swap(signal.get_bit_position(),signal.get_bit_size())); + signal.bit_position_is_swapped_reverse(); } // Must call the decoders every time, regardless of if we are going to // decide to send the signal or not. |