can-bus: Use configuration from JSON file

Use configuration from JSON file instead of the old INI file. Now all configuration files
lies within the binding tree.

Bug-AGL: SPEC-2988

Change-Id: Id986d19751db958ad5cf3b7f2b2c5443d4ceb062
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

2 files changed, 26 insertions, 26 deletions

diff --git a/low-can-binding/can/can-bus.cpp b/low-can-binding/can/can-bus.cpp
index ddf54918..cbe3cda7 100644
--- a/low-can-binding/can/can-bus.cpp
+++ b/low-can-binding/can/can-bus.cpp
@@ -44,12 +44,31 @@ can_bus_t::~can_bus_t()
 }
 
 /// @brief Class constructor
-///
-/// @param[in] conf_file - handle to the json configuration file.
-can_bus_t::can_bus_t(utils::config_parser_t conf_file)
-	: conf_file_{conf_file}
+can_bus_t::can_bus_t()
 {}
 
+/// @brief Fills the CAN device map member with value from device
+///
+/// @param[in] mapping configuration section.
+void can_bus_t::set_can_devices(json_object *mapping)
+{
+	if (! mapping)
+	{
+		AFB_ERROR("Can't initialize CAN buses with this empty mapping.");
+		return;
+	}
+
+	struct json_object_iterator it = json_object_iter_begin(mapping);
+	struct json_object_iterator end = json_object_iter_end(mapping);
+	while (! json_object_iter_equal(&it, &end)) {
+		can_devices_mapping_.push_back(std::make_pair(
+			json_object_iter_peek_name(&it),
+			json_object_get_string(json_object_iter_peek_value(&it))
+			));
+		json_object_iter_next(&it);
+	}
+}
+
 /// @brief Take a decoded message to determine if its value complies with the desired
 /// filters.
 ///
@@ -303,23 +322,6 @@ void can_bus_t::push_new_vehicle_message(int subscription_id, const openxc_Vehic
 	vehicle_message_q_.push(std::make_pair(subscription_id, v_msg));
 }
 
-/// @brief Fills the CAN device map member with value from device
-/// mapping configuration file read at initialization.
-void can_bus_t::set_can_devices()
-{
-	if(conf_file_.check_conf())
-	{
-		can_devices_mapping_ = conf_file_.get_devices_name();
-
-		if(can_devices_mapping_.empty())
-		{
-			AFB_ERROR("No mapping found in config file: '%s'. Check it that it have a CANbus-mapping section.",
-				conf_file_.filepath().c_str());
-		}
-	}
-}
-
-
 /// @brief Return the CAN device index from the map
 /// map are sorted so index depend upon alphabetical sorting.
 int can_bus_t::get_can_device_index(const std::string& bus_name) const
diff --git a/low-can-binding/can/can-bus.hpp b/low-can-binding/can/can-bus.hpp
index 6b0cc133..5aa7a1d5 100644
--- a/low-can-binding/can/can-bus.hpp
+++ b/low-can-binding/can/can-bus.hpp
@@ -26,7 +26,6 @@
 #include <condition_variable>
 #include "openxc.pb.h"
 #include "message/can-message.hpp"
-#include "../utils/config-parser.hpp"
 #include "../binding/low-can-subscription.hpp"
 
 #define CAN_ACTIVE_TIMEOUT_S 30
@@ -43,8 +42,6 @@ class diagnostic_manager_t;
 class can_bus_t
 {
 private:
-	utils::config_parser_t conf_file_; ///< configuration file handle used to initialize can_bus_dev_t objects.
-
 	bool apply_filter(const openxc_VehicleMessage& vehicle_message, std::shared_ptr<low_can_subscription_t> can_subscription);
 	void process_signals(std::shared_ptr<message_t> message, map_subscription& s);
 	void process_diagnostic_signals(diagnostic_manager_t& manager, std::shared_ptr<message_t> can_message, map_subscription& s);
@@ -68,11 +65,12 @@ private:
 
 	std::vector<std::pair<std::string, std::string> > can_devices_mapping_; ///< can_devices_mapping_ - holds a mapping between logical CAN devices names and linux CAN devices names.
 public:
-	explicit can_bus_t(utils::config_parser_t conf_file);
+	explicit can_bus_t();
 	can_bus_t(can_bus_t&&);
 	~can_bus_t();
 
-	void set_can_devices();
+	void set_can_devices(json_object *mapping);
+
 	int get_can_device_index(const std::string& bus_name) const;
 	const std::string get_can_device_name(const std::string& id_name) const;