diff options
| author |   Romain Forlot <romain.forlot@iot.bzh> | 2017-03-16 02:18:00 +0100 |
|---|---|---|
| committer | Romain Forlot <romain.forlot@iot.bzh> | 2017-03-16 17:21:57 +0100 |
| commit | 1ee222a7250896fc7f2e5fb1dc50a7466d81b741 (patch) | |
| tree | 7f73cc373b73314962ef4c774657b0842d3f9e94 /src/low-can-binding.cpp | |
| parent | f3ddfa1c2c4a9ac54f129a63dc9673afdc87bb9e (diff) | |
Implement check of supported diagnostic PID.
Supported boolean member about diagnostic messages is now used. When
a response is received, completed but not successful, then set the diagnostic
message as not supported and clean the request from the queue.
Subscription remains for now, not cool but will be fix soon.
Change-Id: Ia5dc78d4a770f80f144724f4df6eabd2ffd4b8cc
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Diffstat (limited to 'src/low-can-binding.cpp')
| -rw-r--r-- | src/low-can-binding.cpp | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/src/low-can-binding.cpp b/src/low-can-binding.cpp index 8ea885d1..08301933 100644 --- a/src/low-can-binding.cpp +++ b/src/low-can-binding.cpp @@ -133,7 +133,12 @@ static int subscribe_unsubscribe_signals(struct afb_req request, bool subscribe, std::vector<diagnostic_message_t*> found; configuration_t::instance().find_diagnostic_messages(build_DynamicField(sig), found); DiagnosticRequest* diag_req = new DiagnosticRequest(found.front()->build_diagnostic_request()); - + + // If the requested diagnostic message isn't supported by the car then unssubcribe. + // no matter what we want, worse case will be a fail unsubscription but at least we don't + // poll a PID for nothing. + if(found.front()->get_supported()) + subscribe = false; if(subscribe) { float frequency = found.front()->get_frequency(); |