Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: I3c4364d6038bd60546726fba940f043f5abcb6d2
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: I174c546afb6b21df431e0a61677292d43af8f0ca
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: I287e445c6f1c372a852752911d032a70654aa082
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Multiplication was a very specific needs for diagnostic manager when using
systemd event loop timer. Now it is the right period that is calculated and
multiplication is done into the right place. Cleaner.
Change-Id: Ie3dffe8daa0fa9bd9bde408e62a8d7a06a333a25
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Else we got infinite value if 0 and negative value doesn't make sense here.
Change-Id: Id65f0aa94cae32f1fea2c5c80028e328e6958a13
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: Iab309e313f63beb4b56bc824ece1b3a5e42ae508
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
can_dlc field was set to 0 and is evaluated so BCM assumes there is no data
to transmit. It is mandatory to set it.
Change-Id: I1e29ff4248a49212d3fee22c3a0cc77f5b699fd7
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Wrong test about CAN ID, it isn't the response ID that is passed as argument
but the broadcast. Little mistake...
Change-Id: I2622c23356802c3108dbf8e6ede07456294834ee
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: Ibcc1419caba7e1b04dbe652a6c60c393f14a8145
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
As for CAN signal, monitoring diagnostic request messages is now handled by
systemD io event loop. Socket reading is common for all OBD2 signals and handled
by the diagnostic manager.
systemd callback function lies in binding callback which in turns call read_socket
method of diagnostic manager. Processing is little bit different from classic CAN
messages so it is a separate callback function.
Lot of cleaning to do now...
Change-Id: I4d2ada0beb5d3348736dfdf3c56a7cb875a1c6c7
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
As there will be more bcm socket and more need to set its timer values.
May be there is a better method to separate integer and decimal parts from
a float value.
Change-Id: I0cd992dfde5fe8257b17b5b610482f5f5e09aa8c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Return bus name string.
Change-Id: I0e7f4171c3d1052cb6425cd5b93e5a593d7d277f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: I3daa11b329f2e38efba5a52c2106bddd3b759f86
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Use 2 sockets:
- TX sockets on active_diagnostic_request class as we need X sockets
using the same CAN ID "7DF" with different timing settings
- RX socket on diagnostic_manager object as we need to read the same CAN ID
and process them the same way, there isn't so much need to split them.
Change-Id: I7338fd751a033a1d0e8912ee554e2c72c43961c3
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Shared pointer on value is a wrong way because once they is no more object
refering to a parent then the pointer on it is destoyed. Not a big deal here
but we better have to use raw pointer.
Change-Id: I58deeb9e82c446ea135be87c11f405da54cc5bff
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
These members was imported from OpenXC project which was in C so they need
to know array size. As we use vector we doesn't need them anymore. We can
retrieve count using size() vector method
Change-Id: Iefd0266d400097ab2dae813aca196c8e3b9bc368
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: I2d3f7525bb85c051c43aeda6b9cc1be0f3e270c8
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Little optimization that will pass a ref instead of a copy value.
Change-Id: I62fbaaa2fb01cf809e60b592a3d91f06d7235205
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Message set count members as to be changed because now useless... This is
left part from OpenXC port.
Change-Id: I3a3dc6091b49eabf0d17324634406bd7b0edafb2
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: Ib31483663a90c8dad129f59372e1ced3a79c7403
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
New redundant function creation to mutualize code between two operations.
Change-Id: I8516c2c6d2f0c1d5cf89244ea23b831530e84a5f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: Idc49593fdc1a039c6a03626115e4156a629e4e65
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: I038677d688c64e87ae86dd2af245f87f5c40e317
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Vector of shared_ptr is made to shared ownership about object around project.
This is the default returned value by getter methods when lookup and manipulating
them.
Change-Id: Id37947bb5994b629f4bf3faecc5ffac81c55e1e6
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Now we respect JSON description file, which is can_message_set contains
can_message_definition which contains can_signals.
Diagnostic messages aren't processed for now.
Change-Id: I94aaf5eded14dd84395bd4fd749df58dee5f533e
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: Ibcd71f585246172c191b67b45e3b2763f7722958
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: I23b862e748e13e7ba69743c8a9d3abb0be36c4bc
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
So use const value
Change-Id: I81f9a4766d71116e2f3a2af8785b1bd1c69e2c20
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: Ib84c365207e32f71fc4cb7e350f99d147317fa08
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Needed because we use systemd event loop that recommend that.
Change-Id: Ia3faf35fe80a973f7a7b1c81f6a8adf96705394b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
We always read the same object so how to fill it is the job of specialized class
not a generic method can do that.
Change-Id: Ia262871cec6b7ed3341eb314d5ed6641b8da61e6
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
In addition to signal last_values, now message last value is also set.
Change-Id: I87c2be3e4e68073d7708b2ddf681889576337410
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
And reset can_reader to can_bus_dev_t like the old behavior because BCM sockets
has been implemented at signals level not device.
Change-Id: I715a19ff65bf9d7231c73b66c1ee95b3f41f8ed0
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Even if the frame read is wrong doesn't mean that socket is compromise only
that communication on CAN bus is difficult, maybe temporary. On en EPOLL err
code, or hangup, just close and restart the socket and reset the filter.
Change-Id: I61f146fd269bb2524f09e1f2ed89d93e83166136
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: I1c080f961f62a6816b0c36e960ae1ecbeb7fa00d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: I89d227e48add0c7fc8a4ca577023995b269e6f13
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Now derivated class use constructor from base class and we don't destroy
socket when a socket object is over since it may be copied before. So closing
them is in charge of dev, well me...
Change-Id: I0440119017a3e56bb83d0194a6908dc3e2b8f745
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: Ibec47106f8510e92a017fc08aeb2eeaeef2884e5
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Move create_rx_filter to can_signals and adding all accessories needed to works.
Change-Id: I3636fe82ce5c2e43a4992b66ce89440ff709004a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: I91155eda22a172efc88f72243c260480a2d1d4ce
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
As well as handling reading signals BCM socket using systemd event loop.
Change-Id: I1e121635ec5db489b2bcb88a3101e716bf8883d5
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: Ib24f8c2000f78f5f6fea3126e52f34570e4eee18
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change include statement to refer the correct new path to the files.
Also change CMakeLists.txt.
Change-Id: I66a0bccab02e9fce10072a275a6580d61b4ddfbe
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
https://gerrit.automotivelinux.org/gerrit/#/admin/projects/apps/app-templates
Change-Id: I42eff75b790b70047e1b91b963edf458084881c9
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Copy constructors are allowed since socket will never be closed during binding
runs.
Change-Id: Ie33e4b7e885d45e1ffeb980400df00ae2a97e45d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: Icedbe5b8c420b0fb77eb331577e11c35c4597d80
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: Iaf68d463e9df4d6dda2a8508adf5395041d2ff7f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: I8cb170613c003bbdb39240eb809b8cefcad6cb35
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: I804abe6eb0965b54fb93bc8da2b1e1665b99476d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Use to initialize raw, bcm and later isotp socket. Now we should have,
1 BCM socket by signal to make filter on them. 1 raw socket by devices is kept
to use diagnostic manager as is.
Change-Id: Icb2daddf67039479f72bc487d53971adc9aba638
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|