Age | Commit message (Collapse) | Author | Files | Lines |
|
When sending a CAN signal make an case-insensitive comparison as it isn't
necessary to be strict on that, so case insensitive if fine.
Update the documentation accordingly.
Bug-AGL: SPEC-2582
Change-Id: I998b64cdd9a381da3da582aeba42ab726fff1259
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Signed-off-by: Sebastien Douheret <sebastien.douheret@iot.bzh>
Change-Id: Iea56414f8ccf3d96b2fc67126b066c4032fe86a8
|
|
- Remove now unused forward declaration of active_diagnostic_request_t
- Factorize calling the signals_manager at binding initialization.
- retab...
Bug-AGL: SPEC-2386
Change-Id: I418fddd80ef8b856c198dc697760a6edf0918012
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
This commit updates differents application-generated.cpp files
with the low-can generator updated with j1939.
This commit adds the description of j1939 messages.
Bug-AGL: SPEC-2386
Change-Id: I798a7da34c1be3526fec6bc3e424a6b88eaf46ff
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Bug-AGL: SPEC-2386
Change-Id: I3a622b9d236283aff479f187451cd86557a9aba7
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
The function open_socket has been modified
to open a j1939 socket with a filter
Bug-AGL: SPEC-2386
Change-Id: Ieed5c1d14efdb469f5a7b831c9e8a950e04e9d42
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
The commit allows at the time of subscription to do:
-> low-can subscribe {"id": 48}
-> low-can subscribe {"pgn": 61442}
The generation of event_filter has been extracted in a separate function.
Bug-AGL: SPEC-2386
Change-Id: I592e668c63be448562b27c81fcdc111cd34f3676
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
This commit renames files and classes :
- can_message_definition_t -> message_definition_t
- can_message_set_t -> message_set_t
- can_signals_t -> signals_t
This prepares the implementation of j1939 protocol.
Bug-AGL: SPEC-2386
Change-Id: Ie3ee4f25c236c861b92eb12a56fa03a5a9afffbb
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
This commit transforms the class can_message_t as the base class
and creates two derived classes: j1939_message_t and can_message_t.
Bug-AGL: SPEC-2386
Change-Id: I6d3afd8e4f5abff2cd0ec4e9910bd52a2893de76
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
This change is made to leverage C++ to read and write the different socket
classes depending on CAN protocol used.
Bug-AGL: SPEC-2386
Change-Id: I5e25e271fc82e9627f836aeb43b2af5ef25db83a
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Better to use shared_ptr instead of raw pointer if possible.
Bug-AGL: SPEC-2386
Change-Id: Id853d8ac6cddd1e53edd84e3bf27b0f1f5d92d4b
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
This commit implements a new socket class for the j1939 protocol and
prepares the bases classes by modifying the write and read methods.
Bug-AGL: SPEC-2386
Change-Id: I16ba493418a4bb37a0262b61a2a2629be6ab5051
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Add these fake can data.
We want to modify dashboard, let is show more information.
accelerator.pedal.position
steering.wheel.angle
transmission.gearinfo
transmission.mode
turnsignal.status
lightstatus.brake
parking.brake.status
Change-Id: Ief9f29684f3463af0d0f98f1dd213b633d1889bb
Signed-off-by: zheng_wenlong <wenlong_zheng@nexty-ele.com>
|
|
- Improve robustness reading a BCM socket
Adding checks on system calls and remove the initialization of the
struct that will hold the received message, not so much needed in
that case.
- More accurate log message at subscription/unsubscription step whether
this is a FD CAN messages or not and if this a subscription or an
unsubscription that is requested.
- Initialize the full struct of vehicle message to avoid memory warning
about conditionnal jump based on uninitialized bytes.
- Memleak: Free raw pointer on active diagnostic requests
Change-Id: I4bbf4d851c0fa1efdb6fa6034fac3d1dcafa1a73
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Don't use a child class for subscription, only use one because there
isn't other different subscriptions type to be implemented about now
and if so then we could split again.
Remove functions no longer useful and move afb events and afb
subscriptions part to low-can-subscription
Change-Id: Ie3e4255961ac557465098cdb48730098a950461a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Also formating and retabulating some comments
Change-Id: I95eda93e78fabeb336ca02e94307364954ab2318
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Add a flag to CAN message definitions which set the message as using FD
protocol if true.
Use a new generated file with the new FD flag field on the message
definitions.
Change BCM socket "struct" using an union to store the CAN frames either
using the FD struct or the classic non FD struct. A BCM socket can only
one frame type once configured.
Use as much as possible the "struct canfd_frame" in the binding and only
make a difference before writing or reading the socket. From a memory
point of view both struct are identical and only the last member differ
and could hold more data with messages of 64 bytes long. So the
canfd_frame is compatible with the can_frame and can be differentiated
by a flag set in the can_id member.
Remove now unused code processing can_frame.
Keep the diagnostic manager using the classic CAN frame.
Set the maximum number of frames that a BCM socket can handle to 257.
Bug-AGL: SPEC-1980
Change-Id: Ifcc041281ea6745fc25cbd384743761f4446f489
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
- Adds the possibility to use a custom encoder function
- Use of wrap_json functions instead of raw json-c functions
- Return the error informations in the request return.
- Reduce conditionnal imbrication
Bug-AGL: SPEC-1965
Change-Id: I766b3cf3e6998d03a8a2f3e51117e8b26fc9b56f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: I7bf15568a16e0c84c4f590ca07eba48ecd34157f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Also clean an unused function
Change-Id: I4faabf5a1af53da898ee70f2bc4b528acea3ded3
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: I0bcccb15200064bd7d83edbf06c1e7202069189a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: I2e8d89b09982c9f3770a5a3e10d281e0ad87651c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Let use the new decoder's function and set some hvac signals
as writable to be able to test this feature.
Change-Id: I27e1c2be069b8bb55ed931ad1fb629aa2d4e5b86
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
This files is generated by afb-genskel tools at build time.
Having it in the repo could make some unwanted side effects.
Change-Id: Ib5c6b010fe56245694fe267aca0548575b6e063b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Create first tests to be used with afb-test binding
The test binding is now found using pkg-config command.
Change-Id: Ib1cd08236b6b8fab93ccb67ac613a9c83908d12e
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
|
|
This change set fixes the comments made by previous contributors
v2: Fix line end
v3: Making changes to comments as suggested by reviewers
v4: Removing trailing spaces
v5: Clearing small typo in low-can-cb.cpp on line 142
Change-Id: Ifbcfc3b2d131d1db0b25e472955b21e98cc09f45
Signed-off-by: ydimitrov <y.dimitrov.14@gmail.com>
|
|
Change-Id: I3ea7b3aa91d4251f90a4ccf5da83ae8de7a58db4
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Get engine state recurringly by requesting a permanent
diagnostic messages request.
Use these information to warn that diagnostic request won't have any responses
at the moment of subscription if engine is off.
Bug-AGL: SPEC-1347
Change-Id: If8bd79bba89acd1c8f5452d3efdbf00a89f8cc77
Signed-off-by: Jonathan Aillet <jonathan.aillet@iot.bzh>
|
|
Add possibility to subscribe to a recurring request that won't be deleted
when no subscriber is detected.
For now, this functionnality is implemented for internal use only.
Bug-AGL: SPEC-1347
Change-Id: I48f6f647677596ba7920c4348d5406ea7bf1081b
Signed-off-by: Jonathan Aillet <jonathan.aillet@iot.bzh>
|
|
Add saving of diagnostic messages receive state, last value,
and timestamp associated to it.
Add methods to get/set these information.
Add initialisation for added atributes.
Add boolean to set receive state at initialisation.
Generate all 'diagnostic-message.cpp' containing diagnostic messages
to add receive state initialisation.
Bug-AGL: SPEC-1347
Change-Id: Iee82ca3b5f79fd267717ae074d5456b8cbc1c377
Signed-off-by: Jonathan Aillet <jonathan.aillet@iot.bzh>
|
|
Bug-AGL: SPEC-1276
Change-Id: I279620c1be00db03f06f6dd882b3b579c80480c4
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
When a new subscription is made, search in existing subscription for a
combination of a signal and a filter instead of searching for just a signal.
In this way, each subscription will receive signals according to
their requesting filter.
Bug-AGL: SPEC-1339
Change-Id: I22cb96a2dbaaf48dbd77025ff1610bde151b19b4
Signed-off-by: Jonathan Aillet <jonathan.aillet@iot.bzh>
|
|
Delete obsolote references such as use of acceptance filters,
timers, etc.
Signed-off-by: Jonathan Aillet <jonathan.aillet@iot.bzh>
|
|
Cleaning header file inclusion
Change-Id: Ic0dd9637ecd491692bd4b8b39e9602e85498c0a9
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: I8d75a232ba7fad9cc95f286e521c2451a3a29061
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: I1c7299bdf9ff024f676b88860c8d31076f6806e0
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Confusion made with permission generated and legacy one
which weren't the same.
Removing unused source file
Change-Id: I74f70b45358c052049ff84b872c0381915e27344
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Generated files hand fixed because of usage of C++
which has to use c++ binding function afb::auth to
add afb_auth struct
Change-Id: I80ee9cb751cc813754c949d8746aec197da6d52f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: I33ade46eaf022a5c7e7cf874f8b838a4a6827f87
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: Id03f6363c5d452db43c696e045caaefad0916dc6
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
This patch is porting AMB get() and list() API.
Change-Id: Ic1d391219f1d64ab127bc1977a5b198abe0fc94b
Signed-off-by: Yuichi Kusakabe <yuichi.kusakabe@jp.fujitsu.com>
|
|
write_raw_frame() and write_signal() return results.
Change-Id: I3f6d03eaf02bde9ad02fd8de912c5816d249570f
Signed-off-by: Yuichi Kusakabe <yuichi.kusakabe@jp.fujitsu.com>
|
|
This patch is low-can write device use /dev/dev-mapping device name.
Change-Id: I165bdbd37a4e988b85f6ad7a669e6b1306957d45
Signed-off-by: Yuichi Kusakabe <yuichi.kusakabe@jp.fujitsu.com>
|
|
Change-Id: Ic346c408c938aad39fbea387af4224c14d8a727c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: I995fa8af8e8fc330f07b9609129723c09e0b13bf
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: I64dd5b3f241a9696dc759dffff884772e3f72fd7
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: I3547560ebfa0fbc484bf411ce7c08011db6f64b1
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Separated by protocols and created signals from reversed
engineered signals.
Meld all used signals into an "agl-vcar" folder to be used as
default.
Change-Id: I27f7bc227a6fcea3db6672819e6a4d7bbf09863b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|
|
Change-Id: I036befbfb38b01d046d35a1364c28e0835dcbd41
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
|