aboutsummaryrefslogtreecommitdiffstats
path: root/src/hs-proxy.cpp
diff options
context:
space:
mode:
authorLi Xiaoming <lixm.fnst@cn.fujitsu.com>2021-02-01 11:44:05 +0800
committerLi Xiaoming <lixm.fnst@cn.fujitsu.com>2021-02-01 11:44:05 +0800
commitf19cfe46d7172b512f06f5acf657b8d56e69a0b3 (patch)
treef21e2522a5dcc84ea8c42b35e0f3055fc0e0f2bf /src/hs-proxy.cpp
parenta06ae44353446b2684a4a43f4332ad93a43feadb (diff)
Fix potential memory leak
json structure allocating code should be placed in where it is used, if there is a condition check which may cause a return before the before-mentioned place in the function. Bug-AGL: SPEC-3584 Change-Id: I5f88c7ce0b9257b2782144548f11a0e1d7ab388a Signed-off-by: Li Xiaoming <lixm.fnst@cn.fujitsu.com>
Diffstat (limited to 'src/hs-proxy.cpp')
-rw-r--r--src/hs-proxy.cpp3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/hs-proxy.cpp b/src/hs-proxy.cpp
index 33e5d53..33cfce3 100644
--- a/src/hs-proxy.cpp
+++ b/src/hs-proxy.cpp
@@ -154,7 +154,6 @@ int HS_AfmMainProxy::detail(afb_api_t api, const std::string &id, struct json_ob
*/
void HS_AfmMainProxy::start(struct hs_instance *instance, afb_req_t request, const std::string &id)
{
- struct json_object *args = json_object_new_string(id.c_str());
struct closure_data *cdata;
/* tentatively store the client and client context, as the afb_req_t
@@ -187,5 +186,5 @@ void HS_AfmMainProxy::start(struct hs_instance *instance, afb_req_t request, con
AFB_WARNING("Failed to handle subcribe\n");
}
- api_call(request->api, _afm_main, __FUNCTION__, args, cdata);
+ api_call(request->api, _afm_main, __FUNCTION__, json_object_new_string(id.c_str()), cdata);
}