summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLi Xiaoming <lixm.fnst@cn.fujitsu.com>2021-01-15 19:16:47 +0800
committerLi Xiaoming <lixm.fnst@cn.fujitsu.com>2021-01-15 19:20:26 +0800
commit9f6da135fc36eea418ecc15f77f4f8ef0dea6e7b (patch)
tree16677878971255fa30fe0e005fcee1e245476c64
parentb836eb906165331584bef7a8eaaddf2ca3cc7530 (diff)
It is better to init jresp as NULL, and allocate new memory when it is used, this will avoid the memory leak if the function returns during the process. Bug-AGL: SPEC-3584 Change-Id: Icb1eae050294f4438ad89739e324c5483b6b3441 Signed-off-by: Li Xiaoming <lixm.fnst@cn.fujitsu.com>
-rw-r--r--binding/navigation-api.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/binding/navigation-api.c b/binding/navigation-api.c
index 1774e29..07e5216 100644
--- a/binding/navigation-api.c
+++ b/binding/navigation-api.c
@@ -80,7 +80,7 @@ static void navigation_subscribe_unsubscribe(afb_req_t request,
gboolean unsub)
{
struct navigation_state *ns = navigation_get_userdata();
- json_object *jresp = json_object_new_object();
+ json_object *jresp = NULL;
const char *value;
afb_event_t event;
int rc;
@@ -121,6 +121,7 @@ static void navigation_subscribe_unsubscribe(afb_req_t request,
return;
}
+ jresp = json_object_new_object();
afb_req_success_f(request, jresp, "Navigation %s to event \"%s\"",
!unsub ? "subscribed" : "unsubscribed",
value);