diff options
| author |   Li Xiaoming <lixm.fnst@cn.fujitsu.com> | 2021-01-15 19:16:47 +0800 |
|---|---|---|
| committer | Li Xiaoming <lixm.fnst@cn.fujitsu.com> | 2021-01-15 19:20:26 +0800 |
| commit | 9f6da135fc36eea418ecc15f77f4f8ef0dea6e7b (patch) | |
| tree | 16677878971255fa30fe0e005fcee1e245476c64 | |
| parent | b836eb906165331584bef7a8eaaddf2ca3cc7530 (diff) | |
Fix potential memory leakneedlefish_13.93.0needlefish/13.93.0marlin_12.93.0marlin_12.92.0marlin_12.91.0marlin_12.90.1marlin_12.90.0marlin/12.93.0marlin/12.92.0marlin/12.91.0marlin/12.90.1marlin/12.90.0lamprey_11.92.0lamprey_11.91.0lamprey/11.92.0lamprey/11.91.0koi_10.93.0koi_10.92.0koi/10.93.0koi/10.92.013.93.012.93.012.92.012.91.012.90.112.90.011.92.011.91.010.93.010.92.0
It is better to init jresp as NULL, and allocate new memory when it is
used, this will avoid the memory leak if the function returns during the
process.
Bug-AGL: SPEC-3584
Change-Id: Icb1eae050294f4438ad89739e324c5483b6b3441
Signed-off-by: Li Xiaoming <lixm.fnst@cn.fujitsu.com>
| -rw-r--r-- | binding/navigation-api.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/binding/navigation-api.c b/binding/navigation-api.c index 1774e29..07e5216 100644 --- a/binding/navigation-api.c +++ b/binding/navigation-api.c @@ -80,7 +80,7 @@ static void navigation_subscribe_unsubscribe(afb_req_t request, gboolean unsub) { struct navigation_state *ns = navigation_get_userdata(); - json_object *jresp = json_object_new_object(); + json_object *jresp = NULL; const char *value; afb_event_t event; int rc; @@ -121,6 +121,7 @@ static void navigation_subscribe_unsubscribe(afb_req_t request, return; } + jresp = json_object_new_object(); afb_req_success_f(request, jresp, "Navigation %s to event \"%s\"", !unsub ? "subscribed" : "unsubscribed", value); |