summaryrefslogtreecommitdiffstats
path: root/binding/navigation-api.c
AgeCommit message (Collapse)AuthorFilesLines
2021-01-15Fix potential memory leakneedlefish_13.93.0needlefish/13.93.0marlin_12.93.0marlin_12.92.0marlin_12.91.0marlin_12.90.1marlin_12.90.0marlin/12.93.0marlin/12.92.0marlin/12.91.0marlin/12.90.1marlin/12.90.0lamprey_11.92.0lamprey_11.91.0lamprey/11.92.0lamprey/11.91.0koi_10.93.0koi_10.92.0koi/10.93.0koi/10.92.013.93.012.93.012.92.012.91.012.90.112.90.011.92.011.91.010.93.010.92.0Li Xiaoming1-1/+2
It is better to init jresp as NULL, and allocate new memory when it is used, this will avoid the memory leak if the function returns during the process. Bug-AGL: SPEC-3584 Change-Id: Icb1eae050294f4438ad89739e324c5483b6b3441 Signed-off-by: Li Xiaoming <lixm.fnst@cn.fujitsu.com>
2020-01-14Integrate navigation voice capability useicefish_8.99.5icefish/8.99.58.99.5Scott Murray1-11/+125
Add code to pull in the voice capabilities binding, subscribe to the existing setDestination and cancelNavigation events, and use the data that comes from them to set/clear the destination waypoint. Bug-AGL: SPEC-3107 Signed-off-by: Scott Murray <scott.murray@konsulko.com> Change-Id: Iaeb0283492cc89e8cff1a1558cab7554e32e3142
2019-12-06binding: navigation: deep copy json response for cacheicefish_8.99.4icefish_8.99.3icefish/8.99.4icefish/8.99.38.99.48.99.3Matt Ranostay1-12/+11
To avoid possible side effects from afb framework releasing a cached json_object just deep copy to target cached object. Bug-AGL: SPEC-2880 Change-Id: Ie953d4668cd4e9a33a91d727a378cd24e75f112e Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-12-06binding: navigation: move get_storage_from_value call within write lockicefish_8.99.2icefish/8.99.28.99.2Matt Ranostay1-1/+3
json_object returned from get_storage_from_value() needs to be protected within the write lock. This is to prevent reentrant calls to broadcast() from accessing it, and running json_object_put() Bug-AGL: SPEC-2880 Change-Id: I9fdf614728368c75e925e4c5a0f3ca19a7e517e1 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-12-03binding: navigation: add missing read lock around afb_event_push()Matt Ranostay1-0/+10
Add missing read lock around event pushing from value that isn't required to be cached. Bug-AGL: SPEC-2880 Change-Id: I7aae2ec9df722fdefcec2d35977251e008375d92 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-10-31binding: navigation: rewrite of navigation bindingMatt Ranostay1-0/+245
To remove dependency on DBus the binding needed to be rewritten to output pure JSON output to subscribed consumers. Bug-AGL: SPEC-2880 Change-Id: Ie85dfccd42ca36119116a0fbfb16bf4e96efc184 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>