summaryrefslogtreecommitdiffstats
path: root/test
diff options
context:
space:
mode:
authorLi Xiaoming <lixm.fnst@cn.fujitsu.com>2021-01-13 19:42:37 +0800
committerLi Xiaoming <lixm.fnst@cn.fujitsu.com>2021-01-14 02:02:58 +0000
commite863ff24df3332c57030366bb505189a28edf1ea (patch)
tree96c2cbfe8e9db43c630dc408bd04b2f5b471d0d0 /test
parent8c6e15356eaa9b13ff76873e79362ad78c730ec5 (diff)
It is better to init jresp as NULL, and allocate new memory when it is used, this will avoid the memory leak if the function return during the process. jobj should be freed before function returns. Bug-AGL: SPEC-3584 Change-Id: I4b917f7ecd06a1800d453ec43ffeccee89d923c6 Signed-off-by: Li Xiaoming <lixm.fnst@cn.fujitsu.com>
Diffstat (limited to 'test')
-rw-r--r--test/agl-service-network-ctl.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/test/agl-service-network-ctl.c b/test/agl-service-network-ctl.c
index 6808b8d..4be427a 100644
--- a/test/agl-service-network-ctl.c
+++ b/test/agl-service-network-ctl.c
@@ -405,11 +405,13 @@ bool add_property_value(json_object *jparent, const char *key, int argc, char *a
span = next_span(i + 1, argc, argv);
if (span < 0) {
+ json_object_put(jobj);
fprintf(stderr, "bad nesting\n");
return NULL;
}
if (!add_property_value(jobj, key2, span, argv + i + 1)) {
+ json_object_put(jobj);
fprintf(stderr, "error adding object\n");
return false;
}