aboutsummaryrefslogtreecommitdiffstats
path: root/binding
AgeCommit message (Collapse)AuthorFilesLines
2021-01-14Fix potential memory leakneedlefish_13.93.0needlefish/13.93.0marlin_12.93.0marlin_12.92.0marlin_12.91.0marlin_12.90.1marlin_12.90.0marlin/12.93.0marlin/12.92.0marlin/12.91.0marlin/12.90.1marlin/12.90.0lamprey_11.92.0lamprey_11.91.0lamprey/11.92.0lamprey/11.91.0koi_10.93.0koi_10.92.0koi/10.93.0koi/10.92.013.93.012.93.012.92.012.91.012.90.112.90.011.92.011.91.010.93.010.92.0Li Xiaoming1-1/+2
It is better to init jresp as NULL, and allocate new memory when it is used, this will avoid the memory leak if the function return during the process. jobj should be freed before function returns. Bug-AGL: SPEC-3584 Change-Id: I4b917f7ecd06a1800d453ec43ffeccee89d923c6 Signed-off-by: Li Xiaoming <lixm.fnst@cn.fujitsu.com>
2019-09-04fix(network-util.c): Remove -Woverflow warningLi Xiaoming1-1/+1
agl-service-network/binding/network-util.c:160:14: warning: integer overflow in expression ‘-2147483648’ of type ‘long int’ results in ‘-2147483648’ [-Woverflow] if (i64 >= -(1L << 31) && i64 < (1L << 31)) Bug-AGL: SPEC-2422 Change-Id: I3bdc78527b1fff44917561ea49dcfefa7a4d83a2 Signed-off-by: Li Xiaoming <lixm.fnst@cn.fujitsu.com>
2019-09-04fix(network-util.c): Remove -Wformat warningLi Xiaoming1-1/+1
agl-service-network/binding/network-util.c:281:16: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 7 has type ‘gsize’ {aka ‘unsigned int’} [-Wformat=] AFB_WARNING("Can't handle variants with more than one children (%lu)", nitems); Bug-AGL: SPEC-2422 Change-Id: I0805dd2c1828818000cc92b7a8ea1e4c90e39073 Signed-off-by: Li Xiaoming <lixm.fnst@cn.fujitsu.com>
2019-06-20binding: network: fix conversion compiler warningsMatt Ranostay1-3/+6
Remove follow warnings by switching from int to size_t warning: conversion from ‘size_t’ {aka ‘long unsigned int’} to ‘int’ may change value [-Wconversion] Bug-AGL: SPEC-2535 Change-Id: I03bb459454d49d9771bc1101338e80c3f394a00e Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-04-05binding: network: remove versioning references in structshalibut_7.99.1halibut/7.99.17.99.1Matt Ranostay1-2/+2
In order to upgrade to future versions easier don't use versioned structs but the respective typedefs Change-Id: Ib61ed769d16907a7c3842206f2168b503001cac1 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-01-16binding: network: remove unimplemented counter functionalityguppy_6.99.4guppy/6.99.46.99.4Matt Ranostay2-78/+0
counter_event wasn't implemented, and the respective reset_counters verb doesn't really have any use. Change-Id: Ibc2142b7f58c06e67430b31307bc7139837c9866 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2018-08-22binding: networking: add type to simple_gvariant_to_jsonguppy_6.90.0guppy/6.90.0flounder_5.99.6flounder_5.99.5flounder_5.99.4flounder/5.99.6flounder/5.99.5flounder/5.99.46.90.05.99.65.99.55.99.4Matt Ranostay1-0/+1
add G_VARIANT_CLASS_OBJECT_PATH to processing function since it is effectively a string. Change-Id: Ifb079681a840442ee75e755c33abd162db1d9d2a Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2018-08-10binding: networking: remove global state variableflounder_5.99.3flounder/5.99.35.99.3Matt Ranostay1-20/+25
Switch to the AFB framework v3 functionality to save userdata pointers versus using a global definition. Bug-AGL: SPEC-1660 Change-Id: I71752d3e392b4d8bb00e394f44f414813b83a85d Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2018-08-10binding: network: upgrade to AFB v3 frameworkMatt Ranostay4-57/+57
Upgrade the binding to use v3 datatypes, and function parameters. Bug-AGL: SPEC-1660 Change-Id: I50b88b8d87a7176917bfa639bc8cffc0bc2bed89 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2018-07-24Fix crash in parsing of technology added and removed signalsflounder_5.99.2flounder/5.99.25.99.2Matt Porter1-2/+2
The object path in the TechnologyAdded and TechnologyRemoved signals is provided as a tuple. The binding currently segfaults when receiving this signal since it tries to parse it with an invalid variant format string. Update the format string parameter to reflect that it should parse the object path as a tuple. Bug-AGL: SPEC-1585 Change-Id: I36a588ec43475a24996b9a58c1f326a35d260396 Signed-off-by: Matt Porter <mporter@konsulko.com>
2018-07-11Return service change event arrays in a nested objectMatt Porter1-4/+6
When generating a services event, nest the array of service changes in another object under the "values" key. Bug-AGL: SPEC-1540 Change-Id: Id71bc1863ab564a7f6e4753a7fc082ccbe5a9596 Signed-off-by: Matt Porter <mporter@konsulko.com>
2018-07-10Return technology and service response arrays in a nested objectMatt Porter1-4/+7
The binding currently just attachs a json array to the response object. To make parsing of the reply payload simpler, always attach a json object with the array added to the "values" key. Bug-AGL: SPEC-1540 Change-Id: I1753ec4a2d1c0186e807db004d58d2016c0e8e96 Signed-off-by: Matt Porter <mporter@konsulko.com>
2018-07-10update event namesMatt Porter1-3/+3
Some event names had _event appended to them and there are a couple typos. Fix these to make the naming consistent throughout the binding. Bug-AGL: SPEC-1540 Change-Id: Ia006acd17df371cfe6ff299bb6b420dc7b22a24e Signed-off-by: Matt Porter <mporter@konsulko.com>
2018-07-10remove ping verbMatt Porter1-21/+0
The ping verb was used in testing and is no longer needed. Remove it. Bug-AGL: SPEC-1540 Change-Id: Ia906c2b489f56188e87061ad675330dd29581f97 Signed-off-by: Matt Porter <mporter@konsulko.com>
2018-07-10initial network service bindingPantelis Antoniou6-0/+3933
The AGL network service binding exposes connman apis via the AGL application framework. All network connectivity technologies are supported via the binding, limited only by the underlying connman daemon. Bug-AGL: SPEC-1540 Change-Id: Id73cfc98c7abe97cb655a4fc40d440422fa75803 Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com> [Cleanups to whitespace and naming to match other services] Signed-off-by: Matt Porter <mporter@konsulko.com>