aboutsummaryrefslogtreecommitdiffstats
path: root/binding/afm-nfc-binding.c
AgeCommit message (Collapse)AuthorFilesLines
2019-09-13re-balance refcount for jresphalibut_8.0.6halibut_8.0.5halibut_8.0.4halibut_8.0.3halibut_8.0.2halibut/8.0.6halibut/8.0.5halibut/8.0.4halibut/8.0.3halibut/8.0.28.0.68.0.58.0.48.0.38.0.2halibutRaquel Medina1-0/+1
afb_event_push most recent implementation calls 'json_object_put', thus affecting the reference count for jresp in agl-service-nfc binding. A call to 'json_object_get' has been added to keep jresp available for the binding. SPEC-2800 Signed-off-by: Raquel Medina <raquel.medina@konsulko.com> Change-Id: I6c9f9df8152918dcd70452465352a848eb195f94 (cherry picked from commit a1a9d26d5b1ffc06f57d5bb61cf0b5012a02084a)
2019-02-25binding: nfc: fix build warningsRaquel Medina1-5/+3
Fix warnings due to may be unused artifacts. Fix whitespace. Change-Id: Ibeef05406887d72414a3df7da71197e80c2f9ceb AGL-Bug: SPEC-2212 Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
2019-01-25binding: nfc: include reply to presence event requests in error pathsRaquel Medina1-4/+4
AGL-Bug: SPEC-2141 Change-Id: Ic81ea3463fd51a67e6035ceff5af4039abbc5fce Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
2019-01-07binding: nfc: increase safety checks around neardal api calls.halibut_7.90.0halibut/7.90.0guppy_6.99.4guppy/6.99.47.90.06.99.4Raquel Medina1-33/+187
Bug-AGL: SPEC-2062 When the NFC adapter is powered up and agl-service-nfc sends a request to power it, or when the NFC adapter is actively polling and agl-service-nfc sends a request to start polling, the requests are being rejected and an error message issued. The changes in this commit are intended to avoid these scenarios, taking into account that neard is configured to: (1)power the device up by default, and (2)not re-start the device in polling mode unless requested by the client (agl-service-nfc). - Check the adapter state before applying power or set the adapter in active polling mode as initiator. - Add neardal adapter callbacks to track status of the interface instead of using local variables. - Exit polling loop if the adapter is removed. - Update dbg macros to be more meaningful. Bug-AGL: SPEC-1976 The following changes are to increase safety measures around variables used on calls to/from neardal. - Test arguments in callback functions. - Install/remove tag callbacks in every iteration. - Match g_malloc'ed nfc_data_binding with g_free. Change-Id: If26d685a917633c9a0dd6997ad371db60a640517 Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
2018-12-04binding: nfc: check request value field on subscribe & unsubscribeguppy_6.99.3guppy/6.99.36.99.3Raquel Medina1-2/+18
Bug-AGL: SPEC-1994 - check subscribe/unsubscribe requests from client are for a valid event. Change-Id: Icb020e35f2c70a83b1a043a03827d25ed2e94d17 Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
2018-11-30nfc: binding: fix formatting.guppy_6.99.2guppy/6.99.26.99.2Raquel Medina1-23/+17
This commit includes the following changes resulting from code review of commit b7cae49a6d1b4c5dba12647e2b30e635b8993a92, and requested to be on a separate commit: - fixes indentation on several lines - substitutes malloc+return error for g_malloc0 Change-Id: I8591868b759a454be2ee2bfc21c88e9563fa2535 Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
2018-11-28binding: nfc: Process content data from tag (adapter in tag reader mode)Raquel Medina1-103/+189
Bug-AGL: SPEC-1975 - Register callback for tag found - Update callback for record found - Fix memory leak Change-Id: I870648f3c5771aa1b54b710ef6b75786a1c67f65 Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
2018-11-23binding: nfc: Fix segmentation fault.guppy_6.99.1guppy/6.99.16.99.1Raquel Medina1-107/+141
Bug-AGL: SPEC-1959 Duplicate reply (xreq_reply_cb) causes the segmentation fault when the adapter is plugged in at boot time. Several changes have been applied to fix this issue: - remove reply on subscribe for presence_event(only reply from loop); - power the adapter up only after configuration is complete; - update req & api artifacts to implement v3 bindings. Change-Id: I945de9dc1fee0a95859f28b9d77b627cb998fa1b Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
2018-11-13binding: nfc: remove dependencies on libnfcRaquel Medina1-126/+1
Bug-AGL: SPEC-1921 - remove dependencies on libnfc - remove unused code (binding/afm-nfc-common.c) Change-Id: I824094f5d7a409739c479904662e21c900cc8509 Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
2018-11-02Revert "binding: nfc: return error code in init() function"Matt Ranostay1-2/+2
This reverts commit 1cb99d7d2a7ecd26a9ddf54c99440416a22e0dc4. This change is actually needed to stop a systemd service restart loop if no adapters are present. Change-Id: I56da0ddf2a00b9df12b2e78719745c2823b66588 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2018-10-18binding: nfc: return error code in init() functionMatt Ranostay1-2/+2
Change-Id: I8a86ddf385b96aeba86a7ea92ed71fc0972ce57a Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2018-08-23binding: nfc: workaround service exiting if no adaptersguppy_6.90.0guppy/6.90.0flounder_5.99.6flounder_5.99.5flounder_5.99.4flounder/5.99.6flounder/5.99.5flounder/5.99.46.90.05.99.65.99.55.99.4Matt Ranostay1-4/+4
Don't return an error code from init() even with no adapters are present to avoid service from exiting. Bug-AGL: SPEC-1683 Change-Id: I9c77950887a2d4e8163bd2fb2cce8b00af8b4574 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2018-07-19binding: nfc: remove current_uid from globals declarationsflounder_5.99.3flounder_5.99.2flounder/5.99.3flounder/5.99.25.99.35.99.2Matt Ranostay1-2/+2
current_uid is no longer needed now that the json_object response is cached Bug-AGL: SPEC-1554 Change-Id: If6019ff52dcb61f18616c927a489e0fb0ed90c35 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2018-07-17binding: nfc: add neardal support for reading NDEF encoded tagsMatt Ranostay1-1/+110
Read RFID tags via neardal helper library that are NDEF encoded Bug-AGL: SPEC-1544 Change-Id: I90c0e8b4dec705ef56c7303ec2a592ca6ab9054c Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2018-07-17binding: nfc: use cached json_object for eventsMatt Ranostay1-10/+29
Cache the json_object for event response for detect for future subscribers Bug-AGL: SPEC-1554 Change-Id: I4dfeb7f157a872db96c8c5fabae9c26547815baa Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2018-07-17binding: nfc: convert binding to afb version 3Matt Ranostay1-6/+6
In order to use some of the features of v3 we need to update the data structures naming, and function parameters. Change-Id: I6c217a8f4c28053c838af9f324b1504a3e1cbf71 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2018-07-13binding: nfc: move libnfc checks from threadMatt Ranostay1-24/+45
To allow runtime detection of libnfc vs neard devices in the future libnfc check needs to be moved out of nfc_thread_loop Bug-AGL: SPEC-1554 Change-Id: I53854838a2fcab7eefbed3ed8d165a14e2bdc9db Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2018-07-13binding: nfc: split out common functionsMatt Ranostay1-17/+2
Put common functions that libnfc and neard will use in a common header Bug-AGL: SPEC-1554 Change-Id: I723cee58a2265bf0574f54cb0b9ff4af5647da73 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2018-07-04binding: nfc: new initial bindingMatt Ranostay1-0/+200
Slight rewrite to use libnfc initially for getting tag uid's for user settings. Bug-AGL: SPEC-1554 Change-Id: I7b8c30102b82e86a92c89909bcbfba9ab7164c1f Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>