Linting improvments.

Uninitiliazed variable in submodule
Better handling of iterator assigments
Avoid multiple call to vector.size() function

Change-Id: I9cc8431e71b7d614a1619615a4048f19f5e31540
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

1 files changed, 6 insertions, 3 deletions

diff --git a/signal-composer-binding/clientApp.cpp b/signal-composer-binding/clientApp.cpp
index da4bb72..854f96e 100644
--- a/signal-composer-binding/clientApp.cpp
+++ b/signal-composer-binding/clientApp.cpp
@@ -37,16 +37,19 @@ void clientAppCtx::appendSignals(std::vector<std::shared_ptr<Signal>>& sigV)
 	for (std::vector<std::shared_ptr<Signal>>::const_iterator it = sigV.cbegin();
 	it != sigV.cend(); ++it)
 	{
+		std::shared_ptr<Signal> sig = nullptr;
 		for (auto& ctxSig: subscribedSignals_)
 			{if(*it == ctxSig) {set = true;}}
 		if (set)
 		{
 			set = false;
 			sigV.erase(it);
-			continue;
 		}
-		std::shared_ptr<Signal> sig = *it;
-		sig->addObserver(this);
+		else
+		{
+			std::shared_ptr<Signal> sig = *it;
+			sig->addObserver(this);
+		}
 	}
 
 	subscribedSignals_.insert(subscribedSignals_.end(), sigV.begin(), sigV.end());